2f64812 · 4ac66e8
@@ -0,0 +1,29 @@
# Looks of `/` signed out
The forge's looks service already takes these; nothing is attached by hand.
Every preview of the forge's own repository takes `/?as=signedout` as nobody
(`PREVIEW_SIGNED_OUT_PAGE` in `src/spawn/preview-looks.ts`), at phone and
desktop width, each light and dark. `/` itself is the signed-in home, so the
signed-out page is the same route with a query it ignores and no session.
## Where to find them on a pull
- `GET /api/v1/repos/trevato/forge/pulls/<n>/looks` lists them; newest first,
  for the pull's latest commit. The four are the items whose `url` ends in:
  - `-as-signedout-phone.png` and `-as-signedout-phone-dark.png`
  - `-as-signedout-desktop.png` and `-as-signedout-desktop-dark.png`
- The pull page shows them beside main's, and `I` on the pull in the terminal
  lists them (see `pull-looks.md`).
- The urls look like `/trevato/forge/looks/pull-<n>/<commit>/-as-signedout-phone.png`.
  Link them from the issue by those urls.
A pull touching `src/web/studio/home.ts` needs no extra step: push, wait for
the preview to serve, and the four appear. Looks fill in as the round goes, so
list again if one is missing.
## The phone is 390 px, not 360
The phone look is `LOOK_SIZES.phone` (`src/core/looks.ts`): 390 × 844, the
width every phone look of every page uses. Desktop is 1280 × 800. No 360 px
look is taken; a page that fits 390 px is not proof it fits 360. Adding one is
a change to the looks service's sizes, not to this page.
		@@ -0,0 +1,29 @@
	1	# Looks of `/` signed out
	2
	3	The forge's looks service already takes these; nothing is attached by hand.
	4	Every preview of the forge's own repository takes `/?as=signedout` as nobody
	5	(`PREVIEW_SIGNED_OUT_PAGE` in `src/spawn/preview-looks.ts`), at phone and
	6	desktop width, each light and dark. `/` itself is the signed-in home, so the
	7	signed-out page is the same route with a query it ignores and no session.
	8
	9	## Where to find them on a pull
	10
	11	- `GET /api/v1/repos/trevato/forge/pulls/<n>/looks` lists them; newest first,
	12	for the pull's latest commit. The four are the items whose `url` ends in:
	13	- `-as-signedout-phone.png` and `-as-signedout-phone-dark.png`
	14	- `-as-signedout-desktop.png` and `-as-signedout-desktop-dark.png`
	15	- The pull page shows them beside main's, and `I` on the pull in the terminal
	16	lists them (see `pull-looks.md`).
	17	- The urls look like `/trevato/forge/looks/pull-<n>/<commit>/-as-signedout-phone.png`.
	18	Link them from the issue by those urls.
	19
	20	A pull touching `src/web/studio/home.ts` needs no extra step: push, wait for
	21	the preview to serve, and the four appear. Looks fill in as the round goes, so
	22	list again if one is missing.
	23
	24	## The phone is 390 px, not 360
	25
	26	The phone look is `LOOK_SIZES.phone` (`src/core/looks.ts`): 390 × 844, the
	27	width every phone look of every page uses. Desktop is 1280 × 800. No 360 px
	28	look is taken; a page that fits 390 px is not proof it fits 360. Adding one is
	29	a change to the looks service's sizes, not to this page.