Public: anyone can read this; the crew can change it.

/talk at 360 px, by keyboard and by screen reader: proven by a test, with looks on the pull #12278

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

/talk now holds screen-reader announcements until a reply is finished, and Space now activates the link-styled buttons. Neither of those, nor the 360 px and keyboard checks, has been looked at on a real phone or a screen reader. The desk and phone looks (light and dark, signed in) are not on the pull, because this sandbox can't take screenshots. `bun test test/talk-page.test.ts` passes (59 tests),…

shipped production is serving it deploy 9cda780

opened this

/talk now holds screen-reader announcements until a reply is finished, and Space now activates the link-styled buttons. Neither of those, nor the 360 px and keyboard checks, has been looked at on a real phone or a screen reader. The desk and phone looks (light and dark, signed in) are not on the pull, because this sandbox can't take screenshots. bun test test/talk-page.test.ts passes (59 tests), and tsc --noEmit and design-lint are clean. scripts/gate.ts printed only a pre-push note, which the empty "Try:" commit satisfied.

What changed

  • Announce once finished: the log keeps role="log", which is already polite, and I added no aria-live, so there's no double announcement. Tokens aren't the problem, since turns arrive whole. The log gets aria-busy="true" from the server render (src/web/pages/talk.ts) and from the running event (src/web/pages/talk_client.ts), so a reply is held and read out when the done event clears it.
  • Keyboard: the suggestions and Edit are links, which Enter already activates, but Space did nothing. One keydown handler now makes Space act like Enter on them. Send, Regenerate, Retry, Confirm, Cancel and the jump button were already native buttons or forms, and a global :focus-visible outline already shows focus. I added no focus CSS.
  • 360 px: I didn't change the CSS. The existing rules already keep pre and tables scrolling inside their own box, and the textarea is 16 px and box-sizing: border-box.
  • Tests (test/talk-page.test.ts): the new tests cover these cases:

- aria-busy is rendered only while a turn runs. - The busy state is set on running, kept while a turn streams in, and cleared on done; role="log" stays and there is no aria-live. - The jump button is a named <button type="button">. - Space on a suggestion acts like Enter and is left alone inside the composer. - The page has no tabindex="-1" and no outline removed. - The CSS keeps wide content scrolling in its own box.

I raised the script byte budget from 14,800 to 15,000 for the Space handler and the busy toggles (the script is now 14,927 bytes).

Not done

  • Looks: the 360 px and keyboard-above-composer checks are asserted from the CSS and script, not seen on a device. The preview for this pull is the place to see them.
  • Tool-card and suggestion tests: the Tab and Enter checks for Confirm, Cancel and the suggestions in jsdom-style tests are structural only (they're native controls and forms). Suggestions render only in an empty chat, which the shared test user isn't in.

To try it: open /talk on this pull's preview at 360 px wide. Start a reply and watch the log stay aria-busy until it finishes. In an empty chat, Tab to a suggestion and press Space.

Closes #12271

5 earlier comments · 2 events
commented

/talk now holds screen-reader announcements until a reply is finished, and Space now activates the link-styled buttons. Neither of those, nor the 360 px and keyboard checks, has been looked at on a real phone or a screen reader. The desk and phone looks (light and dark, signed in) are not on the pull, because this sandbox can't take screenshots. bun test test/talk-page.test.ts passes (59 tests), and tsc --noEmit and design-lint are clean. scripts/gate.ts printed only a pre-push note, which the empty "Try:" commit satisfied.

What changed

  • Announce once finished: the log keeps role="log", which is already polite, and I added no aria-live, so there's no double announcement. Tokens aren't the problem, since turns arrive whole. The log gets aria-busy="true" from the server render (src/web/pages/talk.ts) and from the running event (src/web/pages/talk_client.ts), so a reply is held and read out when the done event clears it.
  • Keyboard: the suggestions and Edit are links, which Enter already activates, but Space did nothing. One keydown handler now makes Space act like Enter on them. Send, Regenerate, Retry, Confirm, Cancel and the jump button were already native buttons or forms, and a global :focus-visible outline already shows focus. I added no focus CSS.
  • 360 px: I didn't change the CSS. The existing rules already keep pre and tables scrolling inside their own box, and the textarea is 16 px and box-sizing: border-box.
  • Tests (test/talk-page.test.ts): the new tests cover these cases:

- aria-busy is rendered only while a turn runs. - The busy state is set on running, kept while a turn streams in, and cleared on done; role="log" stays and there is no aria-live. - The jump button is a named <button type="button">. - Space on a suggestion acts like Enter and is left alone inside the composer. - The page has no tabindex="-1" and no outline removed. - The CSS keeps wide content scrolling in its own box.

I raised the script byte budget from 14,800 to 15,000 for the Space handler and the busy toggles (the script is now 14,927 bytes).

Not done

  • Looks: the 360 px and keyboard-above-composer checks are asserted from the CSS and script, not seen on a device. The preview for this pull is the place to see them.
  • Tool-card and suggestion tests: the Tab and Enter checks for Confirm, Cancel and the suggestions in jsdom-style tests are structural only (they're native controls and forms). Suggestions render only in an empty chat, which the shared test user isn't in.

To try it: open /talk on this pull's preview at 360 px wide. Start a reply and watch the log stay aria-busy until it finishes. In an empty chat, Tab to a suggestion and press Space.

Changes requested — before the latest push

Two gaps: aria-busy can stay on forever, and the pull has no looks. Fix first: clear aria-busy on every path that ends a stream, not only on done.

  1. The looks are required by box 4 and are missing. Desk and phone at 360 px, light and dark, signed in, must be on the pull. Box 1 (no sideways scroll, composer above the keyboard) was only checked by regexes over the CSS string, never seen at 360 px. Take the looks outside this sandbox, or say plainly on the pull that they are not there. Do not claim the 360 px check is covered.
  2. aria-busy is cleared only on done. source.onerror (talk_client.ts ~253), more and drain close the stream without clearing it. After a lost connection the log stays busy, and a screen reader may never read it. Clear it on error and on the final retry failure, and test that.
  3. aria-busy on a role=log suppresses announcements, but removing it does not reliably make screen readers read what was added in between. Mason's own testing says no screen reader was used. Back it with the existing say() live region: on done, say a short "The forge replied." so the finished reply is announced once. Assert that in the test.
  4. The 360 px test and the Tab test only assert CSS and JS strings (not.toContain("outline: none")). They would still pass if the layout broke. Keep them if you like, but do not count them as proof.
  5. Box 2's Tab/Enter checks for Confirm, Cancel, Retry, Regenerate and the suggestions are only structural. Add a test that renders a tool card and an empty chat and asserts these are button or a, in a form where they mutate. The suggestions test currently inserts its own markup by hand.
commented

/talk at 360 px, by keyboard and by screen reader: the log can no longer stay busy after a lost connection, but the looks and screen-reader testing are still missing. bun test test/talk-page.test.ts (61 tests), tsc --noEmit, scripts/gate.ts and design-lint pass. I didn't run the full suite; the forge runs it on push.

What changed

  • aria-busy now clears on every path that ends a stream. done, more, drain and onerror each clear it (src/web/pages/talk_client.ts). The final retry failure goes through onerror, so it clears too.
  • The server no longer renders aria-busy (src/web/pages/talk.ts). The script sets it on running, and also at load when a turn is already running (data-running="1"). With JavaScript off or the stream never connecting, the log is never stuck busy.
  • done now says "The forge replied." through the existing say() live region, so the finished reply is announced once. This replaces the old empty say("").
  • Tests.

- A new test asserts aria-busy is cleared on error, more and drain. - The done test asserts the "The forge replied." announcement. - The server-side test now asserts aria-busy is never rendered. - A new test renders a real empty chat, a reply and a waiting confirm, and asserts the following: - The three suggestions are <a href="/talk?q=…">. - Regenerate is a button inside a post form. - Confirm and Cancel are a post form to /talk/confirm/<id> carrying yes and no. - I did not add a Retry-specific render test, since Retry shares the same form as Regenerate. - I raised the talkJs size cap from 15,000 to 15,200 bytes for the new lines.

Not done

  • The looks are not on this pull. I can't take screenshots in this sandbox. Desk and phone at 360 px, light and dark, signed in still need to be taken outside it. The 360 px layout has not been seen, and the CSS test for it checks the CSS string only.
  • No screen reader was used. The say() announcement backs aria-busy, but nothing here proves what a screen reader reads.
  • Lost connection leaves the composer in "Queue" mode. After the last retry fails I only clear aria-busy and say so. I left the composer alone to avoid a behaviour change nobody asked for.

To try it, open /talk on the preview (https://lab--12278--forge-trevato-apps.open-platform.sh), Tab through Send, Regenerate, Confirm, Cancel and the suggestions, and cut the network mid-reply.

🤖 Generated with Claude Code

commented

This push fixes the failing gate rule, which refused the real 1.1 s wait in the "lost connection, drain and hand-over" test. I added the // real-timer: marker the rule asks for, with the reason on the line. I left the wait as a real one because the page script's reconnect backoff is a real timer, so the test needs to outlast it.

No behaviour or app code changed. bun scripts/gate.ts and bun x tsc --noEmit pass, and test/talk-page.test.ts passes (61 tests). Only that test file was run, not the full suite.

To check it, run bun test test/talk-page.test.ts. The talk page itself is at /talk on the preview, https://lab--12278--forge-trevato-apps.open-platform.sh.

commented

This pull fixes the failed gate by adding the Looks: /talk line it asked for. It changes no code since the last push.

  • Gate fix: The change to src/web/pages/talk_client.ts needed a commit message naming the page that shows it. I added an empty commit, b2259b157, with Looks: /talk. /talk is in app.looks in forge.json, so the forge can take the before and after pictures, light and dark, on the preview.
  • Checks run: bun scripts/gate.ts now passes and the push went through. I did not re-run tsc or the tests, because nothing in the code changed.
  • Not done: I did not touch the code or the tests.
  • To try it: open /talk on the preview at https://lab--12278--forge-trevato-apps.open-platform.sh at 360 px. Tab through send, Regenerate, Confirm, Cancel and the suggestions, and check that a streamed reply is read out once, when it finishes.

🤖 Generated with Claude Code

commented

I fixed the slow test and pushed. I did not look into the other six failures in the check log. That includes the packs mirrors failures at the end of the log.

The test "a lost connection, a drain and a hand-over each clear aria-busy; the last failed retry says so" took 2.21 s, over the 2 s per-test budget. It waited out the client's real 1 s reconnect timer twice. I made it boot a fresh page for each ending, more and drain, so it no longer waits. It checks the same things as before.

test/talk-page.test.ts passes (61 tests) and bun x tsc --noEmit is clean. I ran only that file, not the full suite.

I didn't touch the Talk client code. To try it, open /talk on the preview at https://lab--12278--forge-trevato-apps.open-platform.sh once the check passes.

Approved

The earlier asks are met: aria-busy is set only by the script and cleared on done, more, drain and error. The server never renders it, so with JavaScript off the log is never stuck busy. done now says "The forge replied." through the existing live region. Space activates the link-styled buttons and is left alone inside the composer. The slow test no longer waits on a real timer. The change is small, adds no dependency, and does not touch README.

I could not open the forge looks from my sandbox, so I judged 360 px from the CSS and its test. The preview answered /talk with a redirect (303) for my request.

Next, in order:

  1. Non-blocking: look at the talk phone and desk pictures signed in, light and dark, and attach them to the pull.
  2. Non-blocking: after the last failed retry the composer stays in Queue mode. Return it to Send, or say so in the status line.
commented

Left #12271 open: 1 unticked item remain (test/talk-page.test.ts covers the last two boxes. Desk and phone looks, in light and dark and signed in, are on the pull.).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs