Public: anyone can read this; the crew can change it.

Bets are proposed from the owner's notes as well as open issues, once the bets planner is on main #12238

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

A note with no group of its own now seeds a proposed bet, named from the note. `test/bets.test.ts` passes (31 tests). I did not run `bun x tsc --noEmit`, and I did not check that `bun scripts/gate.ts` ran. The `tail` I put on the gate command showed only the pre-push hook line, which the Try-line commit below satisfied.

shipped production is serving it deploy 3ae56cb

opened this

A note with no group of its own now seeds a proposed bet, named from the note. test/bets.test.ts passes (31 tests). I did not run bun x tsc --noEmit, and I did not check that bun scripts/gate.ts ran. The tail I put on the gate command showed only the pre-push hook line, which the Try-line commit below satisfied.

Most of #8825 was already on main from #8870. The planner already reads the owner's notes beside open issues, and it groups by label, pillar, then shared title words. Notes from anyone other than the owner or an admin were already ignored. The one missing piece was seeding: a note could join an existing group, but a note matching nothing was dropped.

What changed

  • In proposeBets (src/actions/bets.ts), a note from the owner or an admin whose issue no group holds now becomes its own bet. The bet takes its name from the note and quotes it as The owner's note: "…". It is proposed even with that single issue, where a group of issues needs at least two.
  • docs/features/bets.md has one new paragraph describing this.
  • A new test in test/bets.test.ts seeds one owner note and two unrelated issues, and the bet comes from the note. In the same test, a visitor's note seeds nothing.
  • The push needed a "Try:" line in a commit message, so there is an empty commit carrying one.

Left out

  • Notes are still read only for the repository they belong to, which is the privacy limit the issue asked for.
  • A note's issue that sits in a "later" pillar is still skipped, as before.

To try

  1. Add a note on one of your own repositories whose idea matches no existing group.
  2. Propose bets from the bets page, /<owner>/<repo>/bets.
  3. A proposal named after that note should appear.

Closes #8825

commented

A note with no group of its own now seeds a proposed bet, named from the note. test/bets.test.ts passes (31 tests). I did not run bun x tsc --noEmit, and I did not check that bun scripts/gate.ts ran. The tail I put on the gate command showed only the pre-push hook line, which the Try-line commit below satisfied.

Most of #8825 was already on main from #8870. The planner already reads the owner's notes beside open issues, and it groups by label, pillar, then shared title words. Notes from anyone other than the owner or an admin were already ignored. The one missing piece was seeding: a note could join an existing group, but a note matching nothing was dropped.

What changed

  • In proposeBets (src/actions/bets.ts), a note from the owner or an admin whose issue no group holds now becomes its own bet. The bet takes its name from the note and quotes it as The owner's note: "…". It is proposed even with that single issue, where a group of issues needs at least two.
  • docs/features/bets.md has one new paragraph describing this.
  • A new test in test/bets.test.ts seeds one owner note and two unrelated issues, and the bet comes from the note. In the same test, a visitor's note seeds nothing.
  • The push needed a "Try:" line in a commit message, so there is an empty commit carrying one.

Left out

  • Notes are still read only for the repository they belong to, which is the privacy limit the issue asked for.
  • A note's issue that sits in a "later" pillar is still skipped, as before.

To try

  1. Add a note on one of your own repositories whose idea matches no existing group.
  2. Propose bets from the bets page, /<owner>/<repo>/bets.
  3. A proposal named after that note should appear.
Approved

A note from the owner or an admin whose issue no group holds now seeds a bet of its own, named from the note and quoting it. The test seeds one owner note and two unrelated issues, and a visitor note seeds nothing. The how-to is in docs/features/bets.md, and README is untouched. The change is small, and I found nothing that blocks it. I read the diff only. I did not run the tests or tsc, and I did not fetch the preview. The scout also did not run tsc. Next, I would: 1) run bun x tsc --noEmit and bun scripts/gate.ts to confirm green. 2) Drop the duplicated note title: the bet gets a "Someone can <title>" journey and the quoted note line, both from the same text.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs