Public: anyone can read this; the crew can change it.

Red after landing: 3195584 broke test/spawn-app-links.test.ts #12216

Closed opened this in answer to
Closed without merging

This pull fixes two tests that were red on main. I couldn't reproduce the rest of the list from #12208, and I didn't chase them. What I found.

Notes

stopped closed without shipping deploy 41f53c3

opened this

This pull fixes two tests that were red on main. I couldn't reproduce the rest of the list from #12208, and I didn't chase them.

What I found. Commit 3195584 isn't the cause. Its three edits (the run and pull queries and two retention constants) leave test/cookie-flags.test.ts and test/spawn-app-links.test.ts green at this branch's HEAD. The failures that do reproduce come from later commits.

What changed.

  • test/job-slices.test.ts: the child-db-deadline timer, added in 8ae6610, now has an entry in UNTIMED with a reason. That test fails when a job run under during is neither timed nor listed there.
  • workingNowCount in src/actions/runs.ts: the Runs tab count, added in d8d832c, made one sealed-row query per running run. test/app-home-batched.test.ts caught it, because the home page cost grew with the number of runs. The count now reads every issue the running runs name in one query, using eventRows from src/core/sealed.ts. It applies the same mayView check, so the count still matches the list.

What I ran. The test/job-slices, test/app-home-batched and test/runs* tests, plus the test/sealed*, test/no-alarm-banner, test/client-size and test/snappy tests, all pass except the one below. tsc --noEmit and scripts/gate.ts report nothing.

Not fixed.

  • *test/runs.test.ts:** "the runs list is bare rows, not a boxed card (#9727)" fails the same way without my change, so I left it.
  • test/spawn-app-links.test.ts: its "could not follow its parent" log errors are posix_spawn 'git' not found in my sandbox. The suite still passes. I did not run the other files in the issue's list.

To try it. Open a public repository, then compare the Runs tab count with /runs?word=working. Both should show the same number.

Closes #12208

2 earlier comments
commented

This pull fixes two tests that were red on main. I couldn't reproduce the rest of the list from #12208, and I didn't chase them.

What I found. Commit 3195584 isn't the cause. Its three edits (the run and pull queries and two retention constants) leave test/cookie-flags.test.ts and test/spawn-app-links.test.ts green at this branch's HEAD. The failures that do reproduce come from later commits.

What changed.

  • test/job-slices.test.ts: the child-db-deadline timer, added in 8ae6610, now has an entry in UNTIMED with a reason. That test fails when a job run under during is neither timed nor listed there.
  • workingNowCount in src/actions/runs.ts: the Runs tab count, added in d8d832c, made one sealed-row query per running run. test/app-home-batched.test.ts caught it, because the home page cost grew with the number of runs. The count now reads every issue the running runs name in one query, using eventRows from src/core/sealed.ts. It applies the same mayView check, so the count still matches the list.

What I ran. The test/job-slices, test/app-home-batched and test/runs* tests, plus the test/sealed*, test/no-alarm-banner, test/client-size and test/snappy tests, all pass except the one below. tsc --noEmit and scripts/gate.ts report nothing.

Not fixed.

  • *test/runs.test.ts:** "the runs list is bare rows, not a boxed card (#9727)" fails the same way without my change, so I left it.
  • test/spawn-app-links.test.ts: its "could not follow its parent" log errors are posix_spawn 'git' not found in my sandbox. The suite still passes. I did not run the other files in the issue's list.

To try it. Open a public repository, then compare the Runs tab count with /runs?word=working. Both should show the same number.

commented

I merged main into the branch and pushed. After the merge, this pull no longer changes any file against main.

main had already fixed both failures I fixed earlier. It batched the Runs tab count's sealed lookup in src/actions/runs.ts, which was the file that conflicted. It also listed the child-db-deadline job in test/job-slices.test.ts. I took main's version of both files, because keeping my runs.ts change on top would have duplicated its work and keeping my job-slices entry duplicated an object key.

bun x tsc --noEmit reports nothing. test/job-slices.test.ts and test/app-home-batched.test.ts pass, 8 tests, 0 failures. I didn't rerun the other suites after the merge.

An empty pull should be closed rather than merged. #12208's other failures didn't reproduce for me, and the "bare rows" test in the runs tests fails the same way without my change.

commented

Closed by the crew: superseded, its change is already on main in de9e1b03.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs