A new account on a forge that sends no mail can contribute #12111

On a forge with no mail configured, a new account can now fork and open pulls straight after sign-up, as a /start account can. I haven't run the full suite, and one guest-contribute test fails here because of the sandbox. The forge's check will run everything.

What changed

• No-mail rule: requireVerified in src/actions/verify.ts now passes when the forge cannot send mail, through a new mayCreate(app, user). Every action behind that gate follows, including fork, open pull, create repo and tell.
• Other gates: two checks that bypassed requireVerified use mayCreate too. They are the crew-add tool in src/http/mcp/tools/crew.ts and the run-on-speech check in src/crew/dispatch.ts.
• Newcomer cooldown: the new-account cooldown, forge-wide fork limits and storage limits are untouched. A brand-new account still waits out the guest cooldown before forking.
• People page: the "Email not verified" badge and the per-account "Verify email" button were already there. The "Mail is not configured" notice now says unverified newcomers may fork and open pulls, and that the list marks who is.
• Mail configured: if the forge can send mail, verification is still required.

Tests

• New: test/no-mail-contribute.test.ts covers sign-up, fork, commit and open pull on a no-mail forge, then checks that the owner's accounts API and page list casey as unverified. It fails without the source change.
• test/accounts.test.ts: I changed the owner-verifies-newcomer test, which expected a 403 on create before verification. Without mail that is no longer true, so it now expects 201 first.
• Four suites given a mailer: guests, guest-contribute, mcp-crew and crew-direction test the unverified refusal. They now start their app with a stub mailer so mail counts as configured and that path stays covered.
• Checks run: tsc --noEmit is clean, and I ran 14 related test files by hand. scripts/fast.ts said the diff was too broad to name tests, so I picked them myself.
• Sandbox failure: the guest-contribute test "a person's own agent attaches by OAuth…" fails on its git push over HTTP. It fails the same way without my change, so I read it as the sandbox and left it alone.
• Not run: I didn't run scripts/design-lint.ts. I didn't check whether scripts/gate.ts passed before the push.

Not done: there is no "verified by owner" label beyond the existing badge, and no change to the TUI people screen text.

Try it: boot a forge with no FORGE_SMTP_URL, sign up through POST /api/v1/users, fork a public repo, and open a pull. Then view /settings/accounts as the owner.

🤖 Generated with Claude Code

On a forge with no mail, a new account can now fork a repository and open a pull without verifying its email. I pushed this, but the full suite has not run on the new commit. The forge's check will be the first full run.

What went wrong: my first version skipped the email proof everywhere. Most of the 39 failures were tests that expect an unverified account to be refused on a mail-less test forge. This version relaxes only the two paths the issue names.

What changed:

• Fork and guest pull: src/actions/verify.ts gains mayContribute and requireContributor, which let an unproven account through when the forge has no mail. forkRepo (src/actions/repos.ts) and takeGuestPull (src/actions/guests.ts) use it.
• Unchanged: every other requireVerified caller, including creating a repository, starting a run, org creation and sealed forks.
• People page: the /settings/accounts "Mail is not configured" notice now says newcomers may fork and open pulls unverified, and that the list marks who is. The "Email not verified" mark already existed.
• Tests: test/no-mail-contribute.test.ts covers sign-up, fork, open pull, then the owner's list showing "Email not verified". test/guest-contribute.test.ts now gives its app a mailer so its "unconfirmed account is refused" case stays meaningful.

Run here: bun x tsc --noEmit is clean, and scripts/gate.ts printed nothing I could see. The tests I ran that touch fork and guest-pull behaviour pass, apart from a few that fail the same way with my changes stashed:

• fork-flow.test.ts, propose-via-fork.test.ts and contribute-refusals.test.ts fail the same way on the unchanged code, with the sandbox denying outbound network.
• The "own agent attaches by OAuth" test in guest-contribute.test.ts also fails on the unchanged code, on a git push returning 128.
• scripts/design-lint.ts flags one 17px font size in src/web/studio/cards.ts, a file I did not touch.
• bun scripts/fast.ts named 2351 of 3019 files, so I did not run the full suite.

Not done: MCP crew add, dispatch and run starts still require a verified email. The issue named only fork and open pull, and widening them broke the many tests that assume the refusal.

To try: with no mail secrets set, sign up at POST /api/v1/users and fork a public repo. Open a pull from the fork, then look at /settings/accounts as the owner.

On a forge that sends no mail, a new account can now fork a public repo and open a pull without verifying its email. Everything else that costs still waits for the proof. I fixed two of the 22 check failures, both caused by this change; the other 20 I believe are not from this pull, though I did not confirm they fail on main.

Fixed:

• test/make-it-yours.test.ts and test/config-form.test.ts build an app with no mailer. The new rule now lets their unverified accounts fork, so the "unverified is refused" assertions failed. Those two tests now give the app a mailer, since the cases they check are about a forge that sends mail. The test code was wrong, not the product code. Both files pass, along with test/guests.test.ts and test/no-mail-contribute.test.ts. bun x tsc --noEmit and bun scripts/gate.ts are clean.

Left alone: the other 20 failures are in files this pull doesn't touch:

• src/web/studio/cards.ts has a 17px font-size that the design check rejects.
• src/crew/week_burn.ts is imported by nothing.
• The /home page is missing from the app's looks list.
• The home KPI and retention queries, the cookie-flag and docs checks, and the page-budget tests fail too.

The guest-contribute test that pushes over git also fails here with exit 128, which looks like the sandbox rather than the code. I haven't run the other guest-contribute cases beyond that one. The forge's full check will show whether the 20 persist.

What to look at: requireContributor in src/actions/verify.ts. It is used only by forkRepo and takeGuestPull.

Parked by the crew: the check stayed red through 2 automatic tries

On a forge that sends no mail, an unverified account may fork a public repo and open a pull. Creating a repository still waits for verification. It serves #12106 and does not widen the rule.

• Check (item 1): The check on head 656ab81d3 is green: "check passed in 1091s". It lists six tests that are already red on main at 127a6c2, so none come from this change: runs-state-filter, unread-tables, job-slices, tui-live-gap, releases-timing and app-home-batched. The two failures that parked the pull were earlier runs, and I could not read their logs. I did not rerun the whole suite here.
• Notice, both doors (items 2 and 5):

- The web notice in src/web/pages/accounts.ts is now one sentence: "Newcomers cannot verify themselves, so they fork and open pulls unverified. Verify them here, or set … under Secrets." - The terminal People line says the same in fewer words: "Newcomers fork and open pulls unverified. v verifies, or set MAIL_SMTP_URL." It had to fit 80 columns, so it is shorter than the web sentence. test/tui-people-mail.test.ts now asserts it.

• Docs (item 3): docs/features/welcome.md has a new section, "A forge that sends no mail". README.md is untouched.
• Tests (item 4): test/no-mail-contribute.test.ts now has three more cases:

- With no mail, an unverified account is still refused repository creation with unverified. - With no mail, the new-account cooldown still refuses fork and pull with guest_cooldown. - With a mailer configured, an unverified account is refused fork over HTTP with "verify your email first", and refused pull with unverified.

• Pull test via the action, not HTTP: The mailer-configured pull case calls takeGuestPull directly. The HTTP pull request returned not_found because the fork it names doesn't exist in that setup.

tsc and scripts/gate.ts are clean, and the touched tests pass (54). design-lint reports one off-scale font size in src/web/studio/cards.ts, a file this pull doesn't touch.

🤖 Generated with Claude Code