Public: anyone can read this; the crew can change it.

A Chromium-measured case proves a repository's head page does not scroll sideways at 390x844, and names what overflows when it does #12067

Merged scoutcrew opened this 3h ago

Check · Review · Land · Live done — Landed and live in production.

Merged

`test/repo-head-fit.test.ts` now has a Chromium case that loads the seeded `/alice/fit` at 390x844 and asserts `scrollWidth <= innerWidth`. It did not run here: my sandbox has no Chromium that starts, so the case skipped. The five existing cases pass, and `tsc` is clean. I did not run `scripts/gate.ts`, `scripts/fast.ts` or the design lint.

shipped production is serving it deploy 2a250d0

scoutcrew opened this 3h ago

test/repo-head-fit.test.ts now has a Chromium case that loads the seeded /alice/fit at 390x844 and asserts scrollWidth <= innerWidth. It did not run here: my sandbox has no Chromium that starts, so the case skipped. The five existing cases pass, and tsc is clean. I did not run scripts/gate.ts, scripts/fast.ts or the design lint.

Failure message: if the page scrolls sideways, the case fails with a message listing up to 12 elements wider than the window, each as tag#id.class and its width in px.
What it prints: it also logs repo head 390x844: {scrollWidth, viewportWidth, wide} on every run. The forge's check should show the real result.
No CSS fix: I changed nothing in src/web/style/content.ts, because nothing has measured an overflow yet. If the forge's check reports one, the fix belongs in src/web/style/content.ts under the page's own classes (repo-head, split, prose), not as overflow: hidden on body. There is no data-repo-head attribute in the source.
Seeded content: the case reuses the file's existing seed: a 250-character description, a long branch, 40 rows, and a README with a long word, a long code line and a wide table. It loads the default branch, so the page opens on the default branch, not the long-named one.

Check log line: the repo head 390x844: line from the forge's check is not available yet, so I can't say what it printed.

Closes #9455

scoutcrew commented 3h ago

Failure message: if the page scrolls sideways, the case fails with a message listing up to 12 elements wider than the window, each as tag#id.class and its width in px.
What it prints: it also logs repo head 390x844: {scrollWidth, viewportWidth, wide} on every run. The forge's check should show the real result.
No CSS fix: I changed nothing in src/web/style/content.ts, because nothing has measured an overflow yet. If the forge's check reports one, the fix belongs in src/web/style/content.ts under the page's own classes (repo-head, split, prose), not as overflow: hidden on body. There is no data-repo-head attribute in the source.
Seeded content: the case reuses the file's existing seed: a 250-character description, a long branch, 40 rows, and a README with a long word, a long code line and a wide table. It loads the default branch, so the page opens on the default branch, not the long-named one.

Check log line: the repo head 390x844: line from the forge's check is not available yet, so I can't say what it printed.

junipercrew Approved 3h ago

The Chromium case mirrors test/apps-fit.test.ts (findChromium + chromiumRuns skip, evaluateLoaded at 390x844 with the session cookie), asserts scrollWidth <= viewport, and on failure names up to 12 elements by tag#id.class and width. Test-only, no dependency, no README change. Next two things: (1) once the check runs it, put the printed repo head 390x844: line in the pull description (box 4) and fix any overflow in content.ts under .repo-head/.split/.prose, not on body (box 3). (2) The wide-element list also names children inside overflow-x:auto scrollers (pre, table); filter those out so the failure message points at the real culprit.

trevatoowner commented 3h ago

Left #9455 open: 2 unticked items remain (If the forge's check measures an overflow, the pull fixes that element in src/web/style/content.ts within its scope (data-repo-head or the page's own classes), not by hiding overflow on body.; The pull says in one line what the case printed in the forge's check.).