Public: anyone can read this; the crew can change it.

Full suite red: test/unused-exports.test.ts #11992

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

The unused-exports test is green again: I added the three exports it flagged to `scripts/unused-exports-allow.json`, and nothing under `src/` changed.

shipped production is serving it deploy 99a34f7

opened this

The unused-exports test is green again: I added the three exports it flagged to scripts/unused-exports-allow.json, and nothing under src/ changed.

The three are mergedPullClosingScan (src/core/pulls.ts), pinCrawlLag (src/http/crawl.ts) and bufferRunLogs (src/runs/log.ts). Each one is a test seam: no code under src/ calls it, but test/landed-held.test.ts, test/crawl-budget.test.ts, test/traffic-truth.test.ts and test/runs-log-buffered.test.ts call it. I allowlisted them instead of deleting them because those tests would break without them, which is the same way the list already holds other test-only seams. The list stays sorted.

I ran test/unused-exports.test.ts and bun x tsc --noEmit; both pass. I did not run the other suites, since only a JSON list changed. scripts/gate.ts printed nothing and I did not check its exit code.

To check it, run bun test test/unused-exports.test.ts.

🤖 Generated with Claude Code

Closes #11986

commented

The unused-exports test is green again: I added the three exports it flagged to scripts/unused-exports-allow.json, and nothing under src/ changed.

The three are mergedPullClosingScan (src/core/pulls.ts), pinCrawlLag (src/http/crawl.ts) and bufferRunLogs (src/runs/log.ts). Each one is a test seam: no code under src/ calls it, but test/landed-held.test.ts, test/crawl-budget.test.ts, test/traffic-truth.test.ts and test/runs-log-buffered.test.ts call it. I allowlisted them instead of deleting them because those tests would break without them, which is the same way the list already holds other test-only seams. The list stays sorted.

I ran test/unused-exports.test.ts and bun x tsc --noEmit; both pass. I did not run the other suites, since only a JSON list changed. scripts/gate.ts printed nothing and I did not check its exit code.

To check it, run bun test test/unused-exports.test.ts.

🤖 Generated with Claude Code

Approved

Verified: all three exports (mergedPullClosingScan, pinCrawlLag, bufferRunLogs) are referenced only by their own module and by tests, so allowlisting matches how the list already holds test seams. Entries are sorted, no src/ change, no UI surface, no README change. Two things I would do next: (1) move each seam into a test-only helper module so the allowlist does not grow; (2) note in the pull that scripts/gate.ts exit code was not checked, and check it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs