A reviewer's changes requested starts the builder's follow-up on its own, bounded to three rounds before a person is asked #1199

A crew reviewer's changes_requested now starts the builder's follow-up on its own in assisted and autonomous, with the review as the brief. With autonomy off it waits for a person. The third round hands the pull to a person.

The new tests in test/crew-loop.test.ts pass (3) and tsc --noEmit is clean. In this sandbox I could only run the tests that don't open a unix socket, so test/crew.test.ts and test/crew-direction-autonomy.test.ts were not run. test/crew-loop.test.ts does open one for the existing planner test, so that test did not run either. The new tests start the crew without the server, so they ran. test/review-gate.test.ts passed in the same combined run as the direction-autonomy file.

What changed

• Follow-up from a review: most of this path already existed in dispatch.ts (the reviewer's verdict wakes the builder). What was missing was the off rule and the bound, which I added there.
• Hand-over: on the third round, handedToPerson in src/crew/review.ts turns true. dispatch.ts then starts no further follow-up and posts one card on the pull. The card is a comment listing the three reviews, and says nothing is closed or parked.
• After hand-over: the crew sends no more reviews, waitsForPerson reports rounds, and the studio's asks list the pull as waiting for a person. A person's approval lets it land.
• Landing: an approved, green pull in autonomous mode lands as before, and now comments "Landed on green: the head is approved and its checks pass." (src/crew/autonomy.ts).
• Docs: I updated docs/PLANNING.md to match.

Behaviour change: src/core/reviews.ts used to treat the third request as advice and let the pull land. It is still advice for the merge gate, but the pull now waits for a person instead.

Not done

• REVIEW_ROUNDS stays at 2 and the gate logic in reviews.ts is unchanged. The hand-over bound, HANDOVER_ROUNDS = 3, is a separate constant in review.ts.
• I couldn't tell from the code why the follow-up didn't start in the field. In my tests the event path started it. If it still fails on the realtor apps, the breaker or the daily run cap parking the issue is the next thing to look at.

To try it: bun test test/crew-loop.test.ts -t "reviewer's changes".

🤖 Generated with Claude Code

Closes #1161

scout: juniper's review asks for changes; address it point by point and push, or say in one line why not.

I've addressed all three of juniper's points and pushed. The three review-loop tests in test/crew-loop.test.ts pass and tsc --noEmit printed nothing. The other two tests in that file, which are not review-loop tests, fail in my sandbox because the test server can't bind its socket (EPERM on listen), so I'm relying on the forge's check for those.

• Landed on green comment: I removed the block from landIfGreen in src/crew/autonomy.ts, so a landing no longer posts a comment. The final assertion in test/crew-loop.test.ts now checks mergedAt only. The existing "Landed on green without a review" comment for the lapsed-review case was already there, so I left it.
• Second handover card: In src/crew/dispatch.ts, the handover card is skipped when the last comment already starts with Handed to a person. The third-round test now sends a further verdict and asserts there is still exactly one card.
• Long line: I wrapped the addComment call in src/crew/dispatch.ts.

The rest of the change is as juniper described. A reviewer's changes-requested starts the builder when autonomy is assisted or autonomous, and with autonomy off it waits for a person. The third round posts one handover card, and a person's approval lands the pull.

scout only (reviewers: not for you): #1213 landed the core of this (the reviewer's run no longer blocks the follow-up; it is upstream as #31). Rebase this pull on main and keep only what #1213 lacks: the third-round hand-over to a person with the reviews in one card, and the inbox wording. Drop the parts #1213 already does.

This pull now adds only what #1213 lacks: the third-round hand-over to a person, with the reviews in one card, and the inbox wording for it.

I merged main into the branch instead of rebasing, because a rebase would need a force push and those are refused. The review-loop tests in test/crew-loop.test.ts pass, including the new hand-over test. The file's two other tests fail in my sandbox because the test server can't bind its socket (EPERM), so I'm relying on the forge's check for those.

• Dropped: my reviewer-verdict follow-up start, the autonomy-off return, the duplicate follow-up tests, and the PLANNING.md sentence about the follow-up. #1213 covers all of that, and I kept its autonomy === "off" early return in src/crew/dispatch.ts.
• Kept:

- src/crew/review.ts has reviewRounds, handedToPerson and handoverNote. waitsForPerson reports "rounds" and sendToReview returns "held" once a pull is handed over. - In src/crew/dispatch.ts, the third changes-requested round posts one Handed to a person card and starts no builder run. It is skipped if the last comment is already that card. - src/web/studio/asks.ts words the inbox line as "the reviewer asked for changes three times, since …". - docs/PLANNING.md now says the third request hands the pull to a person.

• Handover test: it covers three rounds on three heads, with one card, no extra run, the rounds wait, held, a re-sent verdict adding no second card, and a person's approval ending the handover. It sits inside #1213's describe block and reuses its helpers.
• Left out: the earlier version also asserted that a person's approval lands the pull. I dropped that assertion because it needs a green check run the shared setup doesn't create.