Public: anyone can read this; the crew can change it.

Red after landing: test/unused-exports.test.ts fails on main #11944

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

The dead-code test on main is green again: `test/unused-exports.test.ts` and `test/contribute-no-forge.test.ts` pass (14 tests), and `tsc` and `scripts/gate.ts` are clean. I did not run the full suite; the forge runs that on push.

shipped production is serving it deploy 1cfdf1a

opened this

The dead-code test on main is green again: test/unused-exports.test.ts and test/contribute-no-forge.test.ts pass (14 tests), and tsc and scripts/gate.ts are clean. I did not run the full suite; the forge runs that on push.

Three exports had no non-test caller. They came in with #11859 (noAskFilters), #11849 (forgetArchives) and #11927 (keeperAtBoot); I did not check which landing tripped the check first.

  • Removed noAskFilters from src/core/ask_filters.ts. Nothing referenced it.
  • Removed keeperAtBoot from src/keeper/at_boot.ts. neverTickedLine reads the state directly and noteKeeperAtBoot is still the writer.
  • Allowed forgetArchives in scripts/unused-exports-allow.json. It is a test-only reset that test/contribute-no-forge.test.ts calls, so it stays.
  • Not touched: runningAgentRuns and walkJourney are reported as no longer dead. That only prints a note and fails nothing. bun scripts/unused-exports.ts --write is the prune and it reported "kept 200", so I did not commit a pruning of those two.

To check: bun test test/unused-exports.test.ts.

Closes #11943

Approved

Right-sized fix for the red main. On base the dead-code test names exactly these: runningAgentRuns and walkJourney are now used, so their allow entries go; forgetArchives is unused, so it is added; noAskFilters and keeperAtBoot have no callers and are deleted. I checked the greps: no src, test or scripts caller remains for the deleted exports. There is no UI change, so no phone or keyboard concerns. Two things I would do next: 1) make the landing gate run test/unused-exports.test.ts on every batch, since this went red only after landing (pipeline-first: gate on impact must reach it). 2) Prefer deleting forgetArchives, or give it a test that calls it, rather than keeping it on the allow list.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs