Public: anyone can read this; the crew can change it.

Every move on /next is recorded in the audit trail with who, what and from where #11911

torquecrew opened this 36m ago

Check · Review · Land · Live — Its check is queued. Next: reviewer, no review yet.

Ready to land

Every successful move on `/next` now writes one `issue.ranked` audit event, and the activity feed shows it in `rankedWords`' text. I ran the new `test/next-audit.test.ts` (4 pass), the `next-up`, `tui-next-up` and `queue` tests, `bun x tsc --noEmit` and `bun scripts/gate.ts`; all were clean. I did not run the full suite, since `scripts/fast.ts` found the diff too broad to name tests for. The forge…

3 files · +103 −2

working queued to check deploy 40ce207

Check queued 36mCheck of 40ce207fast tier: queued · full gate runs on land

Website spec: 23 findings (report only)

/ <a href="/admin-ada0/admin/app/production/open"> has no accessible name — names
/ <a href="/bad-name-12dd/bad-name/app/production/open"> has no accessible name — names
/front <a href="/admin-ada0/admin/app/production/open"> has no accessible name — names
/front <a href="/bad-name-12dd/bad-name/app/production/open"> has no accessible name — names
/board http://127.0.0.1:40493/board answered 303 — https://specification.website/
/notes http://127.0.0.1:40493/notes answered 303 — https://specification.website/
/feed http://127.0.0.1:40493/feed answered 303 — https://specification.website/
/review http://127.0.0.1:40493/review answered 303 — https://specification.website/
/releases http://127.0.0.1:40493/releases answered 303 — https://specification.website/
/repos http://127.0.0.1:40493/repos answered 303 — https://specification.website/
/map http://127.0.0.1:40493/map answered 303 — https://specification.website/
/system http://127.0.0.1:40493/system answered 303 — https://specification.website/
/talk http://127.0.0.1:40493/talk answered 303 — https://specification.website/
/flow http://127.0.0.1:40493/flow answered 303 — https://specification.website/
/resilience http://127.0.0.1:40493/resilience answered 303 — https://specification.website/
/boards?help http://127.0.0.1:40493/boards?help answered 303 — https://specification.website/
/settings/crew http://127.0.0.1:40493/settings/crew answered 303 — https://specification.website/
/settings/crew?help http://127.0.0.1:40493/settings/crew?help answered 303 — https://specification.website/
/preview-admin/sample expected exactly one <h1>, found 2 — headings
/preview-admin/sample/next expected exactly one <h1>, found 2 — headings
/preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
/preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
/preview-admin/sample/milestones expected exactly one <h1>, found 2 — headings

torquecrew opened this 36m ago

Every successful move on /next now writes one issue.ranked audit event, and the activity feed shows it in rankedWords' text. I ran the new test/next-audit.test.ts (4 pass), the next-up, tui-next-up and queue tests, bun x tsc --noEmit and bun scripts/gate.ts; all were clean. I did not run the full suite, since scripts/fast.ts found the diff too broad to name tests for. The forge's check runs it on the push.

What the entry carries: the actor, the issue number, the place (top, not_now, or after plus the row's number) and from. from is where the issue stood in the /next list before the move, 1 at the top, or 0 if it wasn't listed. Nothing else goes in.
Refused moves: a forbidden, missing or invalid move still writes no entry.
Where it shows: the entry is read through eventVerb in src/design/activity.ts, which reads like "ranked an issue: #N is on top." / "#N moved under #M." / "#N is not now."
Tests: they cover each place, the exact payload, the wording, and that forbidden, missing-issue, bad-place and already-not-now moves write nothing.
Left alone: issue.ranked was already emitted with {number, to}. I extended that event rather than adding a second one. I did not add a separate page for these entries.

To try it, move an issue to Top on /next, then look for the "ranked an issue" line in the activity feed.

Closes #11754