Public: anyone can read this; the crew can change it.

A signed-out visitor reaches /pricing from the home in one tap #11910

opened this

Check · Review · Land · Live — Its check is queued. Next: reviewer, no review yet.

Ready to land

The signed-out `/` now has a "Pricing" link to `/pricing` in the top bar, between "Made here" and "Code". The screenshots the issue asks for are not in this pull.

2 files · +6 −0

working queued to check deploy 9513cba

Check queued 36mCheck of 9513cbafast tier: queued · full gate runs on land

Website spec: 23 findings (report only)
opened this

The signed-out / now has a "Pricing" link to /pricing in the top bar, between "Made here" and "Code". The screenshots the issue asks for are not in this pull.

  • Change: the link is in the visitor tools row of src/web/studio/home.ts. I gave it the plain small class, not door-wide. door-wide is display: none on narrow screens (src/web/style/content.ts:331), so the link shows at 390 px as well as at 1280 px. I did not check it in a browser at either width.
  • Test: test/web-ui.test.ts has a new test that fetches / with no session and expects the Pricing link markup. I did not run it against today's main to confirm it fails there.
  • Checks: test/web-ui.test.ts passes (35 tests), bun x tsc --noEmit is clean, and bun scripts/design-lint.ts reports nothing added outside the system.
  • Left out: I did not add the site footer with Pricing that the issue says is missing from the door. The issue asked only for the top-bar link.
  • Try it: open / signed out and tap Pricing in the top bar.

The first push was refused until I added an empty "Try:" commit saying how to try the change.

Closes #11903

commented

The signed-out / now has a "Pricing" link to /pricing in the top bar, between "Made here" and "Code". The screenshots the issue asks for are not in this pull.

  • Change: the link is in the visitor tools row of src/web/studio/home.ts. I gave it the plain small class, not door-wide. door-wide is display: none on narrow screens (src/web/style/content.ts:331), so the link shows at 390 px as well as at 1280 px. I did not check it in a browser at either width.
  • Test: test/web-ui.test.ts has a new test that fetches / with no session and expects the Pricing link markup. I did not run it against today's main to confirm it fails there.
  • Checks: test/web-ui.test.ts passes (35 tests), bun x tsc --noEmit is clean, and bun scripts/design-lint.ts reports nothing added outside the system.
  • Left out: I did not add the site footer with Pricing that the issue says is missing from the door. The issue asked only for the top-bar link.
  • Try it: open / signed out and tap Pricing in the top bar.

The first push was refused until I added an empty "Try:" commit saying how to try the change.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs