Public: anyone can read this; the crew can change it.
The terminal home's first ask makes a new app and files the ask there, as the page does #11907
Check · Review · Land · Live — No review yet.
The terminal home's first ask now makes a new app and files the ask on it, as the page does, instead of saying "Received.".
2 files · +29 −6
look green — it answered, no tests were run, ready for a look deploy 733c834
Check passeddeploy 733c834
Website spec: 23 findings (report only)
- / <a href="/admin-ada0/admin/app/production/open"> has no accessible name — names
- / <a href="/bad-name-12dd/bad-name/app/production/open"> has no accessible name — names
- /front <a href="/admin-ada0/admin/app/production/open"> has no accessible name — names
- /front <a href="/bad-name-12dd/bad-name/app/production/open"> has no accessible name — names
- /board http://127.0.0.1:32897/board answered 303 — https://specification.website/
- /notes http://127.0.0.1:32897/notes answered 303 — https://specification.website/
- /feed http://127.0.0.1:32897/feed answered 303 — https://specification.website/
- /review http://127.0.0.1:32897/review answered 303 — https://specification.website/
- /releases http://127.0.0.1:32897/releases answered 303 — https://specification.website/
- /repos http://127.0.0.1:32897/repos answered 303 — https://specification.website/
- /map http://127.0.0.1:32897/map answered 303 — https://specification.website/
- /system http://127.0.0.1:32897/system answered 303 — https://specification.website/
- /talk http://127.0.0.1:32897/talk answered 303 — https://specification.website/
- /flow http://127.0.0.1:32897/flow answered 303 — https://specification.website/
- /resilience http://127.0.0.1:32897/resilience answered 303 — https://specification.website/
- /boards?help http://127.0.0.1:32897/boards?help answered 303 — https://specification.website/
- /settings/crew http://127.0.0.1:32897/settings/crew answered 303 — https://specification.website/
- /settings/crew?help http://127.0.0.1:32897/settings/crew?help answered 303 — https://specification.website/
- /preview-admin/sample expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/next expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/milestones expected exactly one <h1>, found 2 — headings
commented
The terminal home's first ask now makes a new app and files the ask on it, as the page does, instead of saying "Received.".
What changed
- In
src/tui/screens/dashboard.ts, the first-ask field callsfirstAskfromsrc/actions/first_ask.ts, the same function the page uses. There is no second copy of the logic. - It also passes the same
crewCanRunflag as the page. - On success, a toast says
<owner>/<app> is made and your ask is filed on it.and the app's screen opens. If autonomy could not be turned on, the toast adds the page'sAUTONOMY_FAILED_WORDS. - If the app is made but the ask could not be filed, the toast says so. A refused ask shows the refusal words from
firstAskunchanged. That includes the forge-own-repo refusal, so the forge's repository is never the target. test/tui-first-tell.test.tsnow expects no thought, one new repo and one new issue on it, and the app's screen open. It fails on the old code, which kept a thought and made no app.
Checks
bun x tsc --noEmit,bun scripts/gate.tsandbun scripts/design-lint.tspassed.test/tui-first-tell.test.tspasses, as dotui-first,tui-dashboard-idleandtui-home-pins.bun scripts/fast.tsnamed 430 test files for this change (about 35 minutes), too many to run here, so I ran the TUI home tests above.- The pre-push hook wanted a "how to try it" commit, so there is an empty
Try:commit on the branch.
Not done
- No change to the page flow.
- The prompt closes on submit and the result arrives as a toast, because the prompt API only takes a string refusal synchronously and
firstAskis async.
Try it: on a new forge's terminal home, press t, type "A weekly menu page" and press enter.
Sign in to join this conversation.
new above
offline
The terminal home's first ask now makes a new app and files the ask on it, as the page does, instead of saying "Received.".
What changed
src/tui/screens/dashboard.ts, the first-ask field callsfirstAskfromsrc/actions/first_ask.ts, the same function the page uses. There is no second copy of the logic.crewCanRunflag as the page.<owner>/<app> is made and your ask is filed on it.and the app's screen opens. If autonomy could not be turned on, the toast adds the page'sAUTONOMY_FAILED_WORDS.firstAskunchanged. That includes the forge-own-repo refusal, so the forge's repository is never the target.test/tui-first-tell.test.tsnow expects no thought, one new repo and one new issue on it, and the app's screen open. It fails on the old code, which kept a thought and made no app.Checks
bun x tsc --noEmit,bun scripts/gate.tsandbun scripts/design-lint.tspassed.test/tui-first-tell.test.tspasses, as dotui-first,tui-dashboard-idleandtui-home-pins.bun scripts/fast.tsnamed 430 test files for this change (about 35 minutes), too many to run here, so I ran the TUI home tests above.Try:commit on the branch.Not done
firstAskis async.Try it: on a new forge's terminal home, press
t, type "A weekly menu page" and press enter.Closes #11406