Public: anyone can read this; the crew can change it.

The terminal home's first ask makes a new app and files the ask there, as the page does #11907

opened this

Check · Review · Land · Live — No review yet. Next: reviewer, no review yet.

Ready to land

The terminal home's first ask now makes a new app and files the ask on it, as the page does, instead of saying "Received.".

2 files · +29 −6

look green — it answered, no tests were run, ready for a look deploy 733c834

Check passeddeploy 733c834

Website spec: 23 findings (report only)
opened this

The terminal home's first ask now makes a new app and files the ask on it, as the page does, instead of saying "Received.".

What changed

  • In src/tui/screens/dashboard.ts, the first-ask field calls firstAsk from src/actions/first_ask.ts, the same function the page uses. There is no second copy of the logic.
  • It also passes the same crewCanRun flag as the page.
  • On success, a toast says <owner>/<app> is made and your ask is filed on it. and the app's screen opens. If autonomy could not be turned on, the toast adds the page's AUTONOMY_FAILED_WORDS.
  • If the app is made but the ask could not be filed, the toast says so. A refused ask shows the refusal words from firstAsk unchanged. That includes the forge-own-repo refusal, so the forge's repository is never the target.
  • test/tui-first-tell.test.ts now expects no thought, one new repo and one new issue on it, and the app's screen open. It fails on the old code, which kept a thought and made no app.

Checks

  • bun x tsc --noEmit, bun scripts/gate.ts and bun scripts/design-lint.ts passed.
  • test/tui-first-tell.test.ts passes, as do tui-first, tui-dashboard-idle and tui-home-pins.
  • bun scripts/fast.ts named 430 test files for this change (about 35 minutes), too many to run here, so I ran the TUI home tests above.
  • The pre-push hook wanted a "how to try it" commit, so there is an empty Try: commit on the branch.

Not done

  • No change to the page flow.
  • The prompt closes on submit and the result arrives as a toast, because the prompt API only takes a string refusal synchronously and firstAsk is async.

Try it: on a new forge's terminal home, press t, type "A weekly menu page" and press enter.

Closes #11406

commented

The terminal home's first ask now makes a new app and files the ask on it, as the page does, instead of saying "Received.".

What changed

  • In src/tui/screens/dashboard.ts, the first-ask field calls firstAsk from src/actions/first_ask.ts, the same function the page uses. There is no second copy of the logic.
  • It also passes the same crewCanRun flag as the page.
  • On success, a toast says <owner>/<app> is made and your ask is filed on it. and the app's screen opens. If autonomy could not be turned on, the toast adds the page's AUTONOMY_FAILED_WORDS.
  • If the app is made but the ask could not be filed, the toast says so. A refused ask shows the refusal words from firstAsk unchanged. That includes the forge-own-repo refusal, so the forge's repository is never the target.
  • test/tui-first-tell.test.ts now expects no thought, one new repo and one new issue on it, and the app's screen open. It fails on the old code, which kept a thought and made no app.

Checks

  • bun x tsc --noEmit, bun scripts/gate.ts and bun scripts/design-lint.ts passed.
  • test/tui-first-tell.test.ts passes, as do tui-first, tui-dashboard-idle and tui-home-pins.
  • bun scripts/fast.ts named 430 test files for this change (about 35 minutes), too many to run here, so I ran the TUI home tests above.
  • The pre-push hook wanted a "how to try it" commit, so there is an empty Try: commit on the branch.

Not done

  • No change to the page flow.
  • The prompt closes on submit and the result arrives as a toast, because the prompt API only takes a string refusal synchronously and firstAsk is async.

Try it: on a new forge's terminal home, press t, type "A weekly menu page" and press enter.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs