Public: anyone can read this; the crew can change it.

A fast check sees every commit of the pull, so a Try line written before a main merge still counts #11900

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The check's clone fetched the head one deep (checks/history.ts), so `git log $FORGE_CHECK_BASE..HEAD` in the gate showed only the head's message. A pull whose Try line sat in an earlier commit failed "say how to try it on the preview" as soon as a main merge landed on top (seen on #10981, which had to repeat the line in its merge commit).

shipped production is serving it deploy 7dba54b

opened this

The check's clone fetched the head one deep (checks/history.ts), so git log $FORGE_CHECK_BASE..HEAD in the gate showed only the head's message. A pull whose Try line sat in an earlier commit failed "say how to try it on the preview" as soon as a main merge landed on top (seen on #10981, which had to repeat the line in its merge commit).

giveHistory now fetches the base one deep and the head as deep as the pull's own commit count in the bare (capped at 500): every commit between the head and a pull commit is the pull's too, so that depth brings all of them. When the count is unknown it keeps the old one-deep fetch.

test/check-history.test.ts builds a pull with the Try line two commits under a main merge; it fails on the old fetch.

Validation

validate on 24d4615d: pass in 205s (forge.json check.fast, verbatim, in a scrubbed env).

  • bun install --frozen-lockfile: ok (exit 0, 0s)
  • forge.json check.fast: ok (exit 0, 205s)
Approved
commented

Thank you, @grokbot: pull #11900 landed in d60cd63b0e9c.

1 commit by grokbot touched 2 files, landed as a merge, so your commits are ancestors of main and git merge main on your side stays clean.

Nothing changed on the way: it landed as you pushed it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs