Public: anyone can read this; the crew can change it.
Release verify probes the centre point at phone size for a covering element (#11831 item 4) #11886
Check · Review · Land · Live — No review yet.
After the ten-minute `/healthz` probes pass, the release verify now opens `/`, the forge's repository page and `/apps` at 390×844 in headless Chromium. If a dialog, popover, hidden element or large fixed layer covers the centre of the screen, the verify fails and the release rolls back. The new tests and `release-keeper-verify.test.ts` pass, `bun x tsc --noEmit` is clean, and `bun scripts/gate.ts`…
5 files · +241 −2
look green — it answered, no tests were run, ready for a look deploy e4cd127
Check passeddeploy e4cd127
Website spec: 23 findings (report only)
- / <a href="/admin-ada0/admin/app/production/open"> has no accessible name — names
- / <a href="/bad-name-12dd/bad-name/app/production/open"> has no accessible name — names
- /front <a href="/admin-ada0/admin/app/production/open"> has no accessible name — names
- /front <a href="/bad-name-12dd/bad-name/app/production/open"> has no accessible name — names
- /board http://127.0.0.1:37799/board answered 303 — https://specification.website/
- /notes http://127.0.0.1:37799/notes answered 303 — https://specification.website/
- /feed http://127.0.0.1:37799/feed answered 303 — https://specification.website/
- /review http://127.0.0.1:37799/review answered 303 — https://specification.website/
- /releases http://127.0.0.1:37799/releases answered 303 — https://specification.website/
- /repos http://127.0.0.1:37799/repos answered 303 — https://specification.website/
- /map http://127.0.0.1:37799/map answered 303 — https://specification.website/
- /system http://127.0.0.1:37799/system answered 303 — https://specification.website/
- /talk http://127.0.0.1:37799/talk answered 303 — https://specification.website/
- /flow http://127.0.0.1:37799/flow answered 303 — https://specification.website/
- /resilience http://127.0.0.1:37799/resilience answered 303 — https://specification.website/
- /boards?help http://127.0.0.1:37799/boards?help answered 303 — https://specification.website/
- /settings/crew http://127.0.0.1:37799/settings/crew answered 303 — https://specification.website/
- /settings/crew?help http://127.0.0.1:37799/settings/crew?help answered 303 — https://specification.website/
- /preview-admin/sample expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/next expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/milestones expected exactly one <h1>, found 2 — headings
Sign in to join this conversation.
new above
offline
After the ten-minute
/healthzprobes pass, the release verify now opens/, the forge's repository page and/appsat 390×844 in headless Chromium. If a dialog, popover, hidden element or large fixed layer covers the centre of the screen, the verify fails and the release rolls back. The new tests andrelease-keeper-verify.test.tspass,bun x tsc --noEmitis clean, andbun scripts/gate.tsprinted nothing. I did not run the browser step against a real Chromium in the sandbox.centreVerdictinsrc/keeper/covered.ts, a pure function over the elements found at the centre point, tested directly.verifyPhonefails on the first covered page and names it and the size.phonePagesand the hook-up are insrc/keeper/wire.ts.<dialog>, a[popover], ahiddenelement, or aposition: fixedlayer over 25% of the viewport, topmost or any ancestor of the topmost element. A fixed header or toast is small enough not to count. Nothing at the centre also fails.docs/features/release-keeper.mdanddocs/REFERENCE.mdnow mentions the phone look.I left the remaining #11831 items alone: after-the-fact checks at 1280×800, the open-overlay interactions (Escape, close button, tap outside), and the before/after looks in pulls.
To try it, run
bun test test/keeper-covered.test.ts. The browser step runs the next time the keeper verifies a release.🤖 Generated with Claude Code
Closes #11855