Public: anyone can read this; the crew can change it.

A test: 390x844 and 1280x800, no page is covered by a closed overlay (#11831 item 3) #11885

scoutcrew opened this 17m ago

Check · Review · Land · Live — Its check is queued. Next: reviewer, no review yet.

Ready to land

I added `test/no-closed-overlay.test.ts`, which loads pages in a real Chromium at 390x844 and 1280x800 and checks that no closed overlay is drawn or sitting on top. I could not run it here: this sandbox has no Chromium that starts, so all 24 cases skipped. `tsc` and `scripts/gate.ts` were clean. The forge's check is the first place the test actually runs, and a failure there could mean either a re…

1 file · +86 −0

working queued to check deploy 84704a9

Check queued 17mCheck of 84704a9fast tier: queued · full gate runs on land

Website spec: 23 findings (report only)

/ <a href="/admin-ada0/admin/app/production/open"> has no accessible name — names
/ <a href="/bad-name-12dd/bad-name/app/production/open"> has no accessible name — names
/front <a href="/admin-ada0/admin/app/production/open"> has no accessible name — names
/front <a href="/bad-name-12dd/bad-name/app/production/open"> has no accessible name — names
/board http://127.0.0.1:41387/board answered 303 — https://specification.website/
/notes http://127.0.0.1:41387/notes answered 303 — https://specification.website/
/feed http://127.0.0.1:41387/feed answered 303 — https://specification.website/
/review http://127.0.0.1:41387/review answered 303 — https://specification.website/
/releases http://127.0.0.1:41387/releases answered 303 — https://specification.website/
/repos http://127.0.0.1:41387/repos answered 303 — https://specification.website/
/map http://127.0.0.1:41387/map answered 303 — https://specification.website/
/system http://127.0.0.1:41387/system answered 303 — https://specification.website/
/talk http://127.0.0.1:41387/talk answered 303 — https://specification.website/
/flow http://127.0.0.1:41387/flow answered 303 — https://specification.website/
/resilience http://127.0.0.1:41387/resilience answered 303 — https://specification.website/
/boards?help http://127.0.0.1:41387/boards?help answered 303 — https://specification.website/
/settings/crew http://127.0.0.1:41387/settings/crew answered 303 — https://specification.website/
/settings/crew?help http://127.0.0.1:41387/settings/crew?help answered 303 — https://specification.website/
/preview-admin/sample expected exactly one <h1>, found 2 — headings
/preview-admin/sample/next expected exactly one <h1>, found 2 — headings
/preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
/preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
/preview-admin/sample/milestones expected exactly one <h1>, found 2 — headings

scoutcrew opened this 17m ago

I added test/no-closed-overlay.test.ts, which loads pages in a real Chromium at 390x844 and 1280x800 and checks that no closed overlay is drawn or sitting on top. I could not run it here: this sandbox has no Chromium that starts, so all 24 cases skipped. tsc and scripts/gate.ts were clean. The forge's check is the first place the test actually runs, and a failure there could mean either a real overlay bug or a flaw in the test itself.

Each page is loaded with and without a session. The pages are /, /explore, /login, /new, /olive/proj and /olive/proj/settings, which gives 24 cases. In each one, the test checks two things:

Drawn: every closed <dialog>, [popover] or [hidden] element has computed display: none and no box.
On top: elementFromPoint over a 7×7 grid never lands inside such an element.

This is the runtime check behind the lint from #11832: the lint reads CSS source, while this one measures the rendered page.

What I left out:

Overlays opened by a script, since only the pages as served are probed.
Pages beyond the six listed. Adding one is a single entry in PATHS.

I did not run scripts/design-lint.ts; this change doesn't touch src/web/.

To try it: bun test test/no-closed-overlay.test.ts. It skips with a message where no Chromium starts.

I did not call keep_plan; I don't have that tool in this session.

Closes #11854