Public: anyone can read this; the crew can change it.
Red after landing: bda02bc broke test/flow-handover-page.test.ts #11747
I couldn't reproduce the failure, and bda02bc can't have caused it. That commit only changes src/apps/contain.ts (the CPU watcher's stop threshold), which test/flow-handover-page.test.ts doesn't import. The test passes here, 7 of 7, on repeated runs.
stopped closed without shipping deploy 8ccd29d
2 earlier comments
I couldn't reproduce the failure, and bda02bc can't have caused it. That commit only changes src/apps/contain.ts (the CPU watcher's stop threshold), which test/flow-handover-page.test.ts doesn't import. The test passes here, 7 of 7, on repeated runs. tsc --noEmit is clean.
The likely cause is the test timing out on a loaded check. "The three lists, on the page and on /flow" signs in, which hashes a password, and then renders /flow. On a loaded 1-CPU check that can exceed Bun's default 5 s timeout. I can't confirm this, because I never saw the failing log.
What changed: that test now has a 30 s timeout, with a comment saying why. Nothing else changed.
What I chose not to do: I did not revert bda02bc, since it isn't implicated. I did not touch /flow or the handover code.
How to check: bun test test/flow-handover-page.test.ts. If the forge's check still fails this test with the timeout raised, the cause is something else. The failure log would then be needed.
I merged main into the branch and pushed. The one conflict was in test/flow-handover-page.test.ts.
main had already landed the same fix: a 30 s timeout on the "three lists" test, with a different comment. I took main's version, so the branch now has no diff against main. This pull no longer changes anything beyond what main already has.
test/flow-handover-page.test.ts passes (7 of 7) and tsc --noEmit is clean. I did not run the full suite; the forge's check does that on the push.
Closed by the crew: superseded, its change is already on main in c3e100f9.
I couldn't reproduce the failure, and bda02bc can't have caused it. That commit only changes
src/apps/contain.ts(the CPU watcher's stop threshold), whichtest/flow-handover-page.test.tsdoesn't import. The test passes here, 7 of 7, on repeated runs.tsc --noEmitis clean.The likely cause is the test timing out on a loaded check. "The three lists, on the page and on /flow" signs in, which hashes a password, and then renders
/flow. On a loaded 1-CPU check that can exceed Bun's default 5 s timeout. I can't confirm this, because I never saw the failing log.What changed: that test now has a 30 s timeout, with a comment saying why. Nothing else changed.
What I chose not to do: I did not revert bda02bc, since it isn't implicated. I did not touch
/flowor the handover code.How to check:
bun test test/flow-handover-page.test.ts. If the forge's check still fails this test with the timeout raised, the cause is something else. The failure log would then be needed.Closes #11728