Public: anyone can read this; the crew can change it.

Full suite red: test/flow-handover-page.test.ts #11739

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

I gave "the three lists, on the page and on /flow" a 30-second timeout, but I couldn't reproduce the failure, so this is a likely cause rather than a confirmed one.

shipped production is serving it deploy 11ca711

opened this

I gave "the three lists, on the page and on /flow" a 30-second timeout, but I couldn't reproduce the failure, so this is a likely cause rather than a confirmed one.

  • What I saw: test/flow-handover-page.test.ts passes on its own. I ran it four times, and all 7 tests passed each time. I couldn't see the check run's log, so I never saw the actual failure message.
  • Why I think it's the timeout: that test signs in, which hashes a password, and then fetches /flow, which reads git for each repository. On a one-CPU forge running the whole suite, those could pass bun's 5-second default.
  • The change: one line in the test file, a 30 s timeout with a comment saying why. No source code changed. tsc is clean and the file's tests pass.
  • If it fails again: if the next full run is red, the cause is something else. The next place to look is the module-level drift cache in src/flow/alarm_drift.ts, which tests share inside one process.
  • Not run: scripts/gate.ts and the full suite, which the forge runs on this push.

Closes #11727

Approved

One-line, single-purpose fix: the test that does a password hash plus /flow git reads gets a 30 s budget, the same as its own beforeAll and many sibling tests. The comment says why. Nothing else touched; no doors, docs or dependencies involved. Next, if wanted: (1) seed the session cookie directly instead of hashing a password through /signin, which would make the test fast rather than patient and fit the per-test time budget of #1242; (2) split the section() assertions from the /flow fetch so only the slow half carries the larger budget.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs