Public: anyone can read this; the crew can change it.
test/sealed-release.test.ts: "the way out: its fix released" is green on a loaded runner and rejoins the gate #1166
Check · Review · Land · Live done — Landed and live in production.
This pull only partly does what #1046 asks. I couldn't run `test/sealed-release.test.ts` here, so I haven't confirmed that the cause I found is the one that turned the gate red.
shipped production is serving it deploy 5f89d5b
Sign in to join this conversation.
new above
offline
This pull only partly does what #1046 asks. I couldn't run
test/sealed-release.test.tshere, so I haven't confirmed that the cause I found is the one that turned the gate red.Why not run: the sandbox refuses
listenon a unix socket (EPERM).serve()insrc/http/server.tsneeds that socket, andbeforeAllcallsserve(), so the file fails before any case runs. The test files that run in the gate (bun testandbun scripts/test-shards.ts --gate) were not run for the same reason.test/check-list.test.tspasses (8 pass, 0 fail).Cause (inferred, not reproduced): the "a tag that does not contain the fix opens nothing" case asserts nothing racy.
unsealReleasedis awaited directly.What it does do is
reportAndFix, which runs a branch commit, opens a pull and merges it, all through real git processes. That is the case's whole cost, and it ran under bun's default 5 s per-case limit. On a loaded gate runner the limit cuts the case off. The same applies to the other three cases that callreportAndFix.What changed: the four cases that call
reportAndFixnow get a 30 s limit (GIT_WORK_MS), the same asbeforeAll. A comment in the file says why. This is a widened timeout, which the issue says is not enough on its own. I found no event for the case to wait on. If the gate still goes red on that case, the log will show whether it was a timeout or an assertion, and the cause is somewhere else.Gate move: nothing to do.
test/sealed-release.test.tsis already inGATEinscripts/gate.ts, and it isn't inEXCLUDEDon this branch.Still open: the three consecutive runs of
bun test test/sealed-release.test.tsare not done. Please run them on a runner that can open the socket, or let this pull's check do it.Closes #1046