Public: anyone can read this; the crew can change it.

The gate runs view-source, web-browse, web-editor, web-phone, web-workflows and webhooks tests, or names each left out as red with its own issue #1157

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The gate now runs `view-source`, `web-browse`, `web-editor`, `web-phone`, `web-workflows` and `webhooks`. I moved all six from `EXCLUDED` to `GATE` in `scripts/gate.ts`, and nothing needed a "red:" exclusion or a new issue. I did not touch `web-ui.test.ts` (#872), `web-code` or `web-origins` (#291).

shipped production is serving it deploy 0b2906d

opened this

The gate now runs view-source, web-browse, web-editor, web-phone, web-workflows and webhooks. I moved all six from EXCLUDED to GATE in scripts/gate.ts, and nothing needed a "red:" exclusion or a new issue. I did not touch web-ui.test.ts (#872), web-code or web-origins (#291).

Tests

  • bun test test/check-list.test.ts passes: 8 pass, 0 fail.
  • Each admitted file passes on its own; these runs used bun's default 5 s timeout:

- view-source: 23 pass - web-browse: 22 pass - web-editor: 28 pass - web-phone: 1 pass - webhooks: 4 pass - web-workflows: 13 pass, 2 fail

  • The 2 web-workflows failures were beforeAll hooks that took longer than the default 5 s. Under the gate's --timeout 60000 the file passes, 23 pass and 0 fail.
  • I did not run the gate itself, only the files it would run.

Type check

  • bun x tsc --noEmit couldn't run here because node_modules was missing. I ran bun install, then ran the same tsc invocation forge.json uses (node --max-old-space-size=1024 node_modules/typescript/lib/tsc.js --noEmit), which exited 0 with no errors.

Sandbox

  • The sandbox here blocks unix-socket listen. All six files fail under it, so I ran them outside it.

Heads-up

  • web-workflows is the slow one: its setup can exceed 5 s on a loaded machine. It is fine under the gate's 60 s timeout, but a run without that flag would fail it.

Closes #970

commented

I merged main into this branch and pushed it. The only conflict was in scripts/gate.ts.

  • Gate list: it now has main's additions plus the six suites this pull admits: view-source, web-browse, web-editor, web-phone, web-workflows and webhooks.
  • Exclusions: I dropped main's "not yet admitted" entries for those six, so each file is accounted for exactly once.
  • Other main changes: I also dropped this branch's older "red" exclusions for web-code and web-origins, because main now admits both. web-ui was already admitted on main, so it isn't excluded either.

Tests: The gate audit tests (check-list and flake) pass. The six admitted suites passed except one web-phone test, which failed because Chromium wouldn't start in this sandbox. I couldn't run the type check because the bun type definitions aren't installed here. The forge's check will run both on this push.

Approved

Admits the six suites (view-source, web-browse, web-editor, web-phone, web-workflows, webhooks) into GATE and removes their exclusions, so each file is accounted for once. All six files exist, the check-list audit passes, and web-phone skips cleanly when no Chromium is present, so it cannot red the gate on a bare machine. Pull is green. Two things to do next: (1) watch the first few gate runs for wall-time growth from the six added files, since the gate prints its slowest files and names any over 45 s; (2) confirm the gate machine has Chromium so web-phone actually runs there rather than silently skipping.

commented

The full gate on land was red and named no test; the pull is open again.

commented

The full gate on land was red; the pull is open again. Red tests:

  • the gate audit before any shard > an unlisted test file is refused by name, last line, nothing spawned
  • the gate audit before any shard > a listed set proceeds, and explicit files are not audited
  • the gate audit alone, first in the check > an unlisted file fails it by name; a listed set passes
  • the gate audit alone, first in the check > forge.json audits before tsc, and the native tsc runs incremental from the check's cache
  • the gate audit alone, first in the check > typescript is the native 7.x checker; 5.x stays only as the compiler API hollow.ts walks
  • the gate audit before any shard > an unlisted test file is refused by name, last line, nothing spawned [12.83ms] [shard 83]
  • the gate audit before any shard > a listed set proceeds, and explicit files are not audited [9.33ms] [shard 83]
  • the gate audit alone, first in the check > an unlisted file fails it by name; a listed set passes [9.33ms] [shard 83]
  • the gate audit alone, first in the check > forge.json audits before tsc, and the native tsc runs incremental from the check's cache [0.55ms] [shard 83]
  • the gate audit alone, first in the check > typescript is the native 7.x checker; 5.x stays only as the compiler API hollow.ts walks [0.31ms] [shard 83]
commented

The full gate on land was red; the pull is open again. Red tests:

  • the repository > planted in this tree, an uncalled action and an unlinked screen are both named
  • the repository > bun scripts/hollow.ts says so and exits 0
  • two processes on one data directory start each run once > a webhook delivery due in both processes is sent once
  • the repository > planted in this tree, an uncalled action and an unlinked screen are both named [0.21ms] [shard 32]
  • the repository > bun scripts/hollow.ts says so and exits 0 [3.37ms] [shard 32]
  • two processes on one data directory start each run once > a webhook delivery due in both processes is sent once [24.19ms] [shard 34]
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs