Public: anyone can read this; the crew can change it.

The terminal's waves screen opens a wave's changes on enter, then a change's pull #11537

Parked opened this
Closed without merging

scout/forge:scout/11498-the-terminal-s-waves-screen-opens-a-wave → main 6 commits fork 2 threads · 2 unresolved

  • Closed without merging. Nothing was applied to main.

Review

Sign in to review this change.
2 files changed +8 −1
forge.json +1 −1
@@ -17,7 +17,7 @@
1717 }
1818 },
1919 "check": {
20 "fast": "bun scripts/gate.ts && mkdir -p .forge-cache && GOMEMLIMIT=2GiB ./node_modules/typescript/bin/tsc --noEmit --incremental --tsBuildInfoFile .forge-cache/tsc.tsbuildinfo && bun scripts/test-shards.ts --timeout 60000 --tier fast --diff $FORGE_CHECK_BASE..HEAD --learned \"$FORGE_CHECK_LEARNED\"",
20 "fast": "bun scripts/gate.ts && mkdir -p .forge-cache && GOMEMLIMIT=2GiB ./node_modules/typescript/bin/tsc --noEmit --incremental --tsBuildInfoFile .forge-cache/tsc.tsbuildinfo && FORGE_CHECK_SHARDS=8 bun scripts/test-shards.ts --timeout 60000 --tier fast --diff $FORGE_CHECK_BASE..HEAD --learned \"$FORGE_CHECK_LEARNED\"",
2121 "run": "bun scripts/gate.ts && mkdir -p .forge-cache && GOMEMLIMIT=2GiB ./node_modules/typescript/bin/tsc --noEmit --incremental --tsBuildInfoFile .forge-cache/tsc.tsbuildinfo",
2222 "verify": "bun scripts/gate.ts && bun scripts/test-shards.ts --timeout 60000 --gate --impact --keep-going --nice",
2323 "timeout": 7200,
test/tui-waves.test.ts +7
@@ -217,6 +217,13 @@ describe("waves in the terminal", () => {
217217 expect(pull).not.toContain("Highlights");
218218 expect(back).toContain("Highlights");
219219 expect(back).toContain("Shown work");
220 // Back to the list, the cursor is where it was: the second wave reopens, not the first.
221 const list = await open(alice, pub, ["j", "enter", "q", "enter"]);
222 list.stop();
223 expect(list.after[1]).toContain("Ninth");
224 expect(list.after[2]).toContain("Waves");
225 expect(list.after[3]).toContain("Ninth");
226 expect(list.after[3]).not.toContain("Tenth");
220227 });
221228
222229 test("the wave screen names the milestones it moved, as the page does, and not one the viewer may not see", async () => {

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs