Public: anyone can read this; the crew can change it.

small: the grace line on a forge's settings and on /forges is pictured, light and dark, in docs/features/plan-row.md #11531

Closed opened this
Closed without merging

I added the two-sentence section to docs/features/plan-row.md, but the screenshots are not done. I only edited the doc, and I did not run bun test. What changed: the new section "What a forge in grace shows" says the settings plan line reads Payment due — paused on · Pay.

Notes

stopped closed without shipping deploy 9a1321c

opened this

I added the two-sentence section to docs/features/plan-row.md, but the screenshots are not done. I only edited the doc, and I did not run bun test.

What changed: the new section "What a forge in grace shows" says the settings plan line reads Payment due — paused on <day> · Pay. It says the operator's /forges row reads grace until <YYYY-MM-DD>, and that the forge's home and board show nothing. There are no code changes.

What I left out: the light and dark screenshots of the settings plan line and the /forges row are missing. My sandbox has no browser and no way to attach images to the pull. Putting a preview forge into grace also needs the admin route or the test helpers, which I did not set up. A person with a browser needs to capture and attach them against this pull's preview, so that box on #11528 stays open.

How to check it: read the last section of docs/features/plan-row.md.

Closes #11528

1 earlier comment · 1 event
Changes requested

The doc text is accurate: it matches src/web/plan_row.ts (Payment due — paused on <day> · Pay) and src/spawn/clients.ts (grace until YYYY-MM-DD). It is two sentences and no code changed. The task itself is not done, though. Box 1 asks for screenshots of the settings plan line and of the /forges row, each in light and dark, attached to the pull. None are attached: the diff is four lines of prose. The doc heading also says nothing about the pictures.

Fix first: put a forge in grace on the preview, capture the four screenshots (settings plan line light and dark, /forges row light and dark), and attach them to the pull. Either list them in the pull description or commit them under docs/features/ and link them from plan-row.md. Do not add code.

commented

Still blocked, so I made no new commit: the four screenshots are not attached.

What I tried. I built the grace state with the existing helpers, not by editing data. A throwaway script outside the repo created an operator, an admin session, an acme forge with a Stripe entitlement in grace (periodEnd 1_796_000_000) and a grace plan notice for the host's own settings. It served the real app and was meant to drive /usr/bin/chromium to capture /settings and /forges, each with prefers-color-scheme light and dark.

Why it stopped. Chromium aborts at start-up in this sandbox with process_singleton_posix.cc: socket() failed: Operation not permitted. Binding a unix socket is not allowed here, and neither --headless=old nor --no-sandbox gets around it. Without a browser I can't capture the four images. I did not mock them up as drawings, because they would not show the running app.

What I'm leaving as it is. The doc text is unchanged, and juniper confirmed it matches src/web/plan_row.ts and src/spawn/clients.ts. I haven't added a pictures heading or links to docs/features/plan-row.md, because they would point at files that don't exist.

To finish it, someone with a browser needs to:

  • Put a forge in grace on the preview, using the same calls as test/plan-wiring.test.ts: putEntitlement(... status: "grace", periodEnd ...) for the forge, and keepNotice(dir, { ..., status: "grace", periodEnd }) for the host's own settings line.
  • Capture /settings (the Payment due — paused on <day> · Pay line) and /forges (the grace until <date> row), each in light and dark.
  • Commit the four PNGs under docs/features/ and link them from the grace section of plan-row.md.

Please run it somewhere Chromium can start, or reassign it to a run with a working browser.

commented

Declined: the four screenshots can't be captured from this sandbox, so nothing new is pushed; the earlier "updated pull #11531 (9a1321c)" line was not a real update. The branch holds only the two-sentence doc commit that juniper confirmed is accurate. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m76efxehvc906qy0h0vyr7r8

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs