A review's line comments travel inside the review to a forge origin, not one by one after it #11483

A review submitted through a Forgejo, Gitea or GitHub origin now sends its line comments inside the review, in one call. Tests, tsc and the gate pass locally; the full suite wasn't run (the forge runs it on push).

What changed

• submitReview takes optional comments. The Forgejo and GitHub providers send them in the review POST.

- Forgejo takes new_position or old_position per comment. GitHub takes line plus side. - I used these instead of the issue's {path, line, body} because Forgejo ignores line and would pin the comment to the wrong place. This departs from the spec.

• Fallback: if the origin answers 4xx or invalid to the payload, the provider posts the verdict again alone, so the verdict is never lost. Auth, forbidden, not-found, rate-limit and unreachable errors are not retried.
• In src/actions/pulls.ts, when the origin took the comments, they are not also posted locally and a sync is requested so they come back from the origin. Posting both would show each comment twice.
• When the origin refused them, the lines are posted locally one by one as today and a single warn log line says so. That log is the only "says so": the reviewer is not told in the UI.
• The "do not travel" bullet is gone from docs/ORIGINS.md.
• test/origin-review-comments.test.ts runs against the fake provider for both Forgejo and GitHub. It covers one request carrying the verdict and three comments, no comments key when there are none, the refused-payload fallback, and no retry on an auth failure. test/fake-origin.ts gained refuseReviewComments.

Not done

• There is no action-level test of the skip-local-post and sync-request branch in submitReview, only the provider tests.
• Until the requested sync runs, a reviewer on a mirror doesn't see their carried comments locally.
• The pre-push hook required a "Try:" commit; I added an empty one.

Try it Run bun test test/origin-review-comments.test.ts. Or submit a review with line comments on a mirrored pull and look for one review carrying them on the origin.

Closes #11479

A review submitted through a Forgejo, Gitea or GitHub origin now sends its line comments inside the review, in one call. Tests, tsc and the gate pass locally; the full suite wasn't run (the forge runs it on push).

What changed

• submitReview takes optional comments. The Forgejo and GitHub providers send them in the review POST.

- Forgejo takes new_position or old_position per comment. GitHub takes line plus side. - I used these instead of the issue's {path, line, body} because Forgejo ignores line and would pin the comment to the wrong place. This departs from the spec.

• Fallback: if the origin answers 4xx or invalid to the payload, the provider posts the verdict again alone, so the verdict is never lost. Auth, forbidden, not-found, rate-limit and unreachable errors are not retried.
• In src/actions/pulls.ts, when the origin took the comments, they are not also posted locally and a sync is requested so they come back from the origin. Posting both would show each comment twice.
• When the origin refused them, the lines are posted locally one by one as today and a single warn log line says so. That log is the only "says so": the reviewer is not told in the UI.
• The "do not travel" bullet is gone from docs/ORIGINS.md.
• test/origin-review-comments.test.ts runs against the fake provider for both Forgejo and GitHub. It covers one request carrying the verdict and three comments, no comments key when there are none, the refused-payload fallback, and no retry on an auth failure. test/fake-origin.ts gained refuseReviewComments.

Not done

• There is no action-level test of the skip-local-post and sync-request branch in submitReview, only the provider tests.
• Until the requested sync runs, a reviewer on a mirror doesn't see their carried comments locally.
• The pre-push hook required a "Try:" commit; I added an empty one.

Try it Run bun test test/origin-review-comments.test.ts. Or submit a review with line comments on a mirrored pull and look for one review carrying them on the origin.

Both blocking points and the formatting notes from the review are addressed. The two new tests and the existing review tests I ran pass, and bun x tsc --noEmit and scripts/gate.ts are clean.

• Action-level test. test/origin-review-actions.test.ts mirrors a repo from a fake GitHub origin with a real pull and diff, then calls submitReview with one line comment.

- When the origin carries the line, the origin sees one POST, no line comment is posted locally, and next_sync_at is reset (the requestSyncNow effect). - With refuseReviewComments set, the origin sees the refused POST and then the bare verdict, and the line is posted locally once. - I inverted the carried condition and both tests failed, so reverting or flipping that branch no longer leaves the suite green.

• Reviewer told about the fallback. When the origin refuses the lines, submitReview now returns the review with a note: "The origin refused line comments inside a review: the verdict went there alone and the line comments are kept here." The REST API returns it in the 201 body, since only that door sends lines. The log line stays.
• Formatting. The lines map in forgejo.ts is re-indented, the one in github.ts is split across lines, and postReview is back in import order in both providers.

Not done:

• "Try:" commit. Dropping it means rewriting history, and force pushes are refused, so it stays. It changes no files.
• note in other callers. The web, TUI and MCP callers don't show it, because none of them send line comments today.
• Feature versus pipeline direction. That's a call for a person.

To try: bun test test/origin-review-actions.test.ts test/origin-review-comments.test.ts.