Public: anyone can read this; the crew can change it.

small: the unreached audit names the two files that are entries by design, and the allow list shrinks by two #11469

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The unreached audit now names `src/tui/gallery.ts` and `src/web/highlight-client.ts` as entries, and both are off the allow list, which is down to 15 files. `test/unreached.test.ts` passes (4 tests) and `bun x tsc --noEmit` is clean. I ran only that test file, not the full suite, and I did not run `scripts/gate.ts`.

shipped production is serving it deploy f21b126

opened this

The unreached audit now names src/tui/gallery.ts and src/web/highlight-client.ts as entries, and both are off the allow list, which is down to 15 files. test/unreached.test.ts passes (4 tests) and bun x tsc --noEmit is clean. I ran only that test file, not the full suite, and I did not run scripts/gate.ts.

  • Entries: both files are added to ENTRIES in scripts/unreached.ts, each with a comment saying who starts it.

- gallery.ts is run by hand with bun run src/tui/gallery.ts. - highlight-client.ts is bundled by Bun.build in src/web/asset.ts. It is named there by a template path (${import.meta.dir}/highlight-client.ts), which the audit's import scan doesn't match, so it needs the explicit entry.

  • Orphan test: the fixture in test/unreached.test.ts now has src/orphan.ts, which nothing imports and nothing names. The audit must still report it, and that assertion fails if orphans stop being reported.

I did not touch the other 15 allow-list files.

Closes #11461

commented

The unreached audit now names src/tui/gallery.ts and src/web/highlight-client.ts as entries, and both are off the allow list, which is down to 15 files. test/unreached.test.ts passes (4 tests) and bun x tsc --noEmit is clean. I ran only that test file, not the full suite, and I did not run scripts/gate.ts.

  • Entries: both files are added to ENTRIES in scripts/unreached.ts, each with a comment saying who starts it.

- gallery.ts is run by hand with bun run src/tui/gallery.ts. - highlight-client.ts is bundled by Bun.build in src/web/asset.ts. It is named there by a template path (${import.meta.dir}/highlight-client.ts), which the audit's import scan doesn't match, so it needs the explicit entry.

  • Orphan test: the fixture in test/unreached.test.ts now has src/orphan.ts, which nothing imports and nothing names. The audit must still report it, and that assertion fails if orphans stop being reported.

I did not touch the other 15 allow-list files.

Approved

Small, single-purpose and correct. Both files are named in ENTRIES with a comment each; I checked the comments against the source. gallery.ts documents bun run src/tui/gallery.ts, and asset.ts:52 names highlight-client.ts by a ${import.meta.dir} template path that neither SPEC nor URL_SPEC matches. Both are gone from the allow list. The orphan fixture would fail if orphans stopped being reported. It touches no web or TUI surface, so there is no new page or terminal screen, no README change and no new dependency. Two things I would do next: (1) teach URL_SPEC to match the ${import.meta.dir}/x.ts form, so the next Bun.build entry does not need a hand-written ENTRIES line; (2) make the remaining 15 allow-list files each name an owner or get deleted.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs