Public: anyone can read this; the crew can change it.
A wave's page opens with one sentence of what changed for a person, then the counts #11442
A wave's page now opens with a one-sentence summary of what landed, but the commit is not pushed. Every push attempt, including a retry loop, failed with HTTP 530 from https://forge.open-platform.sh/scout/forge.git/.
stopped parked by the crew
2 earlier comments · 1 event
The web sentence works and is escaped, but four things are missing.
- Terminal door: the sentence is only on the page. src/tui/screens/waves.ts
waveLinesshould print the samewaveSentence(...)line under the headline (throughplain), with a test in test/tui-waves.test.ts. - No docs/features how-to: add the sentence to docs/features/wave-walk.md, or a new feature doc.
- Box 4: nothing in this diff links /changelog to a wave, and the preview /changelog has no wave link. Add a one-tap link from /changelog to the waves page, with a test.
- Principle 1 and 8:
Landed: a; b; and 3 more.is a list with a label, not a sentence in plain words. Make it read as one sentence, for exampleThis wave landed a, b and 3 more., and keep the test on that wording.
Also tighten the page test: the regex <[^p][^>]*> is brittle. Assert the escaped substrings on the data-wave-sentence element in a simpler way.
A wave's page now opens with one plain sentence of what landed, the terminal prints the same sentence, and /changelog links on to the waves. The four test files that cover this pass, and so do tsc, design-lint and gate.ts. I did not run the suite scripts/fast.ts names: it expects about 158 minutes over 1858 files, so the forge's check runs it.
- Sentence wording (
src/story/words.ts): it now readsThis wave landed a, b and 3 more., orThis wave landed a and b.for two. It is still deterministic and capped at 160 characters. When nothing has landed it saysNo pull in this wave has landed yet. - Terminal (
src/tui/screens/waves.ts):waveLinesprintswaveSentence(...)under the headline, throughplain. A test intest/tui-waves.test.tscovers both the landed and the nothing-landed line, and that control characters are stripped. - Changelog link (
src/web/pages/changelog.ts): a one-tap "Read it by wave" link goes to/<own repo>/waves. It shows only when the forge's own repository is readable by the viewer. Test intest/changelog.test.ts. - Docs:
docs/features/wave-walk.mdhas a new section, "What a wave changed, in one sentence". - Page test (
test/wave-pulls.test.ts): the brittle regex is replaced by slicing the text betweendata-wave-sentence>and</p>. It asserts the escaped<b>title, theThis wave landedwording, no raw<b>, and no dropped pull.
What I left out: the link goes to the waves list for the forge's own repository, not to one particular wave. The changelog lists landings by day and does not say which wave a landing belongs to.
Try: open /changelog, tap "Read it by wave", then open a wave and read the sentence under its headline.
The preview failed to boot because a bad merge had left conflict markers in src/web/pages/changelog.ts. I've fixed that and pushed; I haven't seen the preview come up yet.
The conflict was in the changelog page's body. I kept both sides: the nearBlock(...) call that came in from origin/main, and the "Read it by wave" link this pull adds.
Before pushing, bun x tsc --noEmit was clean. I ran 7 changelog and waves test files, covering both the changelog and the by-wave page, and they all passed. I did not run bun scripts/gate.ts or bun scripts/design-lint.ts, and the forge's full check on this push will cover the rest.
The first test run I started used a bare bun test, because scripts/fast.ts reported the diff as too broad to name. I stopped it and picked the test files by hand.
Parked by the crew: the check stayed red through 2 automatic tries: wave folds > headline, then progress, then two closed change folds each holding its pull, then the pulls
A wave's page now opens with a one-sentence summary of what landed, but the commit is not pushed. Every push attempt, including a retry loop, failed with HTTP 530 from
https://forge.open-platform.sh/scout/forge.git/. The commit is local onscout/11435-a-wave-s-page-opens-with-one-sentence-of, so a plaingit pushshould land it once the forge is reachable. Until then there is no pull and no preview.What changed
waveSentence()insrc/story/words.tsbuilds the sentence from the titles of the pulls that actually merged. It is deterministic, has no model call, and is capped at 160 characters.wavePageinsrc/web/pages/waves.ts) shows that sentence as the first paragraph under the headline, before the counts line, highlights and pulls.test/wave-sentence.test.tscovers the sentence, the cap and the empty case.test/wave-pulls.test.tsgets a new test that fetches a wave page and checks:<b>in a title is escaped;bun x tsc --noEmit,bun scripts/gate.tsandbun scripts/design-lint.tspass. I rantest/wave-sentence.test.ts,test/wave-pulls.test.tsandtest/waves-page.test.ts; all 37 tests pass.Left out
/changelogto a wave page. #11409 is editing that page, and its landings are pulls, not waves. A wave page is still reachable from/:owner/:name/wavesand from the latest-wave link on the repo page.Closes #11435