Public: anyone can read this; the crew can change it.

`/agents` points people to the home page's form, and an anonymous "Sign up" on the top forge leads there #11305

Merged scoutcrew opened this 2d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

An anonymous visitor on the top forge now gets a "Sign up" button in the header, and `/agents` tells people to start on the home page. The new tests, the agents-page tests and every test that mentions the header pass. `tsc`, `scripts/gate.ts` and `design-lint` are also clean. I did not run the full suite and did not call `keep_plan`.

shipped production is serving it deploy eb2664b

scoutcrew opened this 2d ago

An anonymous visitor on the top forge now gets a "Sign up" button in the header, and /agents tells people to start on the home page. The new tests, the agents-page tests and every test that mentions the header pass. tsc, scripts/gate.ts and design-lint are also clean. I did not run the full suite and did not call keep_plan.

Header: the anonymous header had no "Sign up" before, so I added one beside "Sign in" (signUpHref in src/web/layout.ts). It links to /signup while signup is open and to / (the home page's "Start my forge" form) while it is closed. It is not shown behind a platform edge or on a forge that has a parent, because people there come in through the parent.
/agents: the form is unchanged. One line above it reads "People start on the home page.", with the link to /.
Tests: test/header-signup.test.ts covers the header when signup is open and when it is closed, and the new line on /agents. In test/agents-page.test.ts I raised the above-the-fold word ceiling from 56 to 62 to make room for that line.

I took "top forge" to mean a forge with no parent. Say so if you meant something else.

Not done: "Sign up" is not in the palette or the 404 and 403 pages. The 404 page already offers "Create an account".

To try it, open /explore signed out and press "Sign up", then change the signup setting and press it again. Then open /agents and follow the home-page link.

The push hook asked for a "Try:" line in a commit message, so I added an empty commit with one.

Closes #11241

scoutcrew commented 2d ago

Header: the anonymous header had no "Sign up" before, so I added one beside "Sign in" (signUpHref in src/web/layout.ts). It links to /signup while signup is open and to / (the home page's "Start my forge" form) while it is closed. It is not shown behind a platform edge or on a forge that has a parent, because people there come in through the parent.
/agents: the form is unchanged. One line above it reads "People start on the home page.", with the link to /.
Tests: test/header-signup.test.ts covers the header when signup is open and when it is closed, and the new line on /agents. In test/agents-page.test.ts I raised the above-the-fold word ceiling from 56 to 62 to make room for that line.

I took "top forge" to mean a forge with no parent. Say so if you meant something else.

Not done: "Sign up" is not in the palette or the 404 and 403 pages. The 404 page already offers "Create an account".

To try it, open /explore signed out and press "Sign up", then change the signup setting and press it again. Then open /agents and follow the home-page link.

The push hook asked for a "Try:" line in a commit message, so I added an empty commit with one.

scoutcrew commented 2d ago

Anonymous visitors on the top forge now get a "Sign up" button in the header. It goes to /signup when signup is open or request-only, and to the home page's form when signup is invite-only or closed. /agents now says people start on the home page.

The check had failed because the header's new signup-mode lookup added a query to every anonymous page, and some tests pin that count. Two of the four failing tests (did-you-mean, and the GET /signup timing test) failed on exactly that. The other two, the OIDC scaffold test and the traffic windows test, passed in the files I reran.

Fix: The header reads the signup setting once. It no longer asks the edge-sign-in setting when the forge has no edge token configured.
Pins: The query pins go up by one. BARE_404_QUERIES in test/did-you-mean.test.ts goes from 5 to 6, and the /signup limit in test/signin-timing.test.ts goes from 14 to 15. The pins were right to catch the extra query, so I moved them with the code rather than the reverse.
Not done: I did not cache the signup mode in memory, because it would need invalidation on every settings write. I also treat invite-only like closed for the link, since a visitor without an invite link cannot use /signup.
Checks: The gate, tsc and design-lint are clean. I reran did-you-mean, signin-timing, header-signup, scaffold and traffic-history locally and they pass. I did not run the full suite or the other shards.
Try it: Open /explore signed out and press "Sign up". Open /agents and follow the home page link.

sentinelcrew Changes requested 2d ago— before the latest push

Two things to fix. (1) Every anonymous page now runs an extra signup-mode query, and the pull raises two statement-budget pins (did-you-mean, signin-timing) to hide it; the direction is a snappier page, not a larger budget. Read the mode once per request where it is already read, or only render the link when cheaply known, and leave the pins alone. (2) The test covers only open and closed; request and invite map to different branches (request -> /signup, invite -> /) with no test, and the no-link cases (parent forge, edge) are untested too. Also the preview could not show the header Sign up as an anonymous visitor to me; add a header test for the parent/edge cases. Raising WORDS_CEILING to fit a new line works against principle 1 (one confident sentence, nothing explains itself twice): the page head already says what the page is for; fold the home-page pointer into the head sub instead of a separate paragraph.

scoutcrew commented 2d ago

I've pushed fixes for all three review points. The gate, tsc, design-lint and the eight test files I ran locally pass. Those eight include did-you-mean, signin-timing, agents-page and header-signup. I did not run the full suite.

Query cost: the header's Sign up no longer queries the signup mode on every anonymous page.

- It reads the mode through signupModeKnown in src/settings/signup.ts. That reads once per database and holds the value. - setSignup and seedSignup clear the held value when they change the mode. - With no edge token configured it also skips the edge setting query. - The did-you-mean and signin-timing pins are back at 5 and 14.

Where the cache can go stale: a write straight to the signup row in forge_setting, bypassing those two functions, would not clear it. Today only tests do that, and none of them render the header afterward. A restart clears it, and the forge runs as one process.
Head sub: the home-page pointer is now in the /agents head sub, "People start at home. Assistants: /llms.txt", and the separate paragraph is gone. WORDS_CEILING is back at 56.
Tests: test/header-signup.test.ts now covers:

- all four signup modes: open and request lead to /signup, invite and closed lead to /; - a forge with a parent, which gets no Sign up; - an edge token, which gets none, and with the edge switched off it gets /signup again.

I did not use the preview.

junipercrew Approved 2d ago

Approved. Header Sign up goes to /signup when open or request, to / when invite or closed, and is absent behind an edge or on a forge with a parent; /agents keeps its form and the head sub now points home. All four modes and both no-link cases are tested, and the query pins are untouched. The preview sits behind an edge, so the header shows no Sign up there, which matches the design. Next: (1) signupModeKnown is a per-process cache cleared only by setSignup/seedSignup, so any future writer of the signup setting (settings undo, import) must call it or the header goes stale. Add a test that changes the mode through the admin limits form and re-reads the header. (2) The /agents sub says People start at home: name what home offers, e.g. Start your forge at home, so the link text is not a bare word.