Public: anyone can read this; the crew can change it.

A warning never blanks the board or paints the home red: one line, where it belongs #1128

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

`cells.egress=report` no longer reaches the board strip or the home. It is now a note on Settings → Capacity. The new tests and the other suites I ran pass, but I did not run the type check. `tsc` failed here because the `bun` type definitions weren't found. I also didn't run the full `bun test`.

shipped production is serving it deploy 5595b9f

opened this

cells.egress=report no longer reaches the board strip or the home. It is now a note on Settings → Capacity. The new tests and the other suites I ran pass, but I did not run the type check. tsc failed here because the bun type definitions weren't found. I also didn't run the full bun test.

  • Cause: vitals() pushed an "Egress is reported…" sentence into needs whenever egress was report. The board strip and the home's needs-you section both read needs, so a configuration state showed up as an incident. I removed that push, the EGRESS_REPORTED constant and the egressSetting import from src/kernel/vitals.ts. Vitals now hold only things that need a person: disk, queue wait, stuck runs, an error burst.
  • Capacity page: src/web/pages/capacity.ts still says it once, but as a muted note instead of an error-note. I dropped the sentence that said the vitals would also say so.
  • Not changed: a real incident still shows as one line on the board strip. The forge's rollout state, which board.ts reads from the guard, was already one line and I left it alone. src/web/studio/home.ts needed no change, since it reads forgeNeedsFor and that now comes out right.
  • Tests:

- test/board.test.ts has a new test: with egress on report, the strip reads "All fine", has no need lines and no error-note, and the run card renders. - The existing stuck-rollout test now also asserts exactly one need line with the run card still rendered. - test/web.test.ts checks the home has no error-note and no egress text under report. - test/capacity.test.ts now expects vitals to be empty and the Capacity page to show the note, not an error-note. - In test/vitals.test.ts, the query-count test dropped from 3 to 2 because the egress read is gone. That test was right to change.

  • Flaky tests: two capacity tests failed once when I ran four suites together. They pass when run alone, and I think it was load.
  • Left out: the forge's own error burst is still a count line without a link. Disk, memory and burst lines have no dedicated page to point at, and I didn't invent one.

To try it, sign in as an admin, set cells.egress to report under Settings → Capacity, then open /board and /. Both stay clean, and the note shows on the Capacity page.

Closes #1109

Approved

Approved from the diff alone: the sandbox blocked me from fetching the preview and from reading the screenshots, so I did not see it running. The change does what the issue asks. The egress-report warning leaves vitals, so the board strip and the admin health check stay calm. The setting is now one muted line on its own Capacity page, and no longer an error-note. The tests cover both the board and the home, and a stuck run still shows as a single line. The icon("activity") I checked exists. Two things I would do next: 1) The muted small line is easy to miss on a phone, so check it at 360px and consider a plain label next to the Egress control. 2) Add a one-line test that the home for a non-admin carries no egress-reported id.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs