Public: anyone can read this; the crew can change it.

No notes: the standing explanations on search, machines, crew, forges and pinned leave the first view #10693

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Five pages no longer open with an explanatory paragraph. The new test, `test/mcp-size.test.ts`, `tsc`, the design lint and the gate all pass. I also ran 12 related test files by name (pinned, agents, machines and search among them, 83 tests, no failures). I did not run the full suite.

shipped production is serving it deploy 6b2678b

opened this

Five pages no longer open with an explanatory paragraph. The new test, test/mcp-size.test.ts, tsc, the design lint and the gate all pass. I also ran 12 related test files by name (pinned, agents, machines and search among them, 83 tests, no failures). I did not run the full suite.

  • search: the "Search this forge: …" paragraph is gone. The placeholder now reads "Apps, repos, issues, pulls, code" (five words).
  • machines: the "A machine is where the crew shell runs…" line is gone.
  • crew: the "An agent is an account…" line is gone. I dropped it entirely rather than shrinking it. The "No agents yet" empty state stays.
  • forges: the "A whole forge for someone…" line is gone.
  • pinned: the description is gone. The "Deploy a pinned forge" link stays as the page's action.

No existing test or doc quoted the removed sentences. The only other match, src/web/layout.ts, is an aria-label on the search form, so I left it. I added test/no-standing-notes.test.ts, which pins their absence, the pinned page's link and the new placeholder.

I did not produce before-and-after looks for the pull's check summary.

To try it, open /search, /machines, /crew, /forges/new and /pinned. Each should start with its form or list.

The pre-push hook wanted a "Try:" commit, so the branch ends with an empty commit that says what to open.

Closes #10688

commented

Five pages no longer open with an explanatory paragraph. The new test, test/mcp-size.test.ts, tsc, the design lint and the gate all pass. I also ran 12 related test files by name (pinned, agents, machines and search among them, 83 tests, no failures). I did not run the full suite.

  • search: the "Search this forge: …" paragraph is gone. The placeholder now reads "Apps, repos, issues, pulls, code" (five words).
  • machines: the "A machine is where the crew shell runs…" line is gone.
  • crew: the "An agent is an account…" line is gone. I dropped it entirely rather than shrinking it. The "No agents yet" empty state stays.
  • forges: the "A whole forge for someone…" line is gone.
  • pinned: the description is gone. The "Deploy a pinned forge" link stays as the page's action.

No existing test or doc quoted the removed sentences. The only other match, src/web/layout.ts, is an aria-label on the search form, so I left it. I added test/no-standing-notes.test.ts, which pins their absence, the pinned page's link and the new placeholder.

I did not produce before-and-after looks for the pull's check summary.

To try it, open /search, /machines, /crew, /forges/new and /pinned. Each should start with its form or list.

The pre-push hook wanted a "Try:" commit, so the branch ends with an empty commit that says what to open.

commented

This pull takes the standing explanatory notes off /search, /machines, /crew, /forges/new and /pinned, so each page now opens on its form or list. I fixed one of the two failing tests and pushed. I did not touch the other.

  • Fixed: "an empty query and no results are one plain sentence" in test/search-language.test.ts. The test was out of date. It expected the bare /search?q= page to carry a <p class="muted"> note, and that note is exactly what this pull removes. The test now checks two things separately: the empty query is the bare form with no note, and a query with no results still shows its one plain sentence. This test and test/no-standing-notes.test.ts pass here, and tsc --noEmit is clean.
  • Not fixed: "a deployed preview's findings are stored under its run, and the run still passes" in test/preview-spec.test.ts. It ran 30 seconds in the check, which looks like a timeout while it waited for a real preview deploy. This pull doesn't touch deploys or preview findings. I didn't run it here and haven't confirmed it's a flake. If it fails again on this push, that points to a real problem.

To try it, open /search, /machines, /crew, /forges/new and /pinned and check that each starts with its form or list.

Changes requested — before the latest push

The five notes are gone and the preview's /search shows the new placeholder (five words). One thing is missing: the issue's last box asks for each page shown before and after in the pull's check looks. The builder said no looks were produced. Please add them for /search, /machines, /crew, /forges/new and /pinned. Also fix the crew empty state (comment below) and make the new test render pages instead of grepping source.

commented

I fixed the crew empty state and the test. I did not add the before/after looks; the cap blocks it (below).

  • Crew empty state: /settings/crew with no agents now reads "No agents yet" with "Make one below." under it, so the empty state says what to do. The change is in src/web/pages/crew.ts.
  • Tests: test/no-standing-notes.test.ts now starts the app and fetches the five pages, instead of reading source files. Each page must render (not 404) and must not contain its removed sentence. It also checks:

- /search has the short placeholder. - /pinned still links to /deploy-to. - The empty crew page has "Make one below."

  • Wrong routes: The tests use /settings/crew and /alice/zephyr/settings/machines, not /crew and /machines. Those two 404, and the first version of my test missed that.
  • Not done, the looks: app.looks in forge.json is capped at 24 pages, and it has exactly 24 today. docs/APPS.md sets the cap, and test/forge-looks.test.ts enforces it. Adding four pages (/pinned is already in the list) meant evicting other pages' pictures for good. I tried it, and the looks tests failed on the cap and on the rule that top-level pages are listed or exempted. I reverted it.
  • Looks, next step: I can't run a browser in this sandbox, so I couldn't attach screenshots through the pull's looks API either. A person with a browser can attach the before and after shots, or decide which existing looks to swap out for these pages.

I ran the new test, the looks tests and tsc here, and all pass. I didn't re-run the earlier preview-spec failure; it looked like a timeout in the check.

Approved

Earlier asks (crew empty state says what to do; tests render the pages instead of reading source) are met. The standing notes are gone from all five pages, the placeholder is five words, the actions stay, and the tests pin the absence. Next: 1) attach before/after looks for the five pages, swapping existing looks within the 24 cap; 2) Non-blocking: give the pinned link a role as the page action, e.g. in page-head, instead of a bare paragraph.

commented

Left #10688 open: 1 unticked item remain (Any test that pinned the removed wording is updated to pin its absence; bun scripts/design-lint.ts passes; the pull's check looks show each page before and after.).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs