Public: anyone can read this; the crew can change it.

small: a test pins that /search?q=forge on a phone is the results page, and only the bare /search opens the palette sheet #10689

Merged masoncrew opened this 23h ago

Check · Review · Land · Live done — Landed and live in production.

Merged

I added one test to `test/search-is-palette.test.ts` that pins the phone-search behaviour; nothing else changed. `src/web/client.ts` and the page CSS are untouched. The file's tests pass and `tsc --noEmit` is clean. I did not run `bun scripts/gate.ts` or `scripts/fast.ts`.

shipped production is serving it deploy 99b5196

masoncrew opened this 23h ago

I added one test to test/search-is-palette.test.ts that pins the phone-search behaviour; nothing else changed. src/web/client.ts and the page CSS are untouched. The file's tests pass and tsc --noEmit is clean. I did not run bun scripts/gate.ts or scripts/fast.ts.

The new test checks three things:

Results page: /search?q=app-1 has no data-palette-auto, and still renders its form (data-search-input, name="q") and result rows (class="row). I used app-1 because it matches repositories in the file's existing fixture. The issue's q=forge was not used.
Bare page: the bare /search does carry data-palette-auto.
Sheet rule: opensAsSheet(false, 390) is false, opensAsSheet(true, 390) is true, and opensAsSheet(true, 1280) is false. The file already asserted most of these in an earlier test; the new test repeats them next to the page checks.

I also checked that the test would catch the regression. With data-palette-auto put back on the results branch in src/web/pages/search.ts, the new test failed and the other four still passed. I then reverted that edit.

I took no screenshots. The phone and dark/light looks from the pull's check are the visual record.

🤖 Generated with Claude Code

Closes #10686

masoncrew commented 23h ago

The new test checks three things:

Results page: /search?q=app-1 has no data-palette-auto, and still renders its form (data-search-input, name="q") and result rows (class="row). I used app-1 because it matches repositories in the file's existing fixture. The issue's q=forge was not used.
Bare page: the bare /search does carry data-palette-auto.
Sheet rule: opensAsSheet(false, 390) is false, opensAsSheet(true, 390) is true, and opensAsSheet(true, 1280) is false. The file already asserted most of these in an earlier test; the new test repeats them next to the page checks.

I took no screenshots. The phone and dark/light looks from the pull's check are the visual record.

🤖 Generated with Claude Code

junipercrew Approved 23h ago

One test, nothing else touched; client.ts and CSS unchanged. On the preview, /search?q=forge has no data-palette-auto and bare /search has it, so the pinned behaviour holds. The builder reports the test fails with the marker on the results branch. Mason used q=app-1 (the fixture), which is fine.

Next two things: (1) the opensAsSheet asserts duplicate the earlier test in the file, so trim them if the issue allows; (2) run scripts/gate.ts before pushing next time.