b49d1e4 · 112be77 · 685a3d6 · 35929e0
@@ -17,3 +17,12 @@
The feed — the composer, the timeline, what is on you, since you were here —
Left out on purpose: the waiting-on-you line, the clog, vitals and keeper lines (the boards and the Flow dialog still show them), and "slowest right now" (it needs a timing read the home does not have). The box posts to `/tell` today; it becomes the `/talk` entry (#7652) when that lands.
The two scans behind the lists are read once per write (`writeStamp`), so a warm home reads no tables for them.
## The figures tell the truth (#10440)
- **Slots** in "Builders running" are `crew.concurrency` (`crewConcurrency` in `src/flow/slot_cap.ts`), or the repositories' slots when those are fewer: the sum of the repositories' slots is a ceiling, not a limit. Home and the terminal read the same figure.
- **"Nothing ready"** is said only when the repository's map has nothing ready (`/api/v1/repos/:owner/:name/map`); `test/home-builders-idle.test.ts` checks home against that answer.
- **Pace line:** "Behind pace" only when the used percent is below the elapsed percent; otherwise "Under the allowed burn".
- **Just shipped** titles are cut at a word (`shortTitle`); the row's hover and screen-reader title carry the whole one.
- **Dropped on purpose** (the issue named them: no decision uses them): the Traffic, Reporting browsers and Accounts tiles. The same numbers stay on `/settings/traffic`, `/boards/reach` and the KPI probe.
- A stuck approved pull is one line ("… waits for a person to merge it."); the wall it hit is on the pull.
@@ -19,7 +19,7 @@
import { standings } from "../core/standing.ts";
import { grantedAccounts } from "../core/subscriptions.ts";
import { slottedRuns, spentToday } from "./autonomy.ts";
import { atCeiling } from "./dispatch.ts";
import { heldNow } from "./held.ts";
import { heldNow, HOLDS } from "./held.ts";
import { pace } from "./pacing.ts";
export interface IdleReason {
@@ -54,7 +54,10 @@
export function idleReason(app: App, now: Date): IdleReason | null {
    }
    const held = heldNow(app, repo);
    return held.startable.length === 0 ? { word: "nothing ready", href: "/map" } : null;
    if (held.startable.length > 0) return null;
    // "Nothing ready" is true only when the map's ready list is empty; otherwise the ready issues are all held.
    const ready = HOLDS.reduce((n, h) => n + held.by[h].length, 0);
    return { word: ready === 0 ? "nothing ready" : "none startable", href: "/map" };
  }
  return null;
}
@@ -149,6 +149,7 @@
export function weekDecision(input: WeekInput): WeekDecision | null {
        ? `under a point over the last ${WEEK.burnHours} h (the meter moves in whole points and the crew ran)`
        : `${pct(burn)} an hour over the last ${WEEK.burnHours} h`;
  // `full`: the free percent and run-out time are said here; otherwise the crew line above says them.
  const behindLabel = used < (1 - left / WINDOW_MS.week) * 100 ? "Behind pace" : "Under the allowed burn";
  const say = (full: boolean): string => {
    const weekLeft = full ? `${Math.round(meter.freePct)}% of the week left with ${timeGone}` : `the week has ${timeGone}`;
    const runOut = full && runsOutAt !== null ? `, running out about ${utc(runsOutAt)}` : "";
@@ -158,7 +159,7 @@
export function weekDecision(input: WeekInput): WeekDecision | null {
        ? `On pace: ${weekLeft}; burning ${burnWords}, ${pct(allowed)} is allowed.`
        : status === "ahead"
          ? `Ahead of pace: ${weekLeft}, burning ${burnWords} against ${pct(allowed)} allowed${runOut}; ${slots === 0 ? "holding the crew for the reset" : `slowing to ${slots} of ${ceiling} slots`}.`
      
        junipercrew
        1d ago
        outdated
      
      The label is chosen by an inline ternary inside a template string, and it recomputes elapsed time with (1 - left / WINDOW_MS.week) * 100 where say already knows the pace. Compute const label = ... once above and reuse it. The line is now unreadable.
    
          : `Behind pace: ${weekLeft}, burning ${burnWords} against ${pct(allowed)} allowed; ${slots === 0 ? "holding the crew for the reset" : `speeding up to ${slots} of ${ceiling} slots`}${release ? " and releasing the next issue" : ""}.`;
          : `${behindLabel}: ${weekLeft}, burning ${burnWords} against ${pct(allowed)} allowed; ${slots === 0 ? "holding the crew for the reset" : `speeding up to ${slots} of ${ceiling} slots`}${release ? " and releasing the next issue" : ""}.`;
  };
  return { status, targetPctPerHour, allowedPctPerHour: allowed, runsOutAt, slots, release, sentence: say(true), besideCrewLine: say(false) };
}
@@ -140,7 +140,7 @@
export function alarmStuck(from: App | Database, now: Date, scope: StuckScope =
      repo,
      number,
      wall,
      says: `${repo}#${number} is approved and waits for a person: ${wall.join("; ")}. Allow it (merge) or send it back.`,
      says: `${repo}#${number} is approved and waits for a person to merge it.`,
    };
  return {
    fired: true,
@@ -19,6 +19,7 @@
import { backupVerdict, isWatched, type BackupVerdict } from "../snapshot/bucket.ts";
import { lastDrill } from "../snapshot/drills.ts";
import type { Database } from "bun:sqlite";
import { crewConcurrency, shownSlots } from "./slot_cap.ts";
import { spentTodayEverywhere } from "../crew/autonomy.ts";
import { ceilingHitAt, ceilingReached } from "./ceiling.ts";
import type { IdleReason } from "../crew/idle_reason.ts";
@@ -78,7 +79,8 @@
export function readBuilders(db: Database, idle: IdleReason | null = null): Kpis
                (SELECT COALESCE(SUM(autonomy_slots), 0) FROM repo WHERE autonomy != 'off') AS slots`,
      )
      .get() ?? { running: 0, slots: 0 };
  return { ...counts, idle };
  const slots = shownSlots(counts.slots, crewConcurrency(db));
      
        junipercrew
        1d ago
        outdated
      
      Hand-rolled IIFE with a try/catch that swallows every error and returns NaN. Catching 'no settings table' this way hides real failures. Read the value through one named helper that returns a number or null, with no exception for control flow. Put the min in buildersValue or a small module, not inline in the reader.
    
  return { ...counts, slots, idle };
}
/**
@@ -15,6 +15,8 @@
import type { PipelineStage } from "./pipeline.ts";
export interface MovingRow {
  readonly who: string;
  readonly title: string;
  /** The title whole, for a hover or a screen reader: cutting `title` loses nothing. */
  readonly full: string;
  readonly href: string;
  readonly at: string;
  /** `owner/name`, for the row's title attribute. */
@@ -22,6 +24,18 @@
export interface MovingRow {
}
export const MOVING_ROWS = 3;
/** Longest title a home row shows. */
export const TITLE_MAX = 60;
/** A title cut at a word boundary, with an ellipsis; whole when it fits. */
export function shortTitle(title: string, max = TITLE_MAX): string {
  const t = title.replace(/\s+/g, " ").trim();
  if (t.length <= max) return t;
  const cut = t.slice(0, max);
  const at = cut.lastIndexOf(" ");
      
        junipercrew
        1d ago
        outdated
      
      The regex strips a trailing -, –, ., : before the ellipsis, but when the cut is mid-word with no space past max/2 it still chops mid-word. The test only covers the happy path. Add cases for a long unbroken token and for whitespace-only collapse. Also keep full titles reachable (title attribute) so cutting loses nothing for a screen reader or a hover.
    
  // One long unbroken token has no boundary to cut at: it is cut at the limit.
  return `${(at > max / 2 ? cut.slice(0, at) : cut).replace(/[\s:,;.\-–]+$/, "")}…`;
}
/** Rows read before the viewer's access filters them; bounded, so the read is. */
const SCAN = 40;
@@ -66,7 +80,8 @@
function visible(db: Database, viewer: User, raw: readonly Raw[], path: string,
    if (repo === undefined) continue;
    out.push({
      who: r.who ?? "",
      title: r.title,
      title: shortTitle(r.title),
      full: r.title.replace(/\s+/g, " ").trim(),
      href: `/${repo.ownerName}/${repo.name}/${r.kind === undefined ? path : r.kind === "pull" ? "pulls" : "issues"}/${r.number}`,
      at: r.at,
      repo: `${repo.ownerName}/${repo.name}`,
@@ -0,0 +1,19 @@
/**
 * How many builders the crew may run at once, as home and the terminal say it:
 * the repositories' slots add up to a ceiling, `crew.concurrency` is the limit.
 */
import type { Database } from "bun:sqlite";
import { capacityValue } from "../core/capacity.ts";
/** The crew's concurrency now, or null when the setting holds no positive whole number. */
export function crewConcurrency(db: Database): number | null {
  // A database that never had settings (a bare fixture) has no limit to read.
  if (db.query("SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'forge_setting'").get() === null) return null;
  const n = Number(capacityValue(db, "crew.concurrency"));
  return Number.isInteger(n) && n > 0 ? n : null;
}
/** The slots to show: the repositories' sum, never more than the crew runs at once. */
export function shownSlots(sum: number, cap: number | null): number {
  return cap === null ? sum : Math.min(sum, cap);
}
@@ -11,7 +11,7 @@
 */
import type { Database } from "bun:sqlite";
import { KPI_COUNTS, backupFull, backupOverdue, backupValue, buildersValue, checkTime, reactNote, shippedValue, speedWords, spendCeilingWords, spendFull, spendValue, trafficValue, trafficWords, usersValue, visitorsNote, visitorsValue, waitingWords } from "../../flow/kpi_words.ts";
import { KPI_COUNTS, backupFull, backupOverdue, backupValue, buildersValue, checkTime, reactNote, shippedValue, speedWords, spendCeilingWords, spendFull, spendValue, waitingWords } from "../../flow/kpi_words.ts";
import { perfRecord } from "../../perf/live.ts";
import type { TrafficClass, TrafficMinute, TrafficTotals } from "../../perf/traffic.ts";
import type { IdleReason } from "../../crew/idle_reason.ts";
@@ -80,11 +80,6 @@
export function sparkline(hours: readonly number[]): Html {
  return spark([...hours].reverse(), "Shipped each hour over the last 24 hours");
}
/** Distinct visitors per day, oldest first, today on the right. */
export function visitorsSpark(days: readonly number[]): Html {
  return spark(days, `Distinct visitors each day over the last ${days.length} days`);
}
/** Lightest first, stacked from the bottom: the strangers sit on top and read darkest. */
export const TRAFFIC_TONES: readonly (readonly [TrafficClass, string])[] = [
  ["internal", "0.12"],
@@ -124,7 +119,6 @@
export function kpiRowFor(k: Kpis, live: { sha: string; at: string } | null, now
  const overdue = k.backup ? k.backup.state === "red" : backupOverdue(k.backupAt, now);
  const spendWords = spendCeilingWords(k.spend);
  const rate = shippedValue(k.landed, k.landedHours.length);
  const trafficSays = traffic === null ? null : trafficWords(traffic);
  return html`<section class="stats kpi-row mb" aria-label="The forge's figures, each over its own window; hover one for what it counts">
    ${tile(
      "Shipped per hour",
@@ -189,18 +183,6 @@
export function kpiRowFor(k: Kpis, live: { sha: string; at: string } | null, now
      null,
      k.bugs.overdue > 0 ? "attn" : null,
    )}
    ${traffic === null || trafficSays === null ? null : tile(
      "Traffic, 15 min",
      "/settings/traffic",
      trafficValue(traffic),
      `${traffic.requests} requests, ${traffic.refused} refused`,
      trafficSays.note,
      trafficSays.title,
      trafficColumns(traffic.minutes, W, H, "Answering time each minute over the last 15 minutes, by who asked"),
      trafficSays.attn ? "attn" : null,
    )}
    ${tile("Reporting browsers", "/boards/reach", visitorsValue(k.reach), `${visitorsValue(k.reach)}, ${visitorsNote(k.reach)}`, visitorsNote(k.reach), KPI_COUNTS.visitors, visitorsSpark(k.reach.visitorDays))}
      
        junipercrew
        1d ago
        
      
      Dead code: visitorsSpark has no caller once the Reporting browsers tile is gone. Remove it, and any now-unused import.
    
    ${tile("Accounts", "/boards/reach", usersValue(k.reach), usersValue(k.reach), "seen today", KPI_COUNTS.accounts)}
    ${tile(
      "Reported page speed",
      "/boards/reach",
@@ -59,7 +59,7 @@
function listOf(label: string, rows: readonly MovingRow[], empty: string, headin
    row({
      href: r.href,
      ...(r.who === "" ? {} : { lead: html`<span class="muted small">${r.who}</span>` }),
      title: html`<span class="truncate" title="${r.repo}">${r.title}</span>`,
      title: html`<span class="truncate" title="${r.repo}: ${r.full}">${r.title}</span>`,
      trail: html`<span class="muted small">${timeAgo(r.at)}</span>`,
    }),
  );
@@ -99,7 +99,8 @@
describe("alarmStuck", () => {
    wall("h");
    const a = alarmStuck(app, NOW);
    expect(a.wall).toEqual(["anyone signed out could read pack records"]);
    expect(a.says).toContain("waits for a person: anyone signed out could read pack records");
    expect(a.says).toBe(`${a.repo}#${a.number} is approved and waits for a person to merge it.`);
    expect(a.says.length).toBeLessThan(80);
  });
  test("an event 29 minutes ago does not fire", () => {
@@ -92,7 +92,15 @@
async function terminal(): Promise<string> {
/** The builders tile's anchor on home. */
const tile = (page: string): string => /<a class="stat" href="[^"]*"[^>]*><span class="stat-label">Builders running.*?<\/a>/s.exec(page)?.[0] ?? "";
/** The repository's map as the API answers it: what home's "nothing ready" must agree with. */
async function mapReady(): Promise<number> {
  const res = await fetch(`${servers.url}/api/v1/repos/alice/engine/map`, { headers: { cookie: `forge_session=${createSession(app.db, admin.id).token}` } });
  expect(res.status).toBe(200);
  return ((await res.json()) as { ready: unknown[] }).ready.length;
}
test("nothing ready: the map has nothing a builder may start", async () => {
  expect(await mapReady()).toBe(0);
  const page = await home();
  expect(tile(page)).toContain("nothing ready");
  expect(tile(page)).toContain('href="/map"');
@@ -102,6 +110,7 @@
test("nothing ready: the map has nothing a builder may start", async () => {
test("a ready issue and a builder with room: no reason is named", async () => {
  const opened = openIssue(app, admin, repo, { title: "Renderer" });
  if (!opened.ok) throw new Error(String(opened.error));
  expect(await mapReady()).toBeGreaterThan(0);
  const page = await home();
  expect(tile(page)).not.toContain("nothing ready");
  expect(tile(page)).toContain("running now");
@@ -191,3 +200,37 @@
test("a cached reason is dropped when the counts change: one of two slots runnin
  reason = null;
  expect(cachedKpis(app.db, now, forge).builders).toEqual({ running: 1, slots: 2, idle: null });
});
test("slots shown are the crew's concurrency, not the sum of the repositories' ceilings (#10440)", async () => {
  const wide = await updateRepoSettings(app, admin, repo, { autonomy: "autonomous", autonomyDirection: "Build.", autonomyCeilingUsd: 10, autonomySlots: 16, autonomyBy: admin.id });
  expect(wide.ok).toBe(true);
      
        junipercrew
        1d ago
        outdated
      
      Raw SQL built by interpolating the id into a string. Use bound parameters, like the repo's other tests. The test also leaves 'crew.concurrency' at 40 on failure, so use try/finally or afterEach cleanup so a failing assertion does not poison later tests.
    
  const set = (v: string) =>
    app.db.query("INSERT OR REPLACE INTO forge_setting (key, value, updated_by, updated_at) VALUES ('crew.concurrency', ?1, ?2, datetime('now'))").run(v, admin.id);
  try {
    set("4");
    const page = await home();
    expect(tile(page)).toMatch(/>\d of 4</);
    expect(tile(page)).not.toContain("of 16");
    expect(kpiLines(readKpis(app.db, new Date()), null).find((l) => l.startsWith("Builders running"))).toMatch(/Builders running \d of 4/);
    // Never more than the repositories offer.
    set("40");
    expect(readKpis(app.db, new Date()).builders.slots).toBe(16);
  } finally {
    app.db.query("DELETE FROM forge_setting WHERE key = 'crew.concurrency'").run();
  }
});
test("the slots figure is crew.concurrency on home and in the terminal, and the running figure is the runs' own count (#10440)", async () => {
  const wide = await updateRepoSettings(app, admin, repo, { autonomy: "autonomous", autonomyDirection: "Build.", autonomyCeilingUsd: 10, autonomySlots: 16, autonomyBy: admin.id });
  expect(wide.ok).toBe(true);
  try {
    app.db.query("INSERT OR REPLACE INTO forge_setting (key, value, updated_by, updated_at) VALUES ('crew.concurrency', '3', ?1, datetime('now'))").run(admin.id);
    const running = app.db.query<{ n: number }, []>("SELECT COUNT(*) AS n FROM run WHERE kind = 'agent' AND state = 'running'").get()!.n;
    const text = await terminal();
    expect(text).toContain(`Builders running ${running} of 3`);
    expect(text).not.toContain("of 16");
    expect(tile(await home())).toContain(`${running} of 3`);
  } finally {
    app.db.query("DELETE FROM forge_setting WHERE key = 'crew.concurrency'").run();
  }
});
@@ -25,7 +25,7 @@
afterAll(async () => {
  await rm(dataDir, { recursive: true, force: true });
});
test("home renders the eleven tiles; only an admin sees them", async () => {
test("home renders the eight tiles; only an admin sees them", async () => {
  const mk = async (username: string, first = false): Promise<User> => {
    const r = await createUser(app.db, {
      origin: "seed",
@@ -60,7 +60,7 @@
test("home renders the eleven tiles; only an admin sees them", async () => {
  view(yesterday, "z", 400, 160);
  const a = await home(admin);
  expect(a).toContain('class="stats kpi-row mb"');
  expect((a.match(/class="stat"/g) ?? []).length).toBe(11);
  expect((a.match(/class="stat"/g) ?? []).length).toBe(8);
  for (const href of ["/board", "/releases", "/boards", "/settings/crew", "/settings/backups"]) expect(a).toContain(`class="stat" href="${href}"`);
  // The tiles are §5 stats (#3982): none of the page-local kpi classes is left on home.
  for (const name of ["kpis", "kpi", "kpi-value", "kpi-note", "kpi-spark"]) expect(a).not.toMatch(new RegExp(`class="[^"]*\\b${name}\\b(?!-)`));
@@ -68,16 +68,12 @@
test("home renders the eleven tiles; only an admin sees them", async () => {
  // 2 accounts, the admin alone with a session today; visitors 3 today and 4 over 7 days;
  // load p75 of [100,200,300,400,1900] is 400 ms, INP p75 of [40,80,120,160] is 120 ms.
  expect(a).toContain(">1 of 2<");
  expect(a).toContain(">3 today<");
  expect(a).toContain(">4 in 7 days<");
  expect(a).toContain(">400 ms<");
  expect(a).toContain(">reacts in 120 ms<");
  expect((a.match(/class="stat" href="\/boards\/reach"/g) ?? []).length).toBe(3);
  expect((a.match(/class="stat" href="\/boards\/reach"/g) ?? []).length).toBe(1);
  // The figures count every repository, so a non-admin sees none.
  expect(a).toContain("no forge ceiling");
  expect(a).toContain("last 30 days");
  expect(await home(bob)).not.toContain('class="stats kpi-row mb"');
  expect(await home(bob)).not.toContain("last 30 days");
  expect(await home()).not.toContain('class="stats kpi-row mb"');
@@ -256,8 +256,10 @@
describe("the reach tiles", () => {
  test("say what they count in words, each linking to the reach board", () => {
    const reach = { usersToday: 3, usersTotal: 12, visitorsToday: 5, visitors7d: 31, visitorDays: new Array<number>(30).fill(0), loadP75: 1250, inpP75: 180 };
    const out = kpiRowFor({ landedHours: hours(0), landed: 0, live: null, backupAt: null, reach, medianCheckMs: null, builders: { running: 0, slots: 0, idle: null }, spend: { todayUsd: 0, ceilingUsd: null } }, null).toString();
    for (const v of ["5 today", "31 in 7 days", "3 of 12", "seen today", "1.3 s", "reacts in 180 ms"]) expect(out).toContain(`>${v}<`);
    expect((out.match(/class="stat" href="\/boards\/reach"/g) ?? []).length).toBe(3);
    for (const v of ["1.3 s", "reacts in 180 ms"]) expect(out).toContain(`>${v}<`);
    // Reporting browsers and Accounts feed no decision: only the page speed stays (#10440).
    for (const gone of ["Reporting browsers", "Accounts", "Traffic"]) expect(out).not.toContain(gone);
    expect((out.match(/class="stat" href="\/boards\/reach"/g) ?? []).length).toBe(1);
    expect(out).not.toContain("INP");
    expect(out).not.toContain("p75");
  });
@@ -289,10 +291,6 @@
describe("the visitors sparkline", () => {
    expect(r.visitorDays[29]).toBe(2);
    expect(r.visitorDays[0]).toBe(1); // 2026-09-20 is 29 days back; 09-19 is out
    expect(r.visitorDays.reduce((a, b) => a + b, 0)).toBe(3);
      
        junipercrew
        1d ago
        
      
      The sparkline test that asserted 30 points and the reach link was deleted instead of moved. The reach computation (visitorDays) is still tested, but nothing renders it now. That is more evidence the spark is dead; remove it together with the test.
    
    const out = kpiRowFor({ landedHours: hours(0), landed: 0, live: null, backupAt: null, reach: r, medianCheckMs: null, builders: { running: 0, slots: 0, idle: null }, spend: { todayUsd: 0, ceilingUsd: null } }, null).toString();
    const svg = /<svg[^>]*last 30 days[^>]*><polyline points="([^"]+)"/.exec(out)!;
    expect(svg[1]!.split(" ")).toHaveLength(30);
    expect(out).toContain('href="/boards/reach"');
  });
});
@@ -145,8 +145,8 @@
describe("home kpi row titles", () => {
  });
  test("no value or note lacks a title, and none brings back a git word", () => {
    expect(full.match(/class="stat-(value num|note)"/g)).toHaveLength(18);
    expect(full.match(/class="stat-(value num|note)" title=/g)).toHaveLength(18);
    expect(full.match(/class="stat-(value num|note)"/g)).toHaveLength(14);
    expect(full.match(/class="stat-(value num|note)" title=/g)).toHaveLength(14);
    expect(full).not.toMatch(/commit|merge|branch|repositor|pull request/i);
  });
});
@@ -129,11 +129,12 @@
describe("idleReason", () => {
    expect(idleReason(app, new Date())?.word).toBe("ceiling reached");
  });
  test("an issue the dispatcher holds is not ready: a run in flight on the only one says nothing ready", () => {
  test("an issue the dispatcher holds is not ready: a run in flight on the only one says none startable, not nothing ready", () => {
    const only = open("Held by a run");
    const run = createRun(app.db, { repoId: repo.id, kind: "agent", actorId: bot.id, reason: "review", issueId: only.id });
    set("UPDATE run SET state = 'running' WHERE id = ?1", run.id);
    expect(idleReason(app, NOW)).toEqual({ word: "nothing ready", href: "/map" });
    // The map still lists it as ready: "nothing ready" would be false.
    expect(idleReason(app, NOW)).toEqual({ word: "none startable", href: "/map" });
  });
  test("the line says the word and the link", () => {
@@ -6,7 +6,7 @@
 */
import { describe, expect, test } from "bun:test";
import { daySpark, sparkline, visitorsSpark } from "../src/web/studio/kpi_row.ts";
import { daySpark, sparkline } from "../src/web/studio/kpi_row.ts";
const LINE = 'fill="none" stroke="currentColor" stroke-width="1.5"';
@@ -49,12 +49,6 @@
describe("daySpark", () => {
});
describe("the numbers-only sparklines are unchanged", () => {
  test("visitorsSpark", () => {
    expect(visitorsSpark([0, 2, 4]).toString()).toBe(
      `<svg viewBox="0 0 96 24" width="96" height="24" role="img" aria-label="Distinct visitors each day over the last 3 days"><polyline points="0.0,22.0 48.0,12.0 96.0,2.0" ${LINE}/></svg>`,
    );
  });
  test("sparkline, newest first in, oldest on the left", () => {
    expect(sparkline([2, 0]).toString()).toBe(
      `<svg viewBox="0 0 96 24" width="96" height="24" role="img" aria-label="Shipped each hour over the last 24 hours"><polyline points="0.0,22.0 96.0,2.0" ${LINE}/></svg>`,
@@ -0,0 +1,19 @@
import { expect, test } from "bun:test";
import { shortTitle, TITLE_MAX } from "../src/flow/moving.ts";
test("a title that fits is whole; a long one is cut at a word, never mid-word", () => {
  expect(shortTitle("Fix the build")).toBe("Fix the build");
  const long = "Sentinel: release was degraded 180 minutes today: Release 0.7.495 is unproven: https://example.test did not answer";
  const cut = shortTitle(long);
  expect(cut.length).toBeLessThanOrEqual(TITLE_MAX + 1);
  expect(cut.endsWith("…")).toBe(true);
  expect(long.startsWith(cut.slice(0, -1))).toBe(true);
  expect(long[cut.length - 1]).toBe(" ");
});
test("one long unbroken token is cut at the limit, and whitespace collapses first", () => {
  const token = "x".repeat(200);
  expect(shortTitle(token)).toBe(`${"x".repeat(TITLE_MAX)}…`);
  expect(shortTitle("a   b \n c")).toBe("a b c");
  expect(shortTitle(`word ${token}`)).toBe(`word ${"x".repeat(TITLE_MAX - 5)}…`);
});
@@ -206,16 +206,15 @@
test("the tile says plainly when strangers hold most of the time, and not for a
  expect(trafficWords(t).note).toContain("too much");
  expect(trafficWords(t).title).toStartWith("Something is wrong");
  const row = String(kpiRowFor(emptyKpis(), null, NOW, t));
  expect(row).toMatch(
    /<a class="stat" href="\/settings\/traffic" data-tone="attn"/,
  );
  // The home row no longer carries a Traffic tile; the board at /settings/traffic does.
  expect(row).not.toContain("/settings/traffic");
  const handful = createPerfRecord();
  handful.add("/a", sample(5000, { deepStranger: true }));
  expect(trafficAttention(handful.ledger.totals(END))).toBeNull();
  expect(
    String(kpiRowFor(emptyKpis(), null, NOW, handful.ledger.totals(END))),
  ).not.toMatch(/traffic" data-tone="attn"/);
  ).not.toContain("/settings/traffic");
  expect(trafficValue(createPerfRecord().ledger.totals(END))).toBe("—");
});
@@ -290,13 +289,18 @@
test("every tile's value equals the probe's, from known requests and page_vital
  for (const n of probe.numbers) {
    expect(n.counts.length).toBeGreaterThan(10);
    expect([n.id, n.agrees, n.recomputed]).toEqual([n.id, true, n.value]);
    // These figures are the probe's and the boards', no longer tiles on the home row.
    if (["traffic", "visitors", "users", "accounts"].includes(n.id)) {
      expect([n.id, tiles.has(n.label)]).toEqual([n.id, false]);
      continue;
    }
    const shown = tiles.get(n.label);
    expect([n.label, n.id === "live" ? shown !== undefined : shown]).toEqual([
      n.label,
      n.id === "live" ? true : n.value,
    ]);
  }
  expect(tiles.size).toBe(probe.numbers.length);
  expect(tiles.size).toBe(probe.numbers.length - 3);
  // The live tile's short form is the start of the probe's full id.
  expect(byId.get("live")!.value.startsWith(tiles.get("Live version")!)).toBe(
    true,
@@ -171,3 +171,13 @@
describe("efficiency", () => {
    expect(efficiencyWords({ landings: 0, runs: 2, costUsd: 4 })).toContain("Nothing has landed");
  });
});
describe("the pace words (#10440)", () => {
  test("`Behind pace` only when less is used than the time gone; otherwise it says what is true", () => {
    // base: 84 h of 168 left, so half the week is gone.
    expect(used(20, { burnPctPerHour: 0 }).sentence).toContain("Behind pace");
    const heavy = used(70, { burnPctPerHour: 0 });
    expect(heavy.sentence).not.toContain("Behind pace");
    expect(heavy.sentence).toContain("Under the allowed burn");
  });
});
		@@ -17,3 +17,12 @@ The feed — the composer, the timeline, what is on you, since you were here —
17	17	Left out on purpose: the waiting-on-you line, the clog, vitals and keeper lines (the boards and the Flow dialog still show them), and "slowest right now" (it needs a timing read the home does not have). The box posts to `/tell` today; it becomes the `/talk` entry (#7652) when that lands.
18	18
19	19	The two scans behind the lists are read once per write (`writeStamp`), so a warm home reads no tables for them.
	20
	21	## The figures tell the truth (#10440)
	22
	23	- Slots in "Builders running" are `crew.concurrency` (`crewConcurrency` in `src/flow/slot_cap.ts`), or the repositories' slots when those are fewer: the sum of the repositories' slots is a ceiling, not a limit. Home and the terminal read the same figure.
	24	- "Nothing ready" is said only when the repository's map has nothing ready (`/api/v1/repos/:owner/:name/map`); `test/home-builders-idle.test.ts` checks home against that answer.
	25	- Pace line: "Behind pace" only when the used percent is below the elapsed percent; otherwise "Under the allowed burn".
	26	- Just shipped titles are cut at a word (`shortTitle`); the row's hover and screen-reader title carry the whole one.
	27	- Dropped on purpose (the issue named them: no decision uses them): the Traffic, Reporting browsers and Accounts tiles. The same numbers stay on `/settings/traffic`, `/boards/reach` and the KPI probe.
	28	- A stuck approved pull is one line ("… waits for a person to merge it."); the wall it hit is on the pull.
		@@ -19,7 +19,7 @@ import { standings } from "../core/standing.ts";
19	19	import { grantedAccounts } from "../core/subscriptions.ts";
20	20	import { slottedRuns, spentToday } from "./autonomy.ts";
21	21	import { atCeiling } from "./dispatch.ts";
22		import { heldNow } from "./held.ts";
	22	import { heldNow, HOLDS } from "./held.ts";
23	23	import { pace } from "./pacing.ts";
24	24
25	25	export interface IdleReason {
		@@ -54,7 +54,10 @@ export function idleReason(app: App, now: Date): IdleReason \| null {
54	54	}
55	55
56	56	const held = heldNow(app, repo);
57		return held.startable.length === 0 ? { word: "nothing ready", href: "/map" } : null;
	57	if (held.startable.length > 0) return null;
	58	// "Nothing ready" is true only when the map's ready list is empty; otherwise the ready issues are all held.
	59	const ready = HOLDS.reduce((n, h) => n + held.by[h].length, 0);
	60	return { word: ready === 0 ? "nothing ready" : "none startable", href: "/map" };
58	61	}
59	62	return null;
60	63	}
		@@ -149,6 +149,7 @@ export function weekDecision(input: WeekInput): WeekDecision \| null {
149	149	? `under a point over the last ${WEEK.burnHours} h (the meter moves in whole points and the crew ran)`
150	150	: `${pct(burn)} an hour over the last ${WEEK.burnHours} h`;
151	151	// `full`: the free percent and run-out time are said here; otherwise the crew line above says them.
	152	const behindLabel = used < (1 - left / WINDOW_MS.week) * 100 ? "Behind pace" : "Under the allowed burn";
152	153	const say = (full: boolean): string => {
153	154	const weekLeft = full ? `${Math.round(meter.freePct)}% of the week left with ${timeGone}` : `the week has ${timeGone}`;
154	155	const runOut = full && runsOutAt !== null ? `, running out about ${utc(runsOutAt)}` : "";
		@@ -158,7 +159,7 @@ export function weekDecision(input: WeekInput): WeekDecision \| null {
158	159	? `On pace: ${weekLeft}; burning ${burnWords}, ${pct(allowed)} is allowed.`
159	160	: status === "ahead"
160	161	? `Ahead of pace: ${weekLeft}, burning ${burnWords} against ${pct(allowed)} allowed${runOut}; ${slots === 0 ? "holding the crew for the reset" : `slowing to ${slots} of ${ceiling} slots`}.`
		junipercrew 1d ago outdated The label is chosen by an inline ternary inside a template string, and it recomputes elapsed time with `(1 - left / WINDOW_MS.week) * 100` where `say` already knows the pace. Compute `const label = ...` once above and reuse it. The line is now unreadable.
161		: `Behind pace: ${weekLeft}, burning ${burnWords} against ${pct(allowed)} allowed; ${slots === 0 ? "holding the crew for the reset" : `speeding up to ${slots} of ${ceiling} slots`}${release ? " and releasing the next issue" : ""}.`;
	162	: `${behindLabel}: ${weekLeft}, burning ${burnWords} against ${pct(allowed)} allowed; ${slots === 0 ? "holding the crew for the reset" : `speeding up to ${slots} of ${ceiling} slots`}${release ? " and releasing the next issue" : ""}.`;
162	163	};
163	164	return { status, targetPctPerHour, allowedPctPerHour: allowed, runsOutAt, slots, release, sentence: say(true), besideCrewLine: say(false) };
164	165	}
		@@ -140,7 +140,7 @@ export function alarmStuck(from: App \| Database, now: Date, scope: StuckScope =
140	140	repo,
141	141	number,
142	142	wall,
143		says: `${repo}#${number} is approved and waits for a person: ${wall.join("; ")}. Allow it (merge) or send it back.`,
	143	says: `${repo}#${number} is approved and waits for a person to merge it.`,
144	144	};
145	145	return {
146	146	fired: true,
		@@ -19,6 +19,7 @@
19	19	import { backupVerdict, isWatched, type BackupVerdict } from "../snapshot/bucket.ts";
20	20	import { lastDrill } from "../snapshot/drills.ts";
21	21	import type { Database } from "bun:sqlite";
	22	import { crewConcurrency, shownSlots } from "./slot_cap.ts";
22	23	import { spentTodayEverywhere } from "../crew/autonomy.ts";
23	24	import { ceilingHitAt, ceilingReached } from "./ceiling.ts";
24	25	import type { IdleReason } from "../crew/idle_reason.ts";
		@@ -78,7 +79,8 @@ export function readBuilders(db: Database, idle: IdleReason \| null = null): Kpis
78	79	(SELECT COALESCE(SUM(autonomy_slots), 0) FROM repo WHERE autonomy != 'off') AS slots`,
79	80	)
80	81	.get() ?? { running: 0, slots: 0 };
81		return { ...counts, idle };
	82	const slots = shownSlots(counts.slots, crewConcurrency(db));
		junipercrew 1d ago outdated Hand-rolled IIFE with a try/catch that swallows every error and returns NaN. Catching 'no settings table' this way hides real failures. Read the value through one named helper that returns a number or null, with no exception for control flow. Put the min in `buildersValue` or a small module, not inline in the reader.
	83	return { ...counts, slots, idle };
82	84	}
83	85
84	86	/**
		@@ -15,6 +15,8 @@ import type { PipelineStage } from "./pipeline.ts";
15	15	export interface MovingRow {
16	16	readonly who: string;
17	17	readonly title: string;
	18	/** The title whole, for a hover or a screen reader: cutting `title` loses nothing. */
	19	readonly full: string;
18	20	readonly href: string;
19	21	readonly at: string;
20	22	/** `owner/name`, for the row's title attribute. */
		@@ -22,6 +24,18 @@ export interface MovingRow {
22	24	}
23	25
24	26	export const MOVING_ROWS = 3;
	27	/** Longest title a home row shows. */
	28	export const TITLE_MAX = 60;
	29
	30	/** A title cut at a word boundary, with an ellipsis; whole when it fits. */
	31	export function shortTitle(title: string, max = TITLE_MAX): string {
	32	const t = title.replace(/\s+/g, " ").trim();
	33	if (t.length <= max) return t;
	34	const cut = t.slice(0, max);
	35	const at = cut.lastIndexOf(" ");
		junipercrew 1d ago outdated The regex strips a trailing `-`, `–`, `.`, `:` before the ellipsis, but when the cut is mid-word with no space past max/2 it still chops mid-word. The test only covers the happy path. Add cases for a long unbroken token and for whitespace-only collapse. Also keep full titles reachable (`title` attribute) so cutting loses nothing for a screen reader or a hover.
	36	// One long unbroken token has no boundary to cut at: it is cut at the limit.
	37	return `${(at > max / 2 ? cut.slice(0, at) : cut).replace(/[\s:,;.\-–]+$/, "")}…`;
	38	}
25	39	/** Rows read before the viewer's access filters them; bounded, so the read is. */
26	40	const SCAN = 40;
27	41
		@@ -66,7 +80,8 @@ function visible(db: Database, viewer: User, raw: readonly Raw[], path: string,
66	80	if (repo === undefined) continue;
67	81	out.push({
68	82	who: r.who ?? "",
69		title: r.title,
	83	title: shortTitle(r.title),
	84	full: r.title.replace(/\s+/g, " ").trim(),
70	85	href: `/${repo.ownerName}/${repo.name}/${r.kind === undefined ? path : r.kind === "pull" ? "pulls" : "issues"}/${r.number}`,
71	86	at: r.at,
72	87	repo: `${repo.ownerName}/${repo.name}`,
		@@ -0,0 +1,19 @@
	1	/**
	2	* How many builders the crew may run at once, as home and the terminal say it:
	3	* the repositories' slots add up to a ceiling, `crew.concurrency` is the limit.
	4	*/
	5	import type { Database } from "bun:sqlite";
	6	import { capacityValue } from "../core/capacity.ts";
	7
	8	/** The crew's concurrency now, or null when the setting holds no positive whole number. */
	9	export function crewConcurrency(db: Database): number \| null {
	10	// A database that never had settings (a bare fixture) has no limit to read.
	11	if (db.query("SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'forge_setting'").get() === null) return null;
	12	const n = Number(capacityValue(db, "crew.concurrency"));
	13	return Number.isInteger(n) && n > 0 ? n : null;
	14	}
	15
	16	/** The slots to show: the repositories' sum, never more than the crew runs at once. */
	17	export function shownSlots(sum: number, cap: number \| null): number {
	18	return cap === null ? sum : Math.min(sum, cap);
	19	}
		@@ -11,7 +11,7 @@
11	11	*/
12	12
13	13	import type { Database } from "bun:sqlite";
14		import { KPI_COUNTS, backupFull, backupOverdue, backupValue, buildersValue, checkTime, reactNote, shippedValue, speedWords, spendCeilingWords, spendFull, spendValue, trafficValue, trafficWords, usersValue, visitorsNote, visitorsValue, waitingWords } from "../../flow/kpi_words.ts";
	14	import { KPI_COUNTS, backupFull, backupOverdue, backupValue, buildersValue, checkTime, reactNote, shippedValue, speedWords, spendCeilingWords, spendFull, spendValue, waitingWords } from "../../flow/kpi_words.ts";
15	15	import { perfRecord } from "../../perf/live.ts";
16	16	import type { TrafficClass, TrafficMinute, TrafficTotals } from "../../perf/traffic.ts";
17	17	import type { IdleReason } from "../../crew/idle_reason.ts";
		@@ -80,11 +80,6 @@ export function sparkline(hours: readonly number[]): Html {
80	80	return spark([...hours].reverse(), "Shipped each hour over the last 24 hours");
81	81	}
82	82
83		/** Distinct visitors per day, oldest first, today on the right. */
84		export function visitorsSpark(days: readonly number[]): Html {
85		return spark(days, `Distinct visitors each day over the last ${days.length} days`);
86		}
87
88	83	/** Lightest first, stacked from the bottom: the strangers sit on top and read darkest. */
89	84	export const TRAFFIC_TONES: readonly (readonly [TrafficClass, string])[] = [
90	85	["internal", "0.12"],
		@@ -124,7 +119,6 @@ export function kpiRowFor(k: Kpis, live: { sha: string; at: string } \| null, now
124	119	const overdue = k.backup ? k.backup.state === "red" : backupOverdue(k.backupAt, now);
125	120	const spendWords = spendCeilingWords(k.spend);
126	121	const rate = shippedValue(k.landed, k.landedHours.length);
127		const trafficSays = traffic === null ? null : trafficWords(traffic);
128	122	return html`<section class="stats kpi-row mb" aria-label="The forge's figures, each over its own window; hover one for what it counts">
129	123	${tile(
130	124	"Shipped per hour",
		@@ -189,18 +183,6 @@ export function kpiRowFor(k: Kpis, live: { sha: string; at: string } \| null, now
189	183	null,
190	184	k.bugs.overdue > 0 ? "attn" : null,
191	185	)}
192		${traffic === null \|\| trafficSays === null ? null : tile(
193		"Traffic, 15 min",
194		"/settings/traffic",
195		trafficValue(traffic),
196		`${traffic.requests} requests, ${traffic.refused} refused`,
197		trafficSays.note,
198		trafficSays.title,
199		trafficColumns(traffic.minutes, W, H, "Answering time each minute over the last 15 minutes, by who asked"),
200		trafficSays.attn ? "attn" : null,
201		)}
202		${tile("Reporting browsers", "/boards/reach", visitorsValue(k.reach), `${visitorsValue(k.reach)}, ${visitorsNote(k.reach)}`, visitorsNote(k.reach), KPI_COUNTS.visitors, visitorsSpark(k.reach.visitorDays))}
		junipercrew 1d ago Dead code: `visitorsSpark` has no caller once the Reporting browsers tile is gone. Remove it, and any now-unused import.
203		${tile("Accounts", "/boards/reach", usersValue(k.reach), usersValue(k.reach), "seen today", KPI_COUNTS.accounts)}
204	186	${tile(
205	187	"Reported page speed",
206	188	"/boards/reach",
		@@ -59,7 +59,7 @@ function listOf(label: string, rows: readonly MovingRow[], empty: string, headin
59	59	row({
60	60	href: r.href,
61	61	...(r.who === "" ? {} : { lead: html`<span class="muted small">${r.who}</span>` }),
62		title: html`<span class="truncate" title="${r.repo}">${r.title}</span>`,
	62	title: html`<span class="truncate" title="${r.repo}: ${r.full}">${r.title}</span>`,
63	63	trail: html`<span class="muted small">${timeAgo(r.at)}</span>`,
64	64	}),
65	65	);
		@@ -99,7 +99,8 @@ describe("alarmStuck", () => {
99	99	wall("h");
100	100	const a = alarmStuck(app, NOW);
101	101	expect(a.wall).toEqual(["anyone signed out could read pack records"]);
102		expect(a.says).toContain("waits for a person: anyone signed out could read pack records");
	102	expect(a.says).toBe(`${a.repo}#${a.number} is approved and waits for a person to merge it.`);
	103	expect(a.says.length).toBeLessThan(80);
103	104	});
104	105
105	106	test("an event 29 minutes ago does not fire", () => {