Public: anyone can read this; the crew can change it.
The backups list is keyboard-first: j/k move between rows, enter opens one #10642
Check · Review · Land · Live done — Landed and live in production.
mason/forge:mason/10428-the-backups-list-is-keyboard-first-j-k-m → main 1 commit fork
2 files
changed +62
−0
src/web/pages/backups.ts +1
| @@ -388,6 +388,7 @@ async function movingPart( | ||
| 388 | 388 | ${snapshots.map((m) => |
| 389 | 389 | row({ |
| 390 | 390 | lead: icon("download"), |
| 391 | nav: true, | |
| 391 | 392 | title: m.name, |
| 392 | 393 | meta: html`${time(m.finishedAt)} · forge ${m.version} · |
| 393 | 394 | ${m.repos === 1 ? "one repository" : `${m.repos} repositories`}, |
test/keys-backups.test.ts added +61
| @@ -0,0 +1,61 @@ | ||
| 1 | /** The backups list joins the shell's j/k row traversal: one data-nav per snapshot row, none on the empty list. */ | |
| 2 | import { afterAll, beforeAll, expect, test } from "bun:test"; | |
| 3 | import { mkdtempSync, rmSync } from "node:fs"; | |
| 4 | import { tmpdir } from "node:os"; | |
| 5 | import { join } from "node:path"; | |
| 6 | import { createApp, type App } from "../src/app.ts"; | |
| 7 | import { createUser } from "../src/core/users.ts"; | |
| 8 | import { serve, type Servers } from "../src/http/server.ts"; | |
| 9 | import { startSnapshots, type SnapshotsHandle } from "../src/snapshot/service.ts"; | |
| 10 | import { dirStore } from "../src/snapshot/store.ts"; | |
| 11 | import { quietLogs } from "./helpers/globals.ts"; | |
| 12 | ||
| 13 | quietLogs(); | |
| 14 | ||
| 15 | let root = ""; | |
| 16 | let app: App; | |
| 17 | let svc: SnapshotsHandle; | |
| 18 | let servers: Servers; | |
| 19 | let cookie = ""; | |
| 20 | ||
| 21 | beforeAll(async () => { | |
| 22 | root = mkdtempSync(join(tmpdir(), "forge-keys-backups-")); | |
| 23 | app = createApp({ dataDir: root, port: 0 }); | |
| 24 | const u = await createUser(app.db, { | |
| 25 | origin: "seed", trusted: true, username: "alice", email: "[email protected]", | |
| 26 | password: "a-good-passphrase", adminIfFirst: true, | |
| 27 | }); | |
| 28 | if (!u.ok) throw new Error(u.error); | |
| 29 | svc = startSnapshots(app, dirStore(join(root, "store")), { version: "t", nightly: false }); | |
| 30 | servers = await serve(app); | |
| 31 | const r = await fetch(`${servers.url}/signin`, { | |
| 32 | method: "POST", | |
| 33 | headers: { origin: servers.url }, | |
| 34 | body: new URLSearchParams({ username: "alice", password: "a-good-passphrase" }), | |
| 35 | redirect: "manual", | |
| 36 | }); | |
| 37 | cookie = (r.headers.get("set-cookie") ?? "").split(";")[0]!; | |
| 38 | }, 60_000); | |
| 39 | ||
| 40 | afterAll(async () => { | |
| 41 | servers.stop(); | |
| 42 | await svc.stop(); | |
| 43 | app.close(); | |
| 44 | rmSync(root, { recursive: true, force: true }); | |
| 45 | }); | |
| 46 | ||
| 47 | const page = async () => (await fetch(`${servers.url}/settings/backups`, { headers: { cookie } })).text(); | |
| 48 | const NAV = /class="row"[^>]*data-nav tabindex="-1"/g; | |
| 49 | ||
| 50 | test("with no snapshot yet the list draws no data-nav row", async () => { | |
| 51 | const text = await page(); | |
| 52 | expect(text).toContain("None yet"); | |
| 53 | expect(text).not.toMatch(NAV); | |
| 54 | }); | |
| 55 | ||
| 56 | test("each snapshot row is one data-nav row", async () => { | |
| 57 | await svc.now(); | |
| 58 | const text = await page(); | |
| 59 | const list = text.slice(text.indexOf('id="snapshots"')); | |
| 60 | expect(list.slice(0, list.indexOf("</ul>")).match(NAV)?.length).toBe(1); | |
| 61 | }); |