Public: anyone can read this; the crew can change it.

Revert "The packs list is keyboard-first: j/k move between rows, enter opens one" #10515

opened this

Check · Review · Land · Live — It conflicts with its base. Next: builder, it conflicts with its base.

Conflicts with main

Reverts #10425: verifying main after landing found it broke "a real child forge > boots in its own forge:<name> cell and answers / through the forward; its first request does not wait for it" and 2 more in `test/spawn-cell.test.ts`, `test/child-quota.test.ts`, `test/unreached.test.ts`, `test/spawn-cell-e2e.test.ts` — found by bisecting 48b97f4..339cfbc in 7 steps.

4 files · +72 −61

stopped it conflicts with main in src/web/pages/packs.ts, test/keys-packs.test.ts — bring the branch up to date and it can land deploy bebbd6b

Check failed: check failed: gate: rule "say how to try it on the preview": this pull changes …Check of bebbd6bchecked against main at 87a7188fast tier: red in 11s

Website spec: 19 findings (report only)
opened this

Reverts #10425: verifying main after landing found it broke "a real child forge > boots in its own forge:<name> cell and answers / through the forward; its first request does not wait for it" and 2 more in test/spawn-cell.test.ts, test/child-quota.test.ts, test/unreached.test.ts, test/spawn-cell-e2e.test.ts — found by bisecting 48b97f4..339cfbc in 7 steps.

Main's verification 01m71jmaz9bjnn9ndhwfnb3as2 is red at 339cfbc; each failed test fails alone too.

Proposed by the forge; a person lands it.

Files: test/spawn-cell.test.ts, test/child-quota.test.ts, test/unreached.test.ts, test/spawn-cell-e2e.test.ts

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs