Public: anyone can read this; the crew can change it.

The accounts list is keyboard-first: j/k move between rows, enter opens one #10501

Parked opened this
Closed without merging

Every row on the accounts list now joins the existing j/k traversal, so the owner can walk the list without the mouse. The new test, bun scripts/design-lint.ts, bun x tsc --noEmit and bun scripts/gate.ts pass.

Notes

stopped parked by the crew deploy b095d58

opened this

Every row on the accounts list now joins the existing j/k traversal, so the owner can walk the list without the mouse. The new test, bun scripts/design-lint.ts, bun x tsc --noEmit and bun scripts/gate.ts pass. I did not run the rest of the suite or try it in a browser; the forge's check runs the full suite on this push.

What changed

  • personRow in src/web/pages/accounts.ts now passes nav: true, so each account row carries data-nav tabindex="-1". There is no new component class and no new script. Readers without JavaScript see the same page, with one inert attribute added per row.
  • test/keys-accounts.test.ts seeds an admin and two other accounts, fetches /settings/accounts, and asserts all three rows carry the nav marker. It would fail without the change, because no row has the marker today.

What I left out

  • Enter target: the row stays a <div>, so enter follows the row's first link, which is the person's profile. I did not add a link to the sign-ins page, because the profile link is already inside the row and nesting links is invalid HTML.
  • Gate: scripts/gate.ts doesn't list test/keys-waves.test.ts, so I didn't list the new test there either.
  • Docs: docs/features/hotkey-hints.md is unchanged, since the hint text is the same.

To try it: sign in as an admin, open /settings/accounts, press j/k to move between rows, then enter to open the focused account's profile.

The push was refused until a commit message carried a "Try:" line, so the branch has an extra empty commit for that.

Closes #10430

3 earlier comments · 1 event
commented

Every row on the accounts list now joins the existing j/k traversal, so the owner can walk the list without the mouse. The new test, bun scripts/design-lint.ts, bun x tsc --noEmit and bun scripts/gate.ts pass. I did not run the rest of the suite or try it in a browser; the forge's check runs the full suite on this push.

What changed

  • personRow in src/web/pages/accounts.ts now passes nav: true, so each account row carries data-nav tabindex="-1". There is no new component class and no new script. Readers without JavaScript see the same page, with one inert attribute added per row.
  • test/keys-accounts.test.ts seeds an admin and two other accounts, fetches /settings/accounts, and asserts all three rows carry the nav marker. It would fail without the change, because no row has the marker today.

What I left out

  • Enter target: the row stays a <div>, so enter follows the row's first link, which is the person's profile. I did not add a link to the sign-ins page, because the profile link is already inside the row and nesting links is invalid HTML.
  • Gate: scripts/gate.ts doesn't list test/keys-waves.test.ts, so I didn't list the new test there either.
  • Docs: docs/features/hotkey-hints.md is unchanged, since the hint text is the same.

To try it: sign in as an admin, open /settings/accounts, press j/k to move between rows, then enter to open the focused account's profile.

The push was refused until a commit message carried a "Try:" line, so the branch has an extra empty commit for that.

commented

I changed nothing for this one, because the log you pasted shows the preview running and I found no failure in it.

  • Deploy status: the log opens with "running at https://lab--10501--forge-trevato-apps.open-platform.sh · no tests declared, none run". The lines after it are routine periodic output (process counts, SQL statement summaries), with no error or crash.
  • "No tests declared": the app block in forge.json has no test command, so the deploy runs none and says so. That is how the repository is set up and isn't caused by my change. The tests belong to the check block, which the forge runs separately on each push. I ran test/keys-accounts.test.ts locally and it passes. The gate script and the type check also pass.
  • Possible cause of the failed state: if the deploy is marked failed, the likely reason is that it counts "no tests declared" as a failure. That would be a forge-side setting, and I can't change it from here.
  • Check verdict: no check log has come back to me for this push. If one fails, send me its log and I'll fix it.

I didn't push again, because there is nothing new to push.

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

The accounts list now has keyboard navigation: j/k move between rows and enter opens one. This push fixes two of the seven failing tests. The other five I left alone.

What I fixed

  • scripts/unreached-allow.json: I removed the entry for src/kernel/why_now.ts. That file no longer exists, and the test "an allowed module that has become reached leaves the list" fails while the entry is there.
  • test/child-quota.test.ts: "room for small but not large is refused only for large" set the memory limit to 2000 MiB, but about 2048 MiB was already held on the machine. That made the refusal read as "small would pass the limit". I raised the limit to 4096 MiB so the test no longer depends on how much memory is held. The test was wrong here, not the code.

On the base branch, both tests fail without these two edits and pass with them. The gate and tsc --noEmit were clean before the push.

What I didn't touch

  • Shell-sandbox tests: three in shard 50, and one in shard 54 ("the member actor … from a crew shell").
  • Storage-quota test: the "a mirror bigger than the limit is allowed in" failure in shard 51.

All five are in code my change doesn't reach. I can't run the sandbox suites here (the sandbox blocks them), so I haven't confirmed whether they fail on main or only on the check machine. If they come back red, the new check log will say.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs