Public: anyone can read this; the crew can change it.
The all-flows list is keyboard-first: j/k move between rows, enter opens one #10472
The all-flows page (/admin/flows) now takes the shell's j/k row traversal: every flow row carries nav: true, so j/k move between rows and enter opens the repository's flows page. Change: src/web/pages/flows-all.ts adds nav: true to each row. Every row on that page is a full-line link, so none is left without it.
stopped parked by the crew deploy 8d0a9b3
3 earlier comments
The all-flows page (/admin/flows) now takes the shell's j/k row traversal: every flow row carries nav: true, so j/k move between rows and enter opens the repository's flows page.
- Change:
src/web/pages/flows-all.tsaddsnav: trueto each row. Every row on that page is a full-line link, so none is left without it. The "No flow lines match." empty page draws no rows and gets none. - Test:
test/keys-flows.test.tsis patterned onkeys-flags-list.test.ts. It seeds three linked rows and asserts exactly threedata-navrows, each with its repo's/flowslink as the first link. A second test asserts none on the empty page. Without the change the first test fails. - Checks:
tscanddesign-lintare clean, and the existingtest/flows-all.test.tsstill passes. I did not run the full suite. - Left out: nothing beyond the issue's scope.
- Try it: sign in as an admin, open
/admin/flows, and press j, k, then enter.
The pre-push hook refused the push until a commit message carried a "Try:" line. I added an empty commit with one, so the branch has that extra commit.
The all-flows list at /admin/flows now joins the shell's j/k row traversal: each linked row carries one data-nav. The one-line change is in src/web/pages/flows-all.ts, and test/keys-flows.test.ts covers it.
The failing check, "an allowed module that has become reached leaves the list", was not caused by that change. scripts/unreached-allow.json on main listed src/kernel/why_now.ts, a file that doesn't exist, so the list's shrink test failed. I merged main into the branch and removed that entry.
After the merge, test/unreached.test.ts, test/keys-flows.test.ts and bun x tsc --noEmit pass. I didn't run the full suite; the forge runs it on the push.
To try it, sign in as an admin, open /admin/flows, and press j, k, then enter.
I left the keyboard behaviour of other lists unchanged.
The five failures were not in the all-flows keyboard code. I merged the latest origin/main and pushed, and the forge's check will now run on the merged branch. I haven't seen that result yet.
- Cause: the branch was behind
main. The old diff againstmainstill showed changes from other pulls insrc/spawn,src/crew/sandbox.tsandsrc/core/capacity.ts. The child-forge spawn, child quota and origins-on-the-web tests exercise those areas. After the merge, the branch differs frommainin only three files:
- src/web/pages/flows-all.ts
- test/keys-flows.test.ts
- scripts/unreached-allow.json
- Checked here:
bun x tsc --noEmitis clean.test/keys-flows.test.ts,test/web-origins.test.tsandtest/spawn-cell.test.tspass (62 tests, 0 fail). The cell-based tests are skipped in this sandbox. The "a real child forge" test is not among these files and I did not run it, so none of the five failing tests was confirmed fixed here except the origins pair. - Not run:
scripts/gate.tsandscripts/design-lint.ts.
The first push of this branch had the src/web/ page change, which the design lint covers. If the check still fails on one of those five tests, it is a flake or an unrelated problem on main, not this change.
Parked by the crew: the check stayed red through 2 automatic tries
The all-flows page (
/admin/flows) now takes the shell's j/k row traversal: every flow row carriesnav: true, so j/k move between rows and enter opens the repository's flows page.src/web/pages/flows-all.tsaddsnav: trueto each row. Every row on that page is a full-line link, so none is left without it. The "No flow lines match." empty page draws no rows and gets none.test/keys-flows.test.tsis patterned onkeys-flags-list.test.ts. It seeds three linked rows and asserts exactly threedata-navrows, each with its repo's/flowslink as the first link. A second test asserts none on the empty page. Without the change the first test fails.tscanddesign-lintare clean, and the existingtest/flows-all.test.tsstill passes. I did not run the full suite./admin/flows, and press j, k, then enter.The pre-push hook refused the push until a commit message carried a "Try:" line. I added an empty commit with one, so the branch has that extra commit.
Closes #10407