Public: anyone can read this; the crew can change it.

The origins list is keyboard-first: j/k move between rows, enter opens one #10436

Parked opened this
Closed without merging

The frozen-mirror rows on the origins page now join the shell's j/k row traversal, and the change is pushed. test/keys-origins.test.ts passes (2 tests), tsc --noEmit is clean, and design-lint reports nothing outside the system. I didn't run scripts/gate.ts or the wider suite; the forge runs the full check on push.

Notes

stopped parked by the crew

opened this

The frozen-mirror rows on the origins page now join the shell's j/k row traversal, and the change is pushed. test/keys-origins.test.ts passes (2 tests), tsc --noEmit is clean, and design-lint reports nothing outside the system. I didn't run scripts/gate.ts or the wider suite; the forge runs the full check on push.

What changed

  • src/web/pages/origins.ts: the rows in the "Frozen mirrors" list now carry nav: true. They are the only rows on the page whose whole line is a link, each going to /<owner>/<repo>#frozen.
  • test/keys-origins.test.ts (new, patterned on the flags test):

- It seeds two frozen mirrors and checks there is one data-nav row per mirror, each with its link. - It checks that a user with no frozen mirrors gets no origin data-nav rows. - With the origins.ts change reverted, the first test fails.

What I left out

  • The connected-account cards and the three "connect" fold rows get no nav. They have no href — the cards hold buttons and forms, the folds are toggles — so Enter would do nothing on them. This matches the issue's rule that unlinked rows carry none.
  • The empty-page check counts rows against a signed-in baseline instead of asserting zero, because the settings sidebar's own data-nav rows are on the page too.

Try it

  1. Open /settings/origins with a mirror whose origin is gone.
  2. Press j or k to move between the frozen-mirror rows, then Enter to open one.

Closes #10405

3 earlier comments
commented

The frozen-mirror rows on the origins page now join the shell's j/k row traversal, and the change is pushed. test/keys-origins.test.ts passes (2 tests), tsc --noEmit is clean, and design-lint reports nothing outside the system. I didn't run scripts/gate.ts or the wider suite; the forge runs the full check on push.

What changed

  • src/web/pages/origins.ts: the rows in the "Frozen mirrors" list now carry nav: true. They are the only rows on the page whose whole line is a link, each going to /<owner>/<repo>#frozen.
  • test/keys-origins.test.ts (new, patterned on the flags test):

- It seeds two frozen mirrors and checks there is one data-nav row per mirror, each with its link. - It checks that a user with no frozen mirrors gets no origin data-nav rows. - With the origins.ts change reverted, the first test fails.

What I left out

  • The connected-account cards and the three "connect" fold rows get no nav. They have no href — the cards hold buttons and forms, the folds are toggles — so Enter would do nothing on them. This matches the issue's rule that unlinked rows carry none.
  • The empty-page check counts rows against a signed-in baseline instead of asserting zero, because the settings sidebar's own data-nav rows are on the page too.

Try it

  1. Open /settings/origins with a mirror whose origin is gone.
  2. Press j or k to move between the frozen-mirror rows, then Enter to open one.
commented

Origins: frozen mirror rows now join the j/k row traversal. I changed nothing in this round, so there is nothing new to push.

The preview deploy log you sent shows no error from this app. It ends with the forge draining on SIGTERM (forge draining: /readyz answers 503 … why=SIGTERM), which is the forge itself restarting. The "no tests declared, none run" note is about the preview deploy, not a failing test.

I re-ran the checks locally on the pushed head (674dd31d6). All pass:

  • bun scripts/gate.ts
  • bun x tsc --noEmit
  • bun test test/keys-origins.test.ts (2 pass, 0 fail)
  • bun scripts/design-lint.ts

The change is one line in src/web/pages/origins.ts, plus the test in test/keys-origins.test.ts.

To try it: open /settings/origins, connect an account whose mirrors are frozen, press j, then Enter.

I did not touch any other keys or the layout.

commented

Frozen mirror rows on /settings/origins now join the j/k/enter row traversal like the other origin rows. The change is one line, nav: true on the frozen card's row in src/web/pages/origins.ts. A new test in test/keys-origins.test.ts fails without it.

The failing "every module under src/ is imported by another, or allowed" check passes here, on this branch before the merge and after it. I couldn't reproduce the failure. My change adds no module and changes no import, so I suspect it came from branch state that has since moved. I merged origin/main (13 new commits) into the branch and pushed; the forge's full check on that push will show whether it's gone.

What I ran after the merge: test/unreached.test.ts and test/keys-origins.test.ts pass, and bun x tsc --noEmit is clean. I did not run the full suite or the sharded run locally.

To try it, open /settings/origins with an account whose mirrors are frozen, press j, then enter.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs