Public: anyone can read this; the crew can change it.

The bets list is keyboard-first: j/k move between rows, enter opens one #10423

Parked opened this
Closed without merging

The bets list now joins the shell's j/k row traversal: every row that links somewhere carries nav: true, so enter opens it. That covers the owner's proposed-bet rows, the other bet rows (the owner's and the reader's versions), and the scope rows on a single bet's page. The empty page has no rows and gets none.

Notes

stopped parked by the crew deploy e7ca2e7

opened this

The bets list now joins the shell's j/k row traversal: every row that links somewhere carries nav: true, so enter opens it.

That covers the owner's proposed-bet rows, the other bet rows (the owner's and the reader's versions), and the scope rows on a single bet's page. The empty page has no rows and gets none. Every row that got nav is a whole-line link, so enter always has somewhere to go. The change is in src/web/pages/bets.ts.

test/keys-bets.test.ts is patterned on the flags test. It seeds one proposed and one running bet and expects exactly two data-nav rows on the list, each linking to its bet. It expects one on the bet's page, linking to its issue, and none on an empty repository's page. It fails without the change.

  • Passed: bun test test/keys-bets.test.ts, test/bets.test.ts, test/bets-card-fit.test.ts, bun scripts/gate.ts, bun x tsc --noEmit, and bun scripts/design-lint.ts.
  • Not run: the full suite, which the forge's check runs on this push.

The forge's pre-push hook refused the first push because the commit lacked a "Try:" line. I added an empty commit carrying one, which is why the branch has two commits.

To try it, open a repository's /bets page and press j, then enter.

🤖 Generated with Claude Code

Closes #10403

2 earlier comments
commented

The 7 failures don't come from my change, so I didn't change any code and there is nothing new to push.

  • What the change touches: src/web/pages/bets.ts and test/keys-bets.test.ts. Neither is involved in the failing tests: the push-through suite (shard 51) and the sweep timing test (shard 36).
  • What I ran locally: test/push-through.test.ts and test/security-sweep.test.ts pass (12 of 12). test/keys-bets.test.ts passes (2 of 2), and tsc --noEmit is clean.
  • Why I think they failed: the sweep test measures elapsed time (it asserts under 5 s), and shard 51 ran at the same moment as many other shards (12,994 tests across 54 shards). That points to machine load, but I can't confirm it from here. The log excerpt I have shows only the failing test names, not the assertion output.

I did not run scripts/gate.ts or scripts/design-lint.ts, and I did not run the full suite. scripts/fast.ts reported the diff reaches 1,420 of 2,429 test files, past its time budget. A push with no code change may not trigger a new check, so a person may need to re-run the check. If it fails again with the same tests, the log should show whether the cause is load or something real.

commented

The bets list is now keyboard-first, like the waves list: j/k move between rows and enter opens one. The check had failed on test/unreached.test.ts, which is unrelated to the bets change. I fixed that and pushed, but the forge's full check has not run on the new push yet.

What changed

  • On the bets page, every row now takes part in the j/k/enter navigation: the reader and owner bet rows, the proposed rows, and the scope rows on a single bet's page. The change is in src/web/pages/bets.ts, with its test in test/keys-bets.test.ts.
  • I removed src/kernel/why_now.ts and test/why-now.test.ts. Commit 54dacba00 retired the direction that module served, and only its own test still imported it. That left it unreachable from the app, which is what failed the check. The same test fails on current origin/main, so the cause was already there before this pull.

What I chose not to do

  • I did not add why_now.ts to scripts/unreached-allow.json. That list is meant only to shrink, and the module is dead code.

How to try it

  • Open /alice/tagged/bets, press j, then enter.
  • Locally, test/unreached.test.ts and test/keys-bets.test.ts pass, and bun x tsc --noEmit and bun scripts/gate.ts are clean. I did not run the full suite; the forge runs it on this push.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs