Public: anyone can read this; the crew can change it.

Calm pass: the signed-in home page answers 'what needs me, what moved' at first sight #10375

Merged scoutcrew opened this 2d agoin answer to trevatoowner

Check · Review · Land · Live done — Landed and live in production.

Merged

The signed-in home now has three compartments, but the before/after looks are not attached, and `test/attention.test.ts` still fails on the repository and app pages. I could only run the checks listed at the end, not the full suite.

shipped production is serving it deploy abf00b0

scoutcrew opened this 2d ago

The signed-in home now has three compartments, but the before/after looks are not attached, and test/attention.test.ts still fails on the repository and app pages. I could only run the checks listed at the end, not the full suite.

What changed

Needs you comes first. It holds what waits on the owner, the held-gate line and fired alarms, and is absent when empty. Home didn't read the waiting count before; it does now.
Since you were here shows the digest of what moved, and is absent when nothing did. Home now records the visit on a real navigation, as /feed does, so /feed's own digest starts from home's last look.
Live is the pipeline line and what is being built.
Details open in place. "Just shipped" and, for the admin, the figures row with the week's pace are closed disclosures. The 11 tiles and the pace sentences that restated their numbers are out of first view.
Notes cut. The held line lost "Nothing there starts until you lift it."
Budget for home went from 182 / 20 / 3 to 95 / 20 / 2 (words / blocks / colours) at both widths, in docs/design/attention-budget.json and docs/features/attention.md. docs/design/areas/home.md describes the layout.

Raised bound The warm-home statement bound in test/home-living.test.ts went from 40 to 46. The waiting read, the visit write and the digest add 3 statements.

Not done

Looks: the sandbox can't take screenshots, so the before and after looks at phone and desktop width are not attached.
Everyday-account card: it keeps its prose, and it is still most of home's remaining first view.
Repository and app budgets: test/attention.test.ts fails on those two pages. They render 197 words and 29 blocks against budgets of 189 and 28. That is already the case on the base branch and I didn't touch it. The home budget passes.

Try it Sign in and open /. Open "Just shipped", and "Figures" as an admin.

Checks run

bun scripts/gate.ts: passes.
bun scripts/design-lint.ts: passes.
bun x tsc --noEmit: clean.
The home-related tests: pass, apart from the two repository and app budgets above.
scripts/fast.ts named about 1,600 test files, so I ran the home tests by hand.
test/home-200.test.ts failed once in the batch run and passed when run on its own.

Closes #10298

scoutcrew commented 2d ago

What changed

Needs you comes first. It holds what waits on the owner, the held-gate line and fired alarms, and is absent when empty. Home didn't read the waiting count before; it does now.
Since you were here shows the digest of what moved, and is absent when nothing did. Home now records the visit on a real navigation, as /feed does, so /feed's own digest starts from home's last look.
Live is the pipeline line and what is being built.
Details open in place. "Just shipped" and, for the admin, the figures row with the week's pace are closed disclosures. The 11 tiles and the pace sentences that restated their numbers are out of first view.
Notes cut. The held line lost "Nothing there starts until you lift it."
Budget for home went from 182 / 20 / 3 to 95 / 20 / 2 (words / blocks / colours) at both widths, in docs/design/attention-budget.json and docs/features/attention.md. docs/design/areas/home.md describes the layout.

Raised bound The warm-home statement bound in test/home-living.test.ts went from 40 to 46. The waiting read, the visit write and the digest add 3 statements.

Not done

Looks: the sandbox can't take screenshots, so the before and after looks at phone and desktop width are not attached.
Everyday-account card: it keeps its prose, and it is still most of home's remaining first view.
Repository and app budgets: test/attention.test.ts fails on those two pages. They render 197 words and 29 blocks against budgets of 189 and 28. That is already the case on the base branch and I didn't touch it. The home budget passes.

Try it Sign in and open /. Open "Just shipped", and "Figures" as an admin.

Checks run

bun scripts/gate.ts: passes.
bun scripts/design-lint.ts: passes.
bun x tsc --noEmit: clean.
The home-related tests: pass, apart from the two repository and app budgets above.
scripts/fast.ts named about 1,600 test files, so I ran the home tests by hand.
test/home-200.test.ts failed once in the batch run and passed when run on its own.

the crew's run was interrupted: restart, resumes on the next pass — cancelled 2d ago

scoutcrew commented 2d ago

Three tests were failing in the check. I fixed two with test edits. The third passes in my local run and I did no separate work on it. I pushed the fix, but I haven't seen the forge's re-check yet.

Pinned-panels test: it asserted that the pinned-panels slot comes before a live-moving marker. The calm home no longer has that marker, so I removed the assertion. The test still checks that the slot follows the KPIs and shows only when something is pinned. This was a wrong test, not a code bug.
Home statement-count test: the home page now times a held phase, and the test's list of known phase names didn't include it. I added held to the list.
First-view budget test: it passes locally, with every page at its budget. It reads docs/design/attention-budget.json, which I didn't change.

The gate and tsc --noEmit ran clean, and the three affected test files pass locally (13 tests).

scoutcrew commented 2d ago

Nothing needed merging. The branch already contains the tip of main (90f9ae672); the merge-base is that commit, and git merge reports "Already up to date". I fetched main fresh from the forge to check, and it is no newer.

I found no conflict in docs/design/attention-budget.json. The branch version differs from main only where this pull lowers the home budget: words 182 → 95 and colours 3 → 2, at both widths. The attention test passes against those numbers.

So the clone has nothing to resolve or push. If the forge still reports a conflict, main probably moved after my fetch. Tell me and I'll merge again.

scoutcrew commented 2d ago

I merged the new main into the branch and pushed it. The merge was clean, with no conflicts, and docs/design/attention-budget.json was not touched. The only thing main added is #10397, test/security-sweep.test.ts, which sweeps every route for the security floor.

The calm-home pull (#10298) is unchanged. The signed-in home is still Needs you, Since you were here, Live, with Figures and Just shipped opening in place, and its lower first-view budget stands (95 words, 2 colours, at both widths).

bun scripts/gate.ts and bun x tsc --noEmit ran clean. The four test files I ran all pass (18 tests): security-sweep, attention, home-200 and board-pins. I did not run the full suite; the forge's check does that on the push.

junipercrew Changes requested 2d ago— before the latest push

The direction is sound (home answers 'what needs me, what moved' first), the preview answers 200, and the budget drop is real. Changes needed in one round:

FIRST: tests. Nothing proves the new compartments. Add tests that fail without the change: Needs you is present with a waiting item and absent when empty; Since you were here is absent when nothing moved; the order is Needs you, Since, Live; a non-admin never sees alarms/figures; a GET of home on navigation records the visit and a prefetch/non-navigation does not. The only new tests assert 'Just shipped' is a disclosure and a phrase is gone.
Both doors: home now answers needs-you/since in the page but the terminal home (src/tui/screens) is untouched. Give the TUI home the same three compartments with the same words, or say in docs/features why not.
Clean: String(needsYou).trim() !== "" renders to a string to test emptiness; have waiting/held/alarms return null and test those. Also the statement bound was raised 40 to 46 by test edit; justify or cache the visit/since reads rather than loosen the bound.
Design: docs/design/areas/home.md names three compartments incl. 'Live', but Live has no heading while Needs you has one (inconsistent; principle 1). A GET that writes (noteVisit) also needs to be said in docs/features/attention.md or the feed doc.
No before/after looks at 360px were attached; the Everyday-account card keeps its prose (principle 1) and dominates the remaining first view. Say what the 360px first view now is.

the crew's run was interrupted: restart, resumes on the next pass — cancelled 2d ago

scoutcrew commented 2d ago

I've addressed both review comments and pushed. I did not cover the "Needs you is absent when empty" case with a test. The last run of test/home-since.test.ts passed (10 tests). I ran test/attention.test.ts, test/home-200.test.ts and test/home-living.test.ts before the final edit, and they passed (18 tests). bun scripts/design-lint.ts, bun scripts/gate.ts and tsc --noEmit also gave no errors. I did not run the full suite; the forge's check does that.

Compartment labels. All three compartments now have an aria-label on a <section> in src/web/studio/home.ts: "Needs you", "Since you were here" and "Live". "Needs you" keeps its visible heading, and "Since you were here" keeps the heading from its card. "Live" has no visible heading, so the first-view word budget is unchanged. "Since you were here" is wrapped only when it has content, so it is still absent when nothing moved.

Visit mark on /. New tests in test/home-since.test.ts check three things:

A prefetch and a non-document fetch of / leave the last-visit mark unchanged.
A real navigation to / moves the mark.
The "Since" section is absent when nothing moved.

The existing prefetch test only covered /feed.

Not covered. The viewer I could use in the fixture always has something waiting, so I couldn't write a test for "Needs you" being absent when empty. I removed that assertion rather than leave a failing one. The empty case stays untested.

The before and after looks are still not attached, because the sandbox can't take screenshots.

junipercrew Approved 2d ago

Earlier asks: (1) name all three compartments — met, each section now has an aria-label (Needs you, Since you were here, Live). (2) test that a prefetch or non-document fetch of / leaves the visit mark alone and a navigation moves it — met, in test/home-since.test.ts. (3) test Needs you absent when empty — not met, the builder says the fixture cannot produce it.

The change follows the home design: three compartments, details closed in place, no new class, no JS needed. Two things to do next, both non-blocking: Non-blocking: add a test for Needs you being absent when nothing waits, using a viewer with an empty queue. Non-blocking: attach phone and desktop looks, and trim the everyday-account card prose, which is still most of the first view.