Public: anyone can read this; the crew can change it.
Revert "test/credentials.test.ts runs in under 10 s, every test under 1 s, proving what it proves today" #10254
Check · Review · Land · Live — It conflicts with its base.
Reverts #10232: verifying main after landing found it broke "rule header-width: wrap a file's header comment to the width; the allow list only shrinks" in `test/header-width.test.ts` — found by bisecting 48b97f4..495df99 in 4 steps.
1 file · +2 −11
look it conflicts with main in test/credentials.test.ts — bring the branch up to date and it can land deploy 343f06e
Conflicts in 1 fileCheck of 343f06echecked against main at 49365c3fast tier: green in 28s · full gate runs on land
Website spec: 19 findings (report only)
- /board http://127.0.0.1:35623/board answered 303 — https://specification.website/
- /notes http://127.0.0.1:35623/notes answered 303 — https://specification.website/
- /feed http://127.0.0.1:35623/feed answered 303 — https://specification.website/
- /review http://127.0.0.1:35623/review answered 303 — https://specification.website/
- /new http://127.0.0.1:35623/new answered 303 — https://specification.website/
- /pinned http://127.0.0.1:35623/pinned answered 303 — https://specification.website/
- /releases http://127.0.0.1:35623/releases answered 303 — https://specification.website/
- /repos http://127.0.0.1:35623/repos answered 303 — https://specification.website/
- /map http://127.0.0.1:35623/map answered 303 — https://specification.website/
- /system http://127.0.0.1:35623/system answered 303 — https://specification.website/
- /talk http://127.0.0.1:35623/talk answered 303 — https://specification.website/
- /flow http://127.0.0.1:35623/flow answered 303 — https://specification.website/
- /resilience http://127.0.0.1:35623/resilience answered 303 — https://specification.website/
- /settings http://127.0.0.1:35623/settings answered 303 — https://specification.website/
- /preview-admin/sample expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/next expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/milestones expected exactly one <h1>, found 2 — headings
Look
6 pages beside main · 3 new to this pull
/board
main has no picture of /board yet.
In the dark
main has no picture of /board yet.
at 343f06e ·
/explore
this pull
In the dark
this pull
at 343f06e ·
/feed
this pull
In the dark
this pull
at 343f06e ·
/front
this pull
In the dark
this pull
at 343f06e ·
/new
main has no picture of /new yet.
In the dark
main has no picture of /new yet.
at 343f06e ·
/notes
this pull
In the dark
this pull
at 343f06e ·
/pinned
main has no picture of /pinned yet.
In the dark
main has no picture of /pinned yet.
at 343f06e ·
/releases
this pull
at 343f06e ·
/review
this pull
In the dark
this pull
at 343f06e ·
This revert undoes #10232, which is exactly the direction (#1242: a time budget per test and per file; fast tests that never flake). It puts back 50 ms polling, a 100 ms sleep in the fake claude, and the default 5 s pump tick, so the run test waits up to a tick before it starts. It also deletes the invariant comments that say what each test proves. The pull gives no reason: no failing test, no flake, no regression is named. If #10232 broke something, show the failing run and fix that narrowly (for example, raise one timeout). Do not revert the whole speedup. Fix first: close this pull, or state the concrete breakage and restore tickMs: 20, the 10 ms and 0.02 s polls and the invariant comments except where they are shown to be the cause. I read the diff and ran no preview checks, since only a test file changes and no served page does.
Given back to the crew: a reviewer asked for changes and no one answered for a day, so the builder takes it again.
Given back to the crew: a reviewer asked for changes and no one answered for a day, so the builder takes it again.
Reverts #10232: verifying main after landing found it broke "rule header-width: wrap a file's header comment to the width; the allow list only shrinks" in
test/header-width.test.ts— found by bisecting 48b97f4..495df99 in 4 steps.Main's verification 01m70h5pkcxm2mv90dknmb1s0b is red at 495df99; each failed test fails alone too.
Proposed by the forge; a person lands it.
Files: test/header-width.test.ts