A pull's looks say which phone pages scroll sideways, to its crew, without showing the owner's picture #10210

GET /api/v1/repos/:owner/:name/pulls/:number/looks now answers { items, fit }, so a builder can see which pages scroll sideways on a 390 px phone without the owner's picture. I ran the type check, scripts/gate.ts and the two pull-looks test files (all pass). I did not run the full suite; the forge's check does that.

What changed

• fit: it has one entry per page and width that has a stored size, from the pull's latest commit. Each entry is { page, width, scrollWidth, innerWidth, screens, sideways }. screens is scrollHeight / innerHeight to one decimal, and sideways is scrollWidth > innerWidth.
• Owner looks: looks taken as the owner are included, as numbers only. There is no url or picture, and any reader of the pull gets them.
• Sealed pulls: a sealed pull's fit is empty unless the reader is a writer, the same rule as its pictures.
• Code: pullFit is in src/looks/readable.ts, and the GET route in src/http/api.ts calls it. It costs one query and uses no browser.
• Docs: docs/features/pull-looks.md names the field.
• Existing test: test/pull-looks.test.ts expected the no-app answer to be exactly { items: [] }. It now expects { items: [], fit: [] }; that change was needed, not a mistake in the test.

Tests The new test/pull-looks-fit.test.ts covers three things:

• An owner-taken phone look 520 px wide appears in fit for a non-writer, with sideways: true and no url.
• A look without a size is absent.
• A sealed pull's fit is empty for a non-writer and filled for a writer.

I did not run it against the unchanged code to confirm each case fails without the change.

What I chose

• "Latest commit": I took this to mean the commit of the newest look that has no error, light theme only.
• Sealed access: I used the existing owner-facts rule for sealed pulls (writers only), not the sealed-issue rule that also admits crew. So a crew agent who is not a writer gets an empty fit on a sealed pull. I couldn't test the API route for a sealed pull, because that pull answers 404 to a non-writer before fit is reached. The sealed case calls pullFit directly.
• Left out: dark-theme looks, and fit on the MCP pull tool and the terminal. The issue asked only for the API route.

To try it Open GET …/pulls/N/looks on a pull whose preview has been looked at. fit appears beside items.

Closes #9386

GET /api/v1/repos/:owner/:name/pulls/:number/looks now answers { items, fit }, so a builder can see which pages scroll sideways on a 390 px phone without the owner's picture. I ran the type check, scripts/gate.ts and the two pull-looks test files (all pass). I did not run the full suite; the forge's check does that.

What changed

• fit: it has one entry per page and width that has a stored size, from the pull's latest commit. Each entry is { page, width, scrollWidth, innerWidth, screens, sideways }. screens is scrollHeight / innerHeight to one decimal, and sideways is scrollWidth > innerWidth.
• Owner looks: looks taken as the owner are included, as numbers only. There is no url or picture, and any reader of the pull gets them.
• Sealed pulls: a sealed pull's fit is empty unless the reader is a writer, the same rule as its pictures.
• Code: pullFit is in src/looks/readable.ts, and the GET route in src/http/api.ts calls it. It costs one query and uses no browser.
• Docs: docs/features/pull-looks.md names the field.
• Existing test: test/pull-looks.test.ts expected the no-app answer to be exactly { items: [] }. It now expects { items: [], fit: [] }; that change was needed, not a mistake in the test.

Tests The new test/pull-looks-fit.test.ts covers three things:

• An owner-taken phone look 520 px wide appears in fit for a non-writer, with sideways: true and no url.
• A look without a size is absent.
• A sealed pull's fit is empty for a non-writer and filled for a writer.

I did not run it against the unchanged code to confirm each case fails without the change.

What I chose

• "Latest commit": I took this to mean the commit of the newest look that has no error, light theme only.
• Sealed access: I used the existing owner-facts rule for sealed pulls (writers only), not the sealed-issue rule that also admits crew. So a crew agent who is not a writer gets an empty fit on a sealed pull. I couldn't test the API route for a sealed pull, because that pull answers 404 to a non-writer before fit is reached. The sealed case calls pullFit directly.
• Left out: dark-theme looks, and fit on the MCP pull tool and the terminal. The issue asked only for the API route.

To try it Open GET …/pulls/N/looks on a pull whose preview has been looked at. fit appears beside items.

The pull's looks route now answers fit beside items, so a builder can see which pages scroll sideways on a 390 px phone without the owner's picture. The check failed because no commit had a "Try:" line for src/http/api.ts. I added an empty commit with one and pushed. scripts/gate.ts now passes locally. I didn't re-run the tests, since the code didn't change.

What changed

• fit: GET /api/v1/repos/:owner/:name/pulls/:number/looks returns fit for the pull's latest commit. It has one { page, width, scrollWidth, innerWidth, screens, sideways } entry per page and width that has a stored size.
• Owner looks: looks taken as the owner are included, as numbers only. There is no url or picture, and any reader of the pull gets them.
• Sealed pulls: a sealed pull's fit is empty unless the reader is a writer, the same rule as its pictures.
• Code and docs: pullFit is in src/looks/readable.ts, and the GET route in src/http/api.ts calls it. docs/features/pull-looks.md names the field.
• Tests: the new test/pull-looks-fit.test.ts covers an owner-taken sideways phone look, a look without a size being absent, and the sealed case. test/pull-looks.test.ts now expects { items: [], fit: [] } for a pull with no app; that was an expectation to update, not a bug in the test.

What I chose

• "Latest commit": I took this to be the commit of the newest look without an error, light theme only.
• Sealed access: I used the writers-only rule, so a crew agent who isn't a writer gets an empty fit on a sealed pull. The sealed case is tested by calling pullFit directly, because the API answers 404 to a non-writer before fit is reached.
• Left out: dark-theme looks, and fit on the MCP pull tool and the terminal.

To try it Call GET /api/v1/repos/<owner>/<name>/pulls/<number>/looks on the preview and read fit beside items.

pullFit now keeps only the newest look with a size per page and width, and I've pushed it to the branch. The type check and test/pull-looks-fit.test.ts pass; I didn't run the other test files.

One thing differs from your review. The new dedupe can't change the output today, because the look table won't hold two light looks of the same page and width on one commit. I tried inserting a second row directly and it was refused, and recordLook replaces the earlier row on a retake. So fit never had duplicate entries from retakes, and the old stale-size case couldn't happen. I kept the dedupe anyway as a guard.

I added two tests. A retake on the latest commit, first 900 px wide and then 390 px, gives one entry, the newer one. That entry has scrollWidth <= innerWidth, so sideways is false. The retake test passes even without the dedupe, because the table already folds retakes into one row.