Public: anyone can read this; the crew can change it.

The terminal's Adapter screen lists the last pull runs #10151

Closed opened this
Closed without merging

The terminal's Adapter screen now lists the last pull runs below its facts. bun scripts/gate.ts, bun x tsc --noEmit and test/adapter-tui.test.ts (5 tests) pass here. I didn't run the rest of the suite; the forge's check does that on push.

Notes

stopped closed without shipping deploy d76c038

opened this

The terminal's Adapter screen now lists the last pull runs below its facts.

bun scripts/gate.ts, bun x tsc --noEmit and test/adapter-tui.test.ts (5 tests) pass here. I didn't run the rest of the suite; the forge's check does that on push. I also didn't run the app or look at the screen in a terminal. I never called keep_plan, so the issue has no plan on it.

What changed

  • Run list: src/tui/screens/adapter.ts reads the runs through pullRunLines and draws them under a "Last pulls" heading, clipped to the width. Each line is the time, the state, "N written N skipped N failed", and a failed run's error.
  • Empty and overflow: with no runs it shows "No pulls yet.". j/k (and the other scroll keys) scroll the list when it overflows, and the key bar says so.
  • Gate: the runs are read only after the existing owner-facts check, so a guest or outsider gets no runs. The screen is drawn only once the facts have loaded, so it shows no runs for an app that declares no adapter.
  • Tests: test/adapter-tui.test.ts renders the screen with a good and a failed run, with none, and as an outsider. The tests pass the runs in directly through a new optional runsOf argument on adapterScreen, so they don't need the pull database.

What I left alone The API and the web page are untouched. There is no filter or refresh key on the list.

To try it Open a repository that has an app with an adapter, then choose "Adapter" from the palette.

🤖 Generated with Claude Code

Closes #10128

commented

The terminal's Adapter screen now lists the last pull runs below its facts.

bun scripts/gate.ts, bun x tsc --noEmit and test/adapter-tui.test.ts (5 tests) pass here. I didn't run the rest of the suite; the forge's check does that on push. I also didn't run the app or look at the screen in a terminal. I never called keep_plan, so the issue has no plan on it.

What changed

  • Run list: src/tui/screens/adapter.ts reads the runs through pullRunLines and draws them under a "Last pulls" heading, clipped to the width. Each line is the time, the state, "N written N skipped N failed", and a failed run's error.
  • Empty and overflow: with no runs it shows "No pulls yet.". j/k (and the other scroll keys) scroll the list when it overflows, and the key bar says so.
  • Gate: the runs are read only after the existing owner-facts check, so a guest or outsider gets no runs. The screen is drawn only once the facts have loaded, so it shows no runs for an app that declares no adapter.
  • Tests: test/adapter-tui.test.ts renders the screen with a good and a failed run, with none, and as an outsider. The tests pass the runs in directly through a new optional runsOf argument on adapterScreen, so they don't need the pull database.

What I left alone The API and the web page are untouched. There is no filter or refresh key on the list.

To try it Open a repository that has an app with an adapter, then choose "Adapter" from the palette.

🤖 Generated with Claude Code

commented

Declined: nothing to fix. The preview deploy you describe did not fail. Its log ends with ready:, serving and done: https://lab--10151--forge-trevato-apps.open-platform.sh, and the app booted and answered in 1.8s. "No tests declared, none run" is a note about the preview step, not an error. forge.json declares its tests in the check block, which the forge runs on the push. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m70054gb9wk25mc9rgv8eyx9

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs