Public: anyone can read this; the crew can change it.
An app page with the tell field has no sideways scroll at 390px, with a look on the pull #10114
Check · Review · Land · Live done — Landed and live in production.
This adds a measuring test for the app page's tell field. I couldn't run it here, so I haven't confirmed the checkbox about no sideways scroll, and I haven't seen the look at 390px myself.
shipped production is serving it deploy 9e8c29c
This adds a measuring test for the app page's tell field. I couldn't run it here, so I haven't confirmed the checkbox about no sideways scroll, and I haven't seen the look at 390px myself.
What changed
test/app-tell-fit.test.tsis new. It loads the seeded app's page (/preview-admin/hello) as the owner at 390×844 and at 1280×800, where the tell field shows. It asserts that:
- form.tell-box has its #tell input and a button;
- the form sits inside the viewport;
- scrollWidth <= clientWidth.
- It also checks that the preview's owner looks already take this page at desktop and phone.
What I found
- The app page already gets desktop and phone looks as the owner on every forge preview (#9782, #9797).
- The tell field is in the page for that owner, so the preview's phone look should show it.
- By reading the CSS, nothing should overflow:
.barwraps, and.tell-boxhasmin-width: 0andflex: 1 1 14rem. I changed no page code, since I found nothing to fix.
What I couldn't do
- This sandbox has no Chromium that starts. The measuring tests were skipped here, and the look image is taken by the forge on push, not by me.
bun scripts/design-lint.tsandbun x tsc --noEmitran clean. I ran only the new test file, which passes with the measuring tests skipped, not the fullbun test.- To confirm the checkbox, look at the preview's phone look of
/preview-admin/helloon this pull. If the preview's Chromium reports a sideways scroll, the new test fails there and shows the numbers.
To try it
Run bun test test/app-tell-fit.test.ts somewhere with Chromium.
Test-only pull; no code changed, so nothing could regress. Changes needed: (1) The measurement is never run where it counts: the builder had no Chromium, so the claim of no sideways scroll at 390px is unverified. Run it where Chromium starts, and put the measured numbers (scrollWidth, viewportWidth, tell-box rect) in the description. (2) The test silently skips and passes when no Chromium starts. In the forge check, make a missing Chromium fail instead of console.log+skip, or the guard can pass forever unmeasured. (3) The first test only re-asserts a constant list in preview-looks.ts; it is tautological, so drop it or assert against the real look capture. (4) Box 1 needs the phone look to actually be on the pull; show that the preview look of /preview-admin/hello at 390px exists and includes the tell field. Preview page itself answers 200.
Items 2 and 3 are fixed, but items 1 and 4 are not: nothing here has been measured at 390px. This sandbox has no Chromium that starts, so I can't produce scrollWidth, viewportWidth or the tell-box rect. I also can't confirm that the preview's phone look of /preview-admin/hello exists.
Fixed
- Missing Chromium (item 2):
test/app-tell-fit.test.tsnow adds a test that fails when no Chromium starts, unlessFORGE_TEST_SOCKETis set. That variable marks the agent sandbox; the forge's check doesn't set it. If the check image has no Chromium, this pull will go red instead of passing unmeasured. That is the honest verdict, but someone should know it is possible. - Tautological test (item 3): I dropped the test that restated the look list. It is replaced by one that fetches
/preview-admin/helloas the owner and asserts a 200. It also asserts the page carriesform.tell-boxposting to/telland#tell, and that a stranger's page has no#tell. It runs without Chromium and passes here. - Measured numbers: the measuring tests log
scrollWidth,viewportWidthand the tell-box rect asapp page look <name>: …, so the check log will show them once a browser runs.
Not done
- Measurement (item 1): nothing has been measured here, so no numbers go in this description. The first check log with a Chromium will have them.
- Look on the pull (item 4): the app page is already on the owner look list for desktop and phone, but I couldn't see the capture. The preview at
https://lab--10114--forge-trevato-apps.open-platform.sh/preview-admin/helloanswers 200 to an unauthenticated request. Whether the phone look exists and includes the field needs a person to look at the pull's looks.
Type check and design-lint are clean. I ran only this test file here, not the full bun test.
Test-only pull; the page code is unchanged. The test is reasonable, but the issue's boxes are not met at this head.
Change needed first: the 390px fit has never been measured. The builder had no Chromium, and the new measuring tests skip in the sandbox. Without a measurement and a look image showing the tell field, the pull cannot be called done. Get a run where Chromium starts and put the measured scrollWidth, viewportWidth and tell-box rect in the description. If that run shows an overflow, fix it in this pull (box 2 says so).
Also needed: the pull carries no look of its own. Box 1 asks for a look of the app page at 390px with the tell field showing. The builder's claim that the preview's owner looks already cover it is unverified. Show the phone look of /preview-admin/hello on this pull, or add it to the pull's looks.
Smaller: the guard that fails when no Chromium starts is fine, but say in the description that the forge check now fails if its image has no Chromium.
The preview answers 200 on /preview-admin/hello.
The check run on head 51a9f800 started Chromium and measured the owner's app page at /preview-admin/hello. The tell field shows and the page does not scroll sideways at 390 px or desk. The pull still has no look image: the preview deployed, but none was taken. That leaves the issue's first box open.
| Viewport | scrollWidth | viewportWidth | tell field present | tell-box rect (left / right / width) |
|---|---|---|---|---|
| Phone, 390×844 | 390 | 390 | yes | 16 / 374 / 358 |
| Desk, 1280×800 | 1280 | 1280 | yes | 104 / 832 / 728 |
At 390 px the form keeps 16 px clear on each side. Nothing overflows, so no page code changes in this pull.
What the pull adds
test/app-tell-fit.test.tsis the only file, and the check passed on this head.- Rendered page: it fetches
/preview-admin/helloas the owner and asserts a 200, theform.tell-boxposting to/tell, and#tell. A stranger's page has no#tell. This part runs without a browser. - Measured in Chromium: at 390×844 and 1280×800 it asserts the field and its button are there, the form sits inside the viewport, and
scrollWidth <= clientWidth. It logs the numbers to the check log asapp page look …. - Missing Chromium: the forge check now fails if no Chromium starts, instead of skipping and passing unmeasured. This run's measurements show the check image has a Chromium today. If a later image drops it, this test turns the check red. The agent sandbox has no browser, so there (where
FORGE_TEST_SOCKETis set) the browser tests are skipped.
The missing look
- On every forge preview the app page is meant to be pictured as the owner at desktop and phone, and the preview deploy for this head finished.
- Even so,
GET /pulls/10114/looksstill returned no items when I last checked. - I can't take or attach a picture myself, because the agent sandbox has no Chromium.
- Someone needs to look at why the look service took none for
pull-10114, or attach a 390 px picture by hand.
I changed no code in this round; it updates only this description.
🤖 Generated with Claude Code
Earlier asks: (1) measurement — met: the check on the prior head measured 390/390 scrollWidth/viewport, tell box 16–374 px, and the new docs/design/areas/tell.md paragraph records it. (2) missing Chromium fails in the forge check instead of skipping — met. (3) tautological looks-list test replaced by a real fetch of the owner page plus stranger check — met. (4) a look on the pull — not met: GET /pulls/10114/looks still returns no items. That is the look service, not something this test can produce. Since then only the docs paragraph was added; it is accurate and adds no class. Next, non-blocking: (a) find why the look service took no picture for pull-10114 and attach it; (b) the doc line says the owner looks picture the page, so reword it if that stays untrue on previews.
Left #10075 open: 1 unticked item remain (The pull carries a look of an app page at 390px, the tell field showing.).
This adds a measuring test for the app page's tell field. I couldn't run it here, so I haven't confirmed the checkbox about no sideways scroll, and I haven't seen the look at 390px myself.
What changed
test/app-tell-fit.test.tsis new. It loads the seeded app's page (/preview-admin/hello) as the owner at 390×844 and at 1280×800, where the tell field shows. It asserts that:-
form.tell-boxhas its#tellinput and a button; - the form sits inside the viewport; -scrollWidth <= clientWidth.What I found
.barwraps, and.tell-boxhasmin-width: 0andflex: 1 1 14rem. I changed no page code, since I found nothing to fix.What I couldn't do
bun scripts/design-lint.tsandbun x tsc --noEmitran clean. I ran only the new test file, which passes with the measuring tests skipped, not the fullbun test./preview-admin/helloon this pull. If the preview's Chromium reports a sideways scroll, the new test fails there and shows the numbers.To try it Run
bun test test/app-tell-fit.test.tssomewhere with Chromium.Closes #10075