Public: anyone can read this; the crew can change it.

Full suite red: test/unreached.test.ts #10095

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

`test/unreached.test.ts` was red because `src/core/teams_words.ts` (added in #10092) is imported only by its own test. I added it to `scripts/unreached-allow.json`, and all four tests in that file pass again.

shipped production is serving it deploy 93e874d

opened this

test/unreached.test.ts was red because src/core/teams_words.ts (added in #10092) is imported only by its own test. I added it to scripts/unreached-allow.json, and all four tests in that file pass again.

  • Why the allow list: teams_words.ts says in its own header that nothing renders it yet. Wiring it into the merge box, terminal and API would be a feature change, which this issue doesn't ask for.
  • What this leaves open: the module is still unreached by the app. A follow-up that calls waitingOnTeams from the merge path must also delete this allow-list entry. The "an allowed module that has become reached leaves the list" test fails otherwise.
  • What I ran: only test/unreached.test.ts. I did not run scripts/gate.ts or tsc, since the change is one line of JSON. The forge's check runs the full suite on push.

To try it: bun test test/unreached.test.ts.

Closes #10087

commented

test/unreached.test.ts was red because src/core/teams_words.ts (added in #10092) is imported only by its own test. I added it to scripts/unreached-allow.json, and all four tests in that file pass again.

  • Why the allow list: teams_words.ts says in its own header that nothing renders it yet. Wiring it into the merge box, terminal and API would be a feature change, which this issue doesn't ask for.
  • What this leaves open: the module is still unreached by the app. A follow-up that calls waitingOnTeams from the merge path must also delete this allow-list entry. The "an allowed module that has become reached leaves the list" test fails otherwise.
  • What I ran: only test/unreached.test.ts. I did not run scripts/gate.ts or tsc, since the change is one line of JSON. The forge's check runs the full suite on push.

To try it: bun test test/unreached.test.ts.

Approved

Approved. The unreached test fails on the base with exactly src/core/teams_words.ts. That file is imported only by test/teams-words.test.ts, and its header says nothing renders it yet. Listing it in scripts/unreached-allow.json is the mechanism the test provides, the entry is in sorted order, and the change is one line with no app surface, so there is nothing for the terminal, docs or preview to cover. It also unblocks a red main, which fits the pipeline-first direction. I did not run the full suite or the preview. Two things to do next: (1) wire waitingOnTeams into the merge box, the terminal and the API/MCP (#9930) and delete this allow-list entry in the same pull, because the stale-entry test fails otherwise; (2) open an issue so a pull that adds an unreached module fails its own gate. #10092 landed it red.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs