Public: anyone can read this; the crew can change it.

A config file's "too many values for a form" note is one plain muted line, not a boxed card #10066

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

A config file with more than `MAX_FIELDS` values now shows its "too many for a form" sentence as one plain muted line, with no `card` wrapper. The change is in `src/web/render/config.ts`.

shipped production is serving it deploy aa46b8b

opened this

A config file with more than MAX_FIELDS values now shows its "too many for a form" sentence as one plain muted line, with no card wrapper. The change is in src/web/render/config.ts.

The new test, test/config-too-many.test.ts, renders a JSON file with MAX_FIELDS + 1 values. It asserts the sentence is there and that the output contains no card. I did not run it against main to confirm it fails there. bun x tsc --noEmit, bun scripts/design-lint.ts and the config-related test files pass (54 tests). I did not run the full bun test, since the forge runs the full check on push.

I left the settings form beneath it alone, as the issue says. I did not add a TOML case, since both formats go through the same branch.

To try it, open a JSON or TOML file with more than MAX_FIELDS values on its code page.

I didn't call keep_plan; it isn't among my tools in this session.

🤖 Generated with Claude Code

Closes #10054

commented

A config file with more than MAX_FIELDS values now shows its "too many for a form" sentence as one plain muted line, with no card wrapper. The change is in src/web/render/config.ts.

The new test, test/config-too-many.test.ts, renders a JSON file with MAX_FIELDS + 1 values. It asserts the sentence is there and that the output contains no card. I did not run it against main to confirm it fails there. bun x tsc --noEmit, bun scripts/design-lint.ts and the config-related test files pass (54 tests). I did not run the full bun test, since the forge runs the full check on push.

I left the settings form beneath it alone, as the issue says. I did not add a TOML case, since both formats go through the same branch.

To try it, open a JSON or TOML file with more than MAX_FIELDS values on its code page.

I didn't call keep_plan; it isn't among my tools in this session.

🤖 Generated with Claude Code

commented

A config file with more than MAX_FIELDS values now shows its "too many for a form" sentence as one plain muted line, with no card wrapper. The change is in src/web/render/config.ts. The settings form beneath it is untouched.

test/config-too-many.test.ts renders a JSON file with MAX_FIELDS + 1 values and asserts the sentence is there and the output contains no card. I did not run it against main to confirm it fails there. bun x tsc --noEmit, bun scripts/design-lint.ts and the config-related tests (54) passed earlier. I did not run the full bun test; the forge runs the full check on push.

The gate had failed this pull because no commit message carried a Try: line. I added an empty commit with that line and pushed it instead of amending, to avoid a force push. bun scripts/gate.ts now exits cleanly here, but I haven't seen the forge's check re-run on the new push.

Try: open a JSON or TOML file with more than MAX_FIELDS values on its code page in the preview. You should see one plain muted sentence and no card.

I did not add a TOML case; JSON and TOML go through the same branch.

🤖 Generated with Claude Code

Approved

The over-MAX_FIELDS branch now returns the bare muted paragraph. This is one plain line (principles 6 and 7: no box around a note), the words are plain (8), and nothing else moved. The test fails on main because main emits class="card". The change is a markup removal, so it works with JavaScript off and adds no input or write path. Next, I would: (1) make the test assert on the class="card" attribute rather than the bare word "card", so unrelated copy cannot trip it; (2) add a TOML case if the two formats ever split into separate branches.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs