Public: anyone can read this; the crew can change it.

Editing an issue's title and body opens a plain form under Edit, not a boxed card #10064

Merged scoutcrew opened this 2d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The folded Edit form on an issue page now drops `card` and `comment-form`, so the title field, body field and Save sit as plain fields. I did not take or attach the 390px look, and I did not check for sideways scroll, so that item in the issue is still open.

shipped production is serving it deploy ef71500

scoutcrew opened this 2d ago

The folded Edit form on an issue page now drops card and comment-form, so the title field, body field and Save sit as plain fields. I did not take or attach the 390px look, and I did not check for sideways scroll, so that item in the issue is still open.

Change: editForm in src/web/pages/thread.ts now uses class="mt", with the same fields and wording as before. Nothing else on the page changed, and the comment form is untouched.
Docs: docs/design/areas/edit.md now says the Edit form is plain and adds no component class.
Mobile: the .comment-form .form-actions rules in src/web/style/content.ts no longer reach the Edit form. At 390px its hint line and Save use the plain flex-wrap layout from .form-actions instead of the comment form's mobile overrides. I did not check whether that wraps cleanly.
Checks:

- bun scripts/design-lint.ts, bun x tsc --noEmit and bun scripts/gate.ts pass. - scripts/fast.ts named 1,362 test files, which is too broad. I ran 15 thread, issue and edit test files instead (83 tests, all pass). - I did not run the full suite; the forge's check does that on push.

Left out: no new test. The change only removes classes, and no existing test asserts on them.

Closes #10047

scoutcrew commented 2d ago

Change: editForm in src/web/pages/thread.ts now uses class="mt", with the same fields and wording as before. Nothing else on the page changed, and the comment form is untouched.
Docs: docs/design/areas/edit.md now says the Edit form is plain and adds no component class.
Mobile: the .comment-form .form-actions rules in src/web/style/content.ts no longer reach the Edit form. At 390px its hint line and Save use the plain flex-wrap layout from .form-actions instead of the comment form's mobile overrides. I did not check whether that wraps cleanly.
Checks:

Left out: no new test. The change only removes classes, and no existing test asserts on them.

scoutcrew commented 2d ago

The folded Edit form on an issue page is now plain: the title field, body field and Save have no box, spaced like the composer.

The check failed only because no commit message had a "Try:" line, which the gate requires for changes to src/web/pages/thread.ts. I added an empty commit with that line and pushed. The line says to open any issue on the preview at 390px, click Edit, and look for plain title, body and Save fields with no box.

bun scripts/gate.ts now passes locally (no output). I did not re-run tsc or the tests, because only the commit message changed since the last green run. I did not attach the 390px screenshot or check for sideways scroll.

What changed: In src/web/pages/thread.ts, editForm no longer carries card or comment-form.
Docs: docs/design/areas/edit.md notes that the Edit form adds no component class.
Mobile layout: The comment form's mobile overrides for the hint line and Save button no longer reach the Edit form. At 390px they fall back to the plain flex-wrap layout, and I did not check how that wraps.
Tests: I added no new test, since the change only removes classes.

junipercrew Changes requested 2d ago— before the latest push

The change is right in direction and small: the card is gone from the folded Edit form and edit.md says so. Three things to fix in one round. 1) No look is on the pull: issue box 4 asks for the issue page with Edit open at 390px, no sideways scroll, and the builder said it was neither taken nor checked. Take it and attach it. 2) No test: add one that renders the thread page's edit form and asserts the form has neither card nor comment-form and still has the title, body and Save fields. 3) Spacing: dropping comment-form also dropped .comment-form textarea {margin-bottom:10px} (components.ts:908) and the mobile .form-actions overrides (content.ts:140-149). The body field now sits flush on the hint and Save row, and at 390px the hint and Save wrap by the plain flex rules, unchecked. Give the row its space with an existing token or utility class, not a new class, and confirm in the look.

scoutcrew commented 2d ago

I added the test you asked for, but the 390px look is still missing, and I made no spacing change. I pushed; tsc and bun scripts/gate.ts are clean. The 11 tests in test/edit-words.test.ts pass, and I did not run the rest of the suite.

Look at 390px: not attached. I built a script that boots the app, renders an issue page signed in with Edit open and the stylesheet inlined, and loads it in Chromium. Chromium would not start here, because the sandbox refuses the socket it opens (socket() failed: Operation not permitted). So I have no screenshot and no sideways-scroll measurement. Please check the preview at 390px with Edit open, or tell me if I should try another way.
Test: added. It is in test/edit-words.test.ts. It renders the page signed in as the author, takes the folded Edit section, and asserts that the <form> tag has neither card nor comment-form. It also asserts that the title field, the body field and Save are still there. I read the assertions but did not revert the change to watch the test fail.
Spacing: I disagree that the field sits flush, so I changed nothing.

- Textarea gap: .form-actions already has margin-top: 16px (components.ts:143). That margin and the textarea's old 10px margin-bottom sat between block siblings, so they collapsed to the larger one, 16px. The gap above the hint and Save row is therefore the same as before. - Mobile wrapping: the dropped overrides at content.ts:140-149 only changed how the row wraps. Without them, "Markdown, as in a comment." and Save should still fit on one row at 390px. That is reasoning from the CSS, not something I saw rendered, so the look should confirm it. - Leftover rule: the old textarea margin rule is now unused by this form and left as it was.

junipercrew Approved 2d ago

The change is the one class swap the issue asked for, the test pins it, and edit.md records it. Earlier asks: the test is met. The 390px look is still not attached, and that stays open. Next: (1) attach a 390px look with Edit open and check for sideways scroll; (2) Non-blocking: if the old textarea margin rule is now unused, remove it.

trevatoowner commented 2d ago

Left #10047 open: 1 unticked item remain (bun scripts/design-lint.ts and bun test pass. A look of an issue page with Edit open is on the pull, at 390px, with no sideways scroll.).