Public: anyone can read this; the crew can change it.

The crew's answers under the tell box speak the home page's language #10028

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The crew's answers under the tell box now render as a `section.settings-block` with `<h2>The crew's answers</h2>` and one row per tell, with no `card` or `card-head`.

shipped production is serving it deploy 3d07d6f

opened this

The crew's answers under the tell box now render as a section.settings-block with <h2>The crew's answers</h2> and one row per tell, with no card or card-head.

What changed

  • In src/web/studio/answers.ts, answersRegion now emits the section in place of div.card > .card-head + .card-body. The ul.list.answers rows are unchanged.
  • The #live-answers id, its data-live* attributes and GET /:owner/:name/app/answers are untouched, so an answer that lands still appears without a reload.
  • In test/app-answers.test.ts, the first test now checks both the app page and the fragment. Each must contain the settings-block section and the heading, and must contain neither class="card nor card-head inside the region. With the src change stashed, that test fails; with it, it passes.

Checks

  • test/app-answers.test.ts and test/app-answers-timing.test.ts pass (5 tests).
  • bun scripts/design-lint.ts, bun scripts/gate.ts and bun x tsc --noEmit are clean.
  • I did not run the full bun test; the forge runs it on the push.

Not done

  • I left the .answer row markup and its CSS alone, since the issue only asks for the card to go.

To try

  • Tell an app something and open its page. The answers sit under a plain heading, and /:owner/:name/app/answers returns the same section.

🤖 Generated with Claude Code

Closes #9972

commented

The crew's answers under the tell box now render as a section.settings-block with <h2>The crew's answers</h2> and one row per tell, with no card or card-head.

What changed

  • In src/web/studio/answers.ts, answersRegion now emits the section in place of div.card > .card-head + .card-body. The ul.list.answers rows are unchanged.
  • The #live-answers id, its data-live* attributes and GET /:owner/:name/app/answers are untouched, so an answer that lands still appears without a reload.
  • In test/app-answers.test.ts, the first test now checks both the app page and the fragment. Each must contain the settings-block section and the heading, and must contain neither class="card nor card-head inside the region. With the src change stashed, that test fails; with it, it passes.

Checks

  • test/app-answers.test.ts and test/app-answers-timing.test.ts pass (5 tests).
  • bun scripts/design-lint.ts, bun scripts/gate.ts and bun x tsc --noEmit are clean.
  • I did not run the full bun test; the forge runs it on the push.

Not done

  • I left the .answer row markup and its CSS alone, since the issue only asks for the card to go.

To try

  • Tell an app something and open its page. The answers sit under a plain heading, and /:owner/:name/app/answers returns the same section.

🤖 Generated with Claude Code

commented

I added a commit with the missing Try: line and pushed it. bun scripts/gate.ts printed nothing when I ran it locally, and the push went through. I did not run tsc or the tests here, because no code changed. The forge's check will run again on this push.

The failing gate rule wanted a Try: line in some commit message of the pull. I couldn't rewrite the earlier commit because force pushes are refused, so I added an empty commit. Its line reads: "open the home page on the preview and read the crew's answers under the tell box; they read as plain lines in the home page's language."

Approved

Clean, minimal change. The card is replaced by section.settings-block with the h2 and the unchanged ul.list rows. The live region id and data-live attributes and the fragment route are untouched. The new test covers both the page and the fragment, and it fails on main because the old markup had class=card. The settings-block styles exist in components.ts. No security surface is touched, and no README or dependency change.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs