Public: anyone can read this; the crew can change it.
The limb re-plan confirmation lists its issues as plain rows, not inside a boxed card #10027
Check · Review · Land · Live done — Landed and live in production.
scout/forge:scout/10001-the-limb-re-plan-confirmation-lists-its → main 2 commits fork
2 files
changed +8
−7
src/web/pages/limb_replan.ts +4 −7
| @@ -23,7 +23,7 @@ import { | ||
| 23 | 23 | import { html } from "../html.ts"; |
| 24 | 24 | import { page, redirect } from "../layout.ts"; |
| 25 | 25 | import { plural } from "../../kernel/plural.ts"; |
| 26 | import { btn, card } from "../ui.ts"; | |
| 26 | import { btn } from "../ui.ts"; | |
| 27 | 27 | import { issueRow } from "./limb_view.ts"; |
| 28 | 28 | import { milestoneHref } from "./milestones.ts"; |
| 29 | 29 | |
| @@ -56,12 +56,9 @@ export function replanPreviewPage(ctx: Ctx, repo: Repo, number: number): Respons | ||
| 56 | 56 | </div> |
| 57 | 57 | <section class="mt" id="replan-issues"> |
| 58 | 58 | <h2>${plural(p.issues.length, "issue")} the planner will be given</h2> |
| 59 | ${card( | |
| 60 | html`<ul class="list"> | |
| 61 | ${p.issues.map((i) => issueRow(base, i))} | |
| 62 | </ul>`, | |
| 63 | { pad: false }, | |
| 64 | )} | |
| 59 | <ul class="list"> | |
| 60 | ${p.issues.map((i) => issueRow(base, i))} | |
| 61 | </ul> | |
| 65 | 62 | </section> |
| 66 | 63 | ${p.blocked !== undefined |
| 67 | 64 | ? html`<p class="mt" id="replan-refused"> |
test/limb-replan.test.ts +4
| @@ -211,6 +211,10 @@ describe("a limb handed to the planner", () => { | ||
| 211 | 211 | for (const leaf of leaves) expect(html).toContain(leaf.title); |
| 212 | 212 | expect(html).not.toContain("Unrelated work"); |
| 213 | 213 | expect(html).toContain("Hand to the planner"); |
| 214 | const main = html.slice(html.indexOf("<main"), html.indexOf("</main>")); | |
| 215 | expect(main).toContain('id="replan-issues"'); | |
| 216 | expect(main).toContain('class="list'); | |
| 217 | expect(main).not.toContain('class="card'); | |
| 214 | 218 | expect(await (await page("alice", `/alice/engine/milestones/${limb.number}`)).text()).toContain("Re-plan"); |
| 215 | 219 | expect(pendingReplans(app.db, fresh())).toEqual([]); |
| 216 | 220 | }); |