Public: anyone can read this; the crew can change it.

An archived origin's missing-scope warning is one plain line with its action, not a boxed alert card #10026

Closed opened this
Closed without merging

The missing-scope warning on an archived origin's page is now one plain , with the "Replace the token" link inside it. No card, no role="alert", no attn tone. The page's tests pass, the type check is clean and bun scripts/design-lint.ts passes.

Notes

stopped closed without shipping deploy e7aab8e

opened this

The missing-scope warning on an archived origin's page is now one plain <p>, with the "Replace the token" link inside it. No card, no role="alert", no attn tone. The page's tests pass, the type check is clean and bun scripts/design-lint.ts passes. I didn't run bun scripts/gate.ts or the rest of the suite; the forge's check runs those on the push.

  • Page (src/web/pages/origin-archived.ts): the !canWrite block is a muted small <p> naming the missing scope and its code, then a ghost-variant link button. I dropped the old trailing sentence ("Replace it on the origins page, and this page will offer Restore.") because the link now says it. The unused card import is removed.
  • Test (test/web-origin-archived.test.ts): the missing-scope test now asserts the sentence and the link are present, role="alert" is absent, and no class="card appears in <main> above the list form. It fails on the old code and passes on the new.
  • Choice: the "no card" check covers only the part of <main> above the list form. The repository list and empty state below it are legitimately cards, so checking all of <main> would fail for the wrong reason.

To try it: connect an origin whose token lacks write:repository, then open /settings/origins/:id/archived.

🤖 Generated with Claude Code

Closes #10000

commented

The missing-scope warning on an archived origin's page is now one plain <p>, with the "Replace the token" link inside it. No card, no role="alert", no attn tone. The page's tests pass, the type check is clean and bun scripts/design-lint.ts passes. I didn't run bun scripts/gate.ts or the rest of the suite; the forge's check runs those on the push.

  • Page (src/web/pages/origin-archived.ts): the !canWrite block is a muted small <p> naming the missing scope and its code, then a ghost-variant link button. I dropped the old trailing sentence ("Replace it on the origins page, and this page will offer Restore.") because the link now says it. The unused card import is removed.
  • Test (test/web-origin-archived.test.ts): the missing-scope test now asserts the sentence and the link are present, role="alert" is absent, and no class="card appears in <main> above the list form. It fails on the old code and passes on the new.
  • Choice: the "no card" check covers only the part of <main> above the list form. The repository list and empty state below it are legitimately cards, so checking all of <main> would fail for the wrong reason.

To try it: connect an origin whose token lacks write:repository, then open /settings/origins/:id/archived.

🤖 Generated with Claude Code

commented

Declined: there is nothing to fix. The preview deploy succeeded. The log you pasted ends with ready:, serving https://lab--10026--forge-trevato-apps.open-platform.sh and done:, and the app answered 1.2s after it started. The "no tests declared, none run" line is the deploy noting that forge.json has no app.test entry. This repository runs its tests in the check block instead, so that line is expected and not an error. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m6zhj7w02zqvyt21vgqebv46

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs