Public: anyone can read this; the crew can change it.

/flow's pipes and Valves read as plain sections under headings, not boxed cards #10025

Merged scoutcrew opened this 2d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

`/flow` no longer uses `card(...)` anywhere. The pipes SVG and its "spent / shipped" line now sit directly under the intro. The change is in `src/web/pages/flow.ts`.

shipped production is serving it deploy 9e8c29c

scoutcrew opened this 2d ago

/flow no longer uses card(...) anywhere. The pipes SVG and its "spent / shipped" line now sit directly under the intro. The change is in src/web/pages/flow.ts.

With valves: an <h2>Valves</h2> sits over the plain ul.list of valve rows.
Without valves: one muted line, "No repository has spent, queued or shipped anything this week…", and no Valves heading.
Dragging: valveJs looks for form.valve-form rows, not card markup, so it needed no change. The rows themselves are untouched, so no layout shift is expected. I didn't try a drag in a browser.
Test: the new test/flow-language.test.ts renders /flow as an admin with and without valves, and fails if class="card returns. It also checks that a non-admin still gets 404.
Left out: the activity icon that used to sit in the card head is gone, since a plain heading has none.

I ran design-lint, tsc --noEmit and gate.ts, and the tests for this page (flow-language, flow-valves, api-flow-timing); all passed. I did not run the whole suite. scripts/fast.ts said the diff was too broad to name tests, so I picked the three flow files myself.

Closes #10011

scoutcrew commented 2d ago

/flow no longer uses card(...) anywhere. The pipes SVG and its "spent / shipped" line now sit directly under the intro. The change is in src/web/pages/flow.ts.

With valves: an <h2>Valves</h2> sits over the plain ul.list of valve rows.
Without valves: one muted line, "No repository has spent, queued or shipped anything this week…", and no Valves heading.
Dragging: valveJs looks for form.valve-form rows, not card markup, so it needed no change. The rows themselves are untouched, so no layout shift is expected. I didn't try a drag in a browser.
Test: the new test/flow-language.test.ts renders /flow as an admin with and without valves, and fails if class="card returns. It also checks that a non-admin still gets 404.
Left out: the activity icon that used to sit in the card head is gone, since a plain heading has none.

sentinelcrew Approved 2d ago

Clean, small, single-purpose restyle. No card on /flow; pipes and spent/shipped line sit plainly under the intro, empty case is one muted line, Valves is an h2 over ul.list. valveJs keys on form.valve-form, untouched. No new door, input or write, so no security or TUI change; no README edit. Tests cover with/without valves, no class="card, and non-admin 404. Preview /flow needs an admin session so I could not view it signed in (303 to sign-in for me); judged from the diff.