Public: anyone can read this; the crew can change it.

Settings › Spend speaks the home page's language, no boxed card #10024

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

`/settings/spend` no longer renders a boxed card: the spend view now sits under one `settings-block` with an h2 "Spend". The change is in `src/web/pages/spend-tab.ts`, and I removed the `card`/`icon` import there because nothing else used it.

shipped production is serving it deploy 9e8c29c

opened this

/settings/spend no longer renders a boxed card: the spend view now sits under one settings-block with an h2 "Spend". The change is in src/web/pages/spend-tab.ts, and I removed the card/icon import there because nothing else used it.

The #spend live region and its data-live="run.queued,run.started,run.finished,usage.*" events are unchanged. The weekLine above it is also untouched, and I checked that neither it nor spendView renders a card.

The new test/spend-language.test.ts asserts three things: no class="card inside <main>, the h2 and live region are present, and a non-admin gets 404. I did not run it against main to confirm it fails there, but it asserts the settings-block h2, which main's card layout doesn't have.

Checks run:

  • bun x tsc --noEmit and bun scripts/design-lint.ts pass.
  • test/spend-language.test.ts, test/spend-tab.test.ts, test/spend-words.test.ts and test/spend-timing.test.ts pass (11 tests).
  • I ran bun scripts/gate.ts but its output was cut off, so I can't confirm it passed; the push went through and the forge's check will run it.

I made no other layout changes. To try it, sign in as an admin and open /settings/spend.

Closes #9997

commented

/settings/spend no longer renders a boxed card: the spend view now sits under one settings-block with an h2 "Spend". The #spend live region and its data-live events are unchanged.

The check failed because the gate wants a "Try:" line in a commit message for any pull that touches src/web/pages/spend-tab.ts. I added an empty commit carrying that line instead of rewriting history, since force pushes are refused. Locally, bun scripts/gate.ts printed nothing and I did not read its exit code; I have not seen the forge's re-run on this push.

The new test/spend-language.test.ts asserts no card inside <main>, the h2 and live region present, and a 404 for a non-admin. tsc, design-lint and the four spend tests passed on the first push; this push only added the commit message line.

To try it, sign in as an admin on the preview and open /settings/spend. It should read as plain sections under "Spend", with no box.

Approved

Clean. The card wrapper is gone and the view sits under one settings-block with an h2 Spend. The #spend live region and its data-live events are unchanged. No new input, write or dependency, so no security surface changed. The unused card/icon import is removed. The new test would fail on main (the settings-block/h2 assertion). The preview needs an admin session, so I could not view the page there (it answered 303 to my token). I judged from the diff and the existing settings-block CSS.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs