Public: anyone can read this; the crew can change it.

A frozen mirror says so in one line on its repository page, not in a boxed card #10015

Parked opened this
Closed without merging

A frozen mirror now says so in one boxed-free line on its repository page and its branches page, and the change is pushed. What changed frozenBlock in src/web/pages/frozen.ts no longer uses card(). It renders a plain holding the sentence and the action.

Notes

stopped parked by the crew deploy a98596e

opened this

A frozen mirror now says so in one boxed-free line on its repository page and its branches page, and the change is pushed.

What changed

  • frozenBlock in src/web/pages/frozen.ts no longer uses card(). It renders a plain <section id="frozen"> holding the sentence and the action.
  • An admin with a working origin on the same site sees the "Reconnect through" select and button. They post to /:owner/:name/settings/origin/reconnect, which still goes through the same-origin check.
  • An admin with no such origin sees a link to Settings → Origins. A reader sees only the sentence.
  • frozenSentence and reattachMessage are unchanged, and no new CSS class was added.

Tests

  • New test/frozen-line.test.ts covers both pages for a reader, an admin without an origin, and an admin with one. It also checks that a cross-origin POST to the reconnect action is refused.
  • I did not run it against main to see it fail. It would fail there, because main renders a card and the test looks for a <section id="frozen"> that main doesn't have.
  • It passes here, as does test/mirror-reattach-refusals.test.ts. tsc --noEmit, design-lint and gate show no problems.
  • I did not run the full bun test, only these two files. scripts/fast.ts said the diff reaches 1,348 test files, over its time budget. The forge's check runs the full suite on this push.

Not done

  • The empty-repository home page doesn't render frozenBlock at all, so a frozen mirror with no commits shows no line there. It was like that before and I left it alone.

To try it Mark a repository as a disconnected mirror by setting origin_id to NULL and filling origin_full_name, origin_html_url and origin_detached_at on its repo row. Then open it and its /branches page as an admin and as a reader.

🤖 Generated with Claude Code

Closes #9953

2 earlier comments
commented

A frozen mirror now says so in one boxed-free line on its repository page and its branches page, and the change is pushed.

What changed

  • frozenBlock in src/web/pages/frozen.ts no longer uses card(). It renders a plain <section id="frozen"> holding the sentence and the action.
  • An admin with a working origin on the same site sees the "Reconnect through" select and button. They post to /:owner/:name/settings/origin/reconnect, which still goes through the same-origin check.
  • An admin with no such origin sees a link to Settings → Origins. A reader sees only the sentence.
  • frozenSentence and reattachMessage are unchanged, and no new CSS class was added.

Tests

  • New test/frozen-line.test.ts covers both pages for a reader, an admin without an origin, and an admin with one. It also checks that a cross-origin POST to the reconnect action is refused.
  • I did not run it against main to see it fail. It would fail there, because main renders a card and the test looks for a <section id="frozen"> that main doesn't have.
  • It passes here, as does test/mirror-reattach-refusals.test.ts. tsc --noEmit, design-lint and gate show no problems.
  • I did not run the full bun test, only these two files. scripts/fast.ts said the diff reaches 1,348 test files, over its time budget. The forge's check runs the full suite on this push.

Not done

  • The empty-repository home page doesn't render frozenBlock at all, so a frozen mirror with no commits shows no line there. It was like that before and I left it alone.

To try it Mark a repository as a disconnected mirror by setting origin_id to NULL and filling origin_full_name, origin_html_url and origin_detached_at on its repo row. Then open it and its /branches page as an admin and as a reader.

🤖 Generated with Claude Code

commented

A frozen mirror's page now says so in one plain line instead of a boxed card. This push changes no code; it only fixes the check that failed.

The gate wanted a Try: line in a commit message for a pull that changes src/web/pages/frozen.ts. I added an empty commit carrying that line, since I can't rewrite history. I did not re-run the gate, tsc or the tests here, because nothing in the tree changed.

Try: open a frozen mirror's page on the preview (https://lab--10015--forge-trevato-apps.open-platform.sh) and check that it shows one line saying it is frozen, with no boxed card.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs