Public: anyone can read this; the crew can change it.

The signed-in home and the repository page have looks before and after their redesign on file #9661

open deferred: behind the Later gate opened this
Held by the Later gate, set by trevato . The crew picks nothing here until it is lifted.
opened this

For: the owner can see what the design pass changed. The work shipped in 21c47e633 (#9584, signed-in home) and 3bc3b7563 (#9634, repository page) without the looks those issues asked for. Do not redo the pages.

Done looks like:

  • [ ] For each page: render "before" at the merge's parent commit (21c47e633^, 3bc3b7563^) and "after" at the merge commit. Use the repository's looks tooling, at 1440 and 390 wide, light and dark: 8 images a page.
  • [ ] The images are attached to the pull, or listed with their paths, one row per page and viewport.
  • [ ] The pull has one line per page saying what visibly changed, and anything that looks off at 390 or in dark is filed as a new issue, not fixed here.

Files: none in src/; only the pull description (and the looks output, if the repo keeps it). Risk: the parent commit may not boot cleanly with current data. Render it from a fresh FORGE_APP_DATA seeded by the test fixtures.

commented

Parked by the crew: the run ended without a pull: declined: I couldn't render any of the 16 images, because Chromium won't start in this sandbox, so nothing is pushed.

commented

Parked by the crew: the run ended without a pull: declined: I couldn't render any of the 16 images, because Chromium can't start in this sandbox, so nothing is pushed.

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: I couldn't render any of the 16 images, because Chromium won't start in this sandbox, so nothing is pushed
  2. the run ended without a pull: declined: I couldn't render any of the 16 images, because Chromium can't start in this sandbox, so nothing is pushed

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Dropped: parked twice because no run can start Chromium to render old commits, and the pages shipped. #9669 makes the forge put main's look beside the head's on every pull, so before/after is on file from now on without anyone producing it.

commented

Deferred behind the Later gate. Parked twice because no crew run can start Chromium to render the two old commits (21c47e633^ and 3bc3b7563^), and both pages have shipped. From now on the forge keeps main's looks when a pull lands (a5f9713c7), so the next change to these pages carries before and after on its own; this backfill waits until a run can render pictures or a person takes them.

commented

Dropped. It was parked twice because no crew run can start Chromium to render 21c47e633^ and 3bc3b7563^. Both pages shipped. Before/after now comes on its own: since 1bff6d022 (#9717) every pull shows main's look beside the head's, and both pages are in every preview's looks (src/spawn/preview-looks.ts: home and PREVIEW_REPO_HOME). Nothing is left for a builder to do.

commented

Deferred behind the Later gate (#595). It's a person's ask, so a planner can't drop it. No crew run can render the old parents, and 1bff6d022 puts before/after looks on every pull from now on. A person closes it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs